From patchwork Mon Apr 2 16:49:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suman Anna X-Patchwork-Id: 132670 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp2784801ljb; Mon, 2 Apr 2018 09:50:24 -0700 (PDT) X-Google-Smtp-Source: AIpwx48c6BWrhL4YH1bJdkxVUPW8VEthpmYIj6e01w358fLNj6nsbUGa9m6G3uipglj1RUFByMAX X-Received: by 10.98.78.21 with SMTP id c21mr7948157pfb.107.1522687823988; Mon, 02 Apr 2018 09:50:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522687823; cv=none; d=google.com; s=arc-20160816; b=ZD1dLG2lAX8J8QEjARJVPdQDm+nAkMHA2hZZjdjVx5KWeXmOamFYwxS4PJVR78CMNz EmhojjIwONurF8qorEzN32c6jFpIkU3SjMjBXofQO9R8eHr2Tu2/tZ/10IKZJEtyYd0Z T3/jYZTeDE9iWLwGBEm72nfhwFtCKmo8elrmzHG8rMJcF7oq990S/F9+H/NGYjsfSWWt v77h9Mjtwe7rxVboyV47YuNF7+Ux1DPPRDP89ODpGzJ5Y2B5Rj7+t9nlxWmUDtCxRfp+ JJbmltJRqce7lDutLW5NCkU9ZIObA55+o/V9rWMP8nTgxpDDqeDGHo2wWiLLxQfLbzNQ zNbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=ooeEufv5PjtRyNzKWMdq7Mv7bgq9rwjvenpqMwZzHz4=; b=hz06jri4Xdras75XgKBQU4M/xX4ua10nZ9WrZlXJUYjXDvSOGGYepPINCDgnn8kGu8 SNY5voQKDxFJ1Rh0aBxd5RKOkLheQHvtPz8cxTHM6mzwbuBdvJe5DdWVyxHdMU/y+csZ joMWi7/HoL2ak6Yt+uypVSZu+1FOExpLS1oQi3eIR5omrLsmyhdpH06KuTIqzccaNR/U YYkgXULIUYxLKLE9BQPDTT1UVT++Em/Do+FXkNjDZiTUF26mw060/icpjq2fP00Gc4Pr SmexDKUdp2MjVaEeaNy2UAWv/4xyytO1twgEYsgBuJRXnUDT8M+9Mt9DWwQyAUcKrKCe k0Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kJJ/Btaz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si480289pgc.117.2018.04.02.09.50.23; Mon, 02 Apr 2018 09:50:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kJJ/Btaz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753143AbeDBQuU (ORCPT + 29 others); Mon, 2 Apr 2018 12:50:20 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:21921 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035AbeDBQuN (ORCPT ); Mon, 2 Apr 2018 12:50:13 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id w32GoAHW024973; Mon, 2 Apr 2018 11:50:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1522687810; bh=EXaxPND3kRCe3Blc3fkPYU3N/ryQnDcM3tiRHH/GmG0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=kJJ/BtazH9VE+S+jRiJKJLBwIVkeStMl9XW8ZWG+Ws5Eomp1h6ihUskc2J7SZyviG eTS+nEBejbGQEL08jSrXd3XmErXjbQk7YiGdggTy9rfntdy0PJrqH/e8hOV9WOsBXd RvvpX8xFFSc7OqCok+L5fJK+nf7QelRZjnK1r61A= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w32GoAlV012540; Mon, 2 Apr 2018 11:50:10 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Mon, 2 Apr 2018 11:50:09 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Mon, 2 Apr 2018 11:50:09 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w32Go9FZ027254; Mon, 2 Apr 2018 11:50:09 -0500 Received: from localhost (irmo.dhcp.ti.com [128.247.58.153]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id w32Go9x06712; Mon, 2 Apr 2018 11:50:09 -0500 (CDT) From: Suman Anna To: Viresh Kumar CC: "Rafael J. Wysocki" , Dave Gerlach , Tero Kristo , , , Suman Anna , Zumeng Chen Subject: [PATCH v2 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe() Date: Mon, 2 Apr 2018 11:49:58 -0500 Message-ID: <20180402164958.20057-3-s-anna@ti.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180402164958.20057-1-s-anna@ti.com> References: <20180402164958.20057-1-s-anna@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ti_cpufreq_probe() function uses regular kzalloc to allocate the ti_cpufreq_data structure and kfree for freeing this memory on failures. Simplify this code by using the devres managed API. Cc: Zumeng Chen Signed-off-by: Suman Anna --- drivers/cpufreq/ti-cpufreq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.16.2 diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c index 46d1ab2dea87..7d353a21935b 100644 --- a/drivers/cpufreq/ti-cpufreq.c +++ b/drivers/cpufreq/ti-cpufreq.c @@ -217,7 +217,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev) if (!match) return -ENODEV; - opp_data = kzalloc(sizeof(*opp_data), GFP_KERNEL); + opp_data = devm_kzalloc(&pdev->dev, sizeof(*opp_data), GFP_KERNEL); if (!opp_data) return -ENOMEM; @@ -226,8 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev) opp_data->cpu_dev = get_cpu_device(0); if (!opp_data->cpu_dev) { pr_err("%s: Failed to get device for CPU0\n", __func__); - ret = -ENODEV; - goto free_opp_data; + return -ENODEV; } opp_data->opp_node = dev_pm_opp_of_get_opp_desc_node(opp_data->cpu_dev); @@ -285,8 +284,6 @@ static int ti_cpufreq_probe(struct platform_device *pdev) fail_put_node: of_node_put(opp_data->opp_node); -free_opp_data: - kfree(opp_data); return ret; }