From patchwork Mon Mar 19 16:00:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132087 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp51856ljb; Mon, 19 Mar 2018 14:05:41 -0700 (PDT) X-Google-Smtp-Source: AG47ELvdhQgYzMFX7isKd+/JCHHxkp943/0Y4OGi3O0le96mHMagHpU2B53MML+P1Tgojqbphtod X-Received: by 10.98.39.7 with SMTP id n7mr9727412pfn.161.1521493540938; Mon, 19 Mar 2018 14:05:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521493540; cv=none; d=google.com; s=arc-20160816; b=e9KsF15o+kXEiqOFlUH/W7cQjfAJweQLTwoJ7nvTBm2J6Am2Lfs/H+2mq5Uj3moNUE GgIxywtwTTrT7yBpvm3yarqbYzh2AI/GOqo2CgTpmiYHN5z+DdgmPwmpleBCKoVjNfmm Jp1AvltTtdyZRMhHMpmQ3vETTMwbZjen0u4YnaMz0MfRrZmNSGH6wpypN46KYLbZsOPK 1RYu62Kcur3UzzpVMO/eKcOrD7wQW1VIsGt+DCSF1VC8SoUEgwiJyLj6xxsAiZ3/xvU3 mO/gIXXn5oJZncgGkYXgVWbndWIyfiAU26sEQ2E+naTjWep0u0RcZ6UiIvKvw57f9ilG 5zTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=EJwL4tvhXzoaOOF7EmDtg8Dpg7cLWV6DbXyaeR00pUM=; b=yIQRg1/MdXx8/OcTv+q//yKuuQr1O8u1GDAk93T8rFgahdqD6usW3TPNwRWoof19tu oh25abvHVVcPrLwnrYFAmFSadxIHlTu0ehjB2qvcIh5HRkN2AEmouD6Bp5raftUnqPLE ZC5wTF4YsvyVyXlXrmizqwCLdm6xRnucY0/Xj2Ju+epxT9aWtMdukVWEHSa02Nb4HuQN gGxShJBd0PbQbwgTCBM6qKKipn+grf6eQ1XCH47NVo2KXruc8NPe4CsWGshmzJ2r0DlJ ajM4ORB3UOnwTsSw2X91rpc/BJaDlfV5pm5zbCNYWzMCg6M7ANnUdOs3SvwBX6L9AQZB WxTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=OvlP/sGK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30-v6si89211pla.444.2018.03.19.14.05.40; Mon, 19 Mar 2018 14:05:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=OvlP/sGK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935950AbeCSVFh (ORCPT + 28 others); Mon, 19 Mar 2018 17:05:37 -0400 Received: from mail-by2nam03on0102.outbound.protection.outlook.com ([104.47.42.102]:15805 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965402AbeCSQCJ (ORCPT ); Mon, 19 Mar 2018 12:02:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EJwL4tvhXzoaOOF7EmDtg8Dpg7cLWV6DbXyaeR00pUM=; b=OvlP/sGKm8gJHSntFDTJCMliQprjvndfwoefHppcP0yJ+3WrQs+h1BEUzdFtsy/qlJNt2Ionrf2M+VUJTdp1zNL8UdaiSMCL/97czItkOT80pW0z81oO60liC8p+v0c3mczrFBeH8Nz/e+VRhwhxa+KJXG5yAnHijOEeSUNToF8= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0919.namprd21.prod.outlook.com (52.132.132.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.0; Mon, 19 Mar 2018 16:01:54 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62%5]) with mapi id 15.20.0631.004; Mon, 19 Mar 2018 16:01:54 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Linus Walleij , "Reported-by : Jason Kridner" , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 143/281] gpio: label descriptors using the device name Thread-Topic: [PATCH AUTOSEL for 4.9 143/281] gpio: label descriptors using the device name Thread-Index: AQHTv5tundPwP6roUE2iSbsKOBYZGg== Date: Mon, 19 Mar 2018 16:00:42 +0000 Message-ID: <20180319155742.13731-143-alexander.levin@microsoft.com> References: <20180319155742.13731-1-alexander.levin@microsoft.com> In-Reply-To: <20180319155742.13731-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0919; 7:vM4rHg7lFOTu4jt4F7r19MMNjZ+4T9WdZMTGjwppMLycmS6EGxZYE5+PKPuKOu2xVMmfbX2YRPv/U7VMlBDLx7PyOW/XN9C3AFNn3A68c8kx9Ja4bpH32GLd0BoI07iWGkK2X3EuUUBvblRp8wTJ/644jlHQmSgOouLFmVYg9FpWwhUtJ6T3mNELrv/o4sgmss2aIbIAMqjmXcr3hHVi+kSU5IIFIXfxRSyD2h3LkuYAmFclLgFwIYCn4/iCZ7Rx; 20:lIvigBtoQjh2BojaxYKRn2HCGQPSU/f6fDPxDTmCxEloDBegYxaHYHzZLnvo4FYNTWPv/vv3PSlY56V16eF8NHoMy7jkAGG5Hda4MU+TwsdcPjwL64dsX+tUQ6rvutIYbsDSPQ/BJSIHSFJzhJaBDdQryCHcP9omQ3TWCoAJ6p8= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1ea606be-07b9-482b-7769-08d58db2bc85 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB0919; x-ms-traffictypediagnostic: DM5PR2101MB0919: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501300)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB0919; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0919; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39380400002)(396003)(39860400002)(376002)(366004)(199004)(189003)(66066001)(2906002)(86362001)(10290500003)(105586002)(8676002)(305945005)(110136005)(478600001)(4326008)(7736002)(81166006)(3280700002)(6506007)(97736004)(107886003)(5660300001)(36756003)(8936002)(53936002)(86612001)(14454004)(59450400001)(1076002)(2501003)(6116002)(10090500001)(76176011)(186003)(3846002)(5250100002)(6512007)(99286004)(102836004)(106356001)(72206003)(81156014)(2950100002)(6666003)(54906003)(3660700001)(22452003)(68736007)(6486002)(25786009)(26005)(316002)(2900100001)(6436002)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0919; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xIhL56qlfxdeu4wUBqoqFFtEcXQb3KYK5FlBakFQmLpsKTZqMjVPqacUziQPgMYRv/5QB/FwRuDSL4P4ECeL6zFQCPowO+GaqpuR2t+eAev5L6hDWkyzDdFz5Rzd12AAdwtQbjpxTk648zZPx/gkKm1EMCPV7rS8VBh7dL5jWtz8U5nW2Q5+/tGNq/6L2nSEzTxZiSqm1wDgEAnCOLzF3WYPHxDRtGzO/e4KE/WB6nyUO9D7EEhK+DHNHm7tbnUhzbBrKDuiHLLp4pRPOBAFfdaYudrLpVFeIJgvFjFFmslqgbSYIw4z7hjfHtjahbZzLdxCcOz/q11dvlIDHrn+cA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea606be-07b9-482b-7769-08d58db2bc85 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 16:00:42.6492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0919 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit 24e78079bf2250874e33da2e7cfbb6db72d3caf4 ] Some GPIO lines appear named "?" in the lsgpio dump due to their requesting drivers not passing a reasonable label. Most typically this happens if a device tree node just defines gpios = <...> and not foo-gpios = <...>, the former gets named "foo" and the latter gets named "?". However the struct device passed in is always valid so let's just label the GPIO with dev_name() on the device if no proper label was passed. Cc: Reported-by: Jason Kridner Reported-by: Jason Kridner Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/gpio/gpiolib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index f3c3680963b9..4f54ff45e09e 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3231,7 +3231,8 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev, return desc; } - status = gpiod_request(desc, con_id); + /* If a connection label was passed use that, else use the device name as label */ + status = gpiod_request(desc, con_id ? con_id : dev_name(dev)); if (status < 0) return ERR_PTR(status);