From patchwork Fri Mar 9 14:09:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 131108 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1037177lja; Fri, 9 Mar 2018 06:12:19 -0800 (PST) X-Google-Smtp-Source: AG47ELslVM3I4YRdvTpPzcB0eH3GB4AF9y46zsnt+J2siNLNxGnqbvTGhDKcgfcyUqjLb4MKnri7 X-Received: by 2002:a17:902:67c8:: with SMTP id g8-v6mr23688274pln.106.1520604739289; Fri, 09 Mar 2018 06:12:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520604739; cv=none; d=google.com; s=arc-20160816; b=APePl94jedLj2TgYQtIqyyaXFO6RLqm3tf1MTqiRnX5ZmJQhL8OoNVt37KCW+N+Z5D fpB4nYXJ0LypgCYfYA4VbGeJ0+C4ViJ5BkTjT0PzXUN8Aif1EdP7GvD/9Q+LL4KdBftH NpMPaYZKHqLq1J5hhZ2x9AmZh3ytiSCgZmXsC4/4+01VBMzVIsAWM+Hs9N0EFkY9cgjv HBBfjr74qRnCPFktb+mtQxz9NbyRPUjTuuDHWe4dFlPOIa0MCUeUUKPOm6RVzQtHis/x yiayOlPf0seWH6LWSCsawWyhDAvLiBQcUKjewJC2ajPwB/ELo54ECPBcHrPIj2sH/N+0 xAFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=rPGElMYpufYBkv9jLJugk+7y9zWU0jBjKWrRl+DRg0c=; b=lKvJ7L8q0josq0Asyaw6dp8J0ZW3C/eWdqnjFgPL9+U8Kz4AHR7qXjtdyas4VcNlpa PdRSRpn7sx1YtXqlpX8xMcvM5IdBfq2NYmU2iypn4bWx1mkGgcUYvT1zH7u+vNTwuiZj AubaQWq+NCG6vyAayVsiff/VhafRbftxaH4+pcAwr/vwnef2gN9MKWTEyAaBtPnaIBjz SABUco3fq6KOEYfzx6gk1gmRk4ZPVWHiFMjo1ICNXdkkXzZYiW/gFp2DLqcgjWuT8xAB 3/bcTi4IqDuj1XcpbIfqywGLwh/V1dMQUkROCyeh2aOzKhXNYlB45uffDbDlrDrZ+bsa qtrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kxcRnsM4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3-v6si933596pld.200.2018.03.09.06.12.19; Fri, 09 Mar 2018 06:12:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kxcRnsM4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbeCIOMQ (ORCPT + 28 others); Fri, 9 Mar 2018 09:12:16 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36642 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbeCIOML (ORCPT ); Fri, 9 Mar 2018 09:12:11 -0500 Received: by mail-wr0-f196.google.com with SMTP id v111so9168915wrb.3 for ; Fri, 09 Mar 2018 06:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=rPGElMYpufYBkv9jLJugk+7y9zWU0jBjKWrRl+DRg0c=; b=kxcRnsM44hlODQYkCENiu2fzr9BsVVHSTRTV7j4nAZk7zzHrBV710WXwJ6anyRpmmE PhFO2Zi3ulfy17ClV36hrndhp1D2k/gGgaOzoQCTS+GKxMLuPwgGjO8yjewwWN2U7dVP xC3eiFFH5RejAsZaO/62DwXZIPrcMwh6+yiHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rPGElMYpufYBkv9jLJugk+7y9zWU0jBjKWrRl+DRg0c=; b=RvdAdyCOnwc93XSaZ/mj95WidZHjr1l1nDp/b+iNuoqukXxi8PNaEUcTNkKpk7N7tZ Y1wc4Wk4DrhPbUcja2bz5IJE3p4JAlYpL0ePXyyU4aq1h/9y/4dPEXkjnlgiLEmEKU9o VOb/hhLgsTomWfps9feyv4USD+rXozb85yWrzrkcAeWQW17Ho6mxPK2Gc8M3+1/U/9yp zt7RjrImHQpv57CzSl35tq8j/qYYMxU27jQiZjBxVHZSdGgyrci3skqTCEs9c2xpx5tj bcQwUV0X7gGpujHR7oni+hSI3Uxvplzu2n0S83xYf7RWftOBG2aaDcEWw8FXVKKoz+8P qovA== X-Gm-Message-State: APf1xPDHGEc7K8dxEe+fqLaX4b15lpuwiYYDageZQLZH9fc55KiSW+BB DNLqwd7EBGaKx0PDW8EqVbUGDV9lLps= X-Received: by 10.223.191.6 with SMTP id p6mr25026142wrh.247.1520604730461; Fri, 09 Mar 2018 06:12:10 -0800 (PST) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id i49sm1276255wra.44.2018.03.09.06.12.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 06:12:09 -0800 (PST) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org, Arvind Yadav Subject: [PATCH] slimbus: core: use put_device() instead of kfree() Date: Fri, 9 Mar 2018 14:09:59 +0000 Message-Id: <20180309140959.30237-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arvind Yadav Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav Signed-off-by: Srinivas Kandagatla --- Hi Greg, Can you pick this single slimbus patch for 4.17 merge cycle. Thanks, srini drivers/slimbus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 4988a8f4d905..7ddfc675b131 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -141,7 +141,7 @@ static struct slim_device *slim_alloc_device(struct slim_controller *ctrl, sbdev->e_addr = *eaddr; ret = slim_add_device(ctrl, sbdev, node); if (ret) { - kfree(sbdev); + put_device(&sbdev->dev); return NULL; }