From patchwork Thu Mar 8 04:57:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130954 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp6111266lja; Wed, 7 Mar 2018 22:44:33 -0800 (PST) X-Google-Smtp-Source: AG47ELsgzGiZKemqp0lR4MQP4+GxeZycdMnmoTdnUH74QG8F7ThicXjvLdbKLX3s7f6n8pgPC9Lj X-Received: by 2002:a17:902:aa43:: with SMTP id c3-v6mr23194572plr.357.1520491473282; Wed, 07 Mar 2018 22:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520491473; cv=none; d=google.com; s=arc-20160816; b=Wp+6WMWEqCg35dN5Tz2WJq4tofIDvTUmkoNuoJLka/BKxqbkZv27wiRxCy3scbzwtJ dZdkgrT8EuP06L/eOxUb0ENYSyhUYrwkG1iY08LEhfRjGUXuIqmuSyUT/AC0EulPxhZ/ PyRCFMnTT2m+42VGT5UgcFJITFv/rSaD9Kcdi7T+MGqWk0H6LPMJeV341l3jqgtqN7RF qODPsGqqQUE0WX/t31GQKI0HFUtWO8I/KFcM+H4QL1sDiKkh7I/DQcSgnGGrrTTpElb6 VEy1E62eFmxY7UcK02G3KiR4LHSFy+nzsAUnlVi1UesNMhmfCo1hx5Dg+GqmY0rqVfys d64A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=CfDgM3ffS9q7yBULnRbax/VLYMGu2rMpaIoCQ0XLERk=; b=e0bGMayj65HCLo0A9qkKuH0RFZNlk5mdme1dvuWqTvZ/FQ6/H7SNqpPJXOZhe8YcKU k/tbChIjGp/s04JMaSHtQTBfMAm/OqgERJWzucf4rjFlP4gARAF7ssCjjWaKlYlzo4Ys Rx0UaixBwtq5eqFlPaBa0N4Lu6tOvlJ58iNiYXkJafAfl3d7l0z7Tju33o2YrbgGC4Cv jzKLNAOQfqDYL2Jy70whkFSXpoYH5EmZjylzXl1LhnB1rwr7nT99aLxtbemBvbxdrMo/ 15YFk/NUN/OB6VH32QAJvbyANEevkS1RYZNtMQrNzt15BfoTHT6SrJY3md6Tt/jY+y6R 9f8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=BbjpEOKm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si13097576pfa.170.2018.03.07.22.44.33; Wed, 07 Mar 2018 22:44:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=BbjpEOKm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935323AbeCHE6d (ORCPT + 28 others); Wed, 7 Mar 2018 23:58:33 -0500 Received: from mail-sn1nam02on0119.outbound.protection.outlook.com ([104.47.36.119]:48736 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965035AbeCHE6L (ORCPT ); Wed, 7 Mar 2018 23:58:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CfDgM3ffS9q7yBULnRbax/VLYMGu2rMpaIoCQ0XLERk=; b=BbjpEOKmXofmlDMPwUFQ5PgNMw6a4qTJREuwyVcyWTjc1r1E6rPVm35/9y47wKcblsJopGJpjnWT6JZDasIeUFCkQlMxHBIZ39tWqwpx9yhXcJS3xdyaj0ZFYHgqannmgYfSvifxOaQWAyORyfUFTpoi1jGpHY5MpAOixCex8do= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0936.namprd21.prod.outlook.com (52.132.131.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.3; Thu, 8 Mar 2018 04:58:03 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0588.008; Thu, 8 Mar 2018 04:58:03 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Viresh Kumar , "Rafael J . Wysocki" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 03/67] cpufreq: longhaul: Revert transition_delay_us to 200 ms Thread-Topic: [PATCH AUTOSEL for 4.14 03/67] cpufreq: longhaul: Revert transition_delay_us to 200 ms Thread-Index: AQHTtpn3xwfsJ23HnECNJ1fyWoAn9g== Date: Thu, 8 Mar 2018 04:57:32 +0000 Message-ID: <20180308045641.7814-3-alexander.levin@microsoft.com> References: <20180308045641.7814-1-alexander.levin@microsoft.com> In-Reply-To: <20180308045641.7814-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0936; 7:N4PYFMpu9ITjk6/t1gnmGQc4xxbKSZDw5DuWVxyDSD+npIczUNZVHNcUo7P73B55iN4QP5tbsdFeBeadVwavjexWzgD/NyXOWSqIvv+7ur5pNg2LOsEsmCha7WAmjfoL3lckWL6BUxzmW+qGQ8DLmIfNbz6fmKy3H+uf2BqcaRa1WnlgFHlBU+tnuZeMN0dFwh74bhkKNfGfbOAteXgiINQ2Q4jR92n0B+MFLK4azz2fojBw/AIty/6toupAlpg0; 20:+4+czdFM67MiSJP4knfm4H8IXM8RobjsAOmP5PC15TE4eqRmadP4YiMzs8yVwqSOviQgYCi3ViF7U47EVJJDnw4gw6ENViDmRY8CfrWiD/AWcy+QB1SHua+Tqbesya73GSAeAxmKUIoleNDe9nNaIirax+qvgisaPG0Ji0pxK+w= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 42561d2a-962c-46bd-fa82-08d584b12c56 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB0936; x-ms-traffictypediagnostic: DM5PR2101MB0936: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231220)(944501244)(52105095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR2101MB0936; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0936; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(39860400002)(39380400002)(346002)(376002)(199004)(189003)(478600001)(99286004)(575784001)(6506007)(59450400001)(3660700001)(36756003)(86362001)(54906003)(6116002)(110136005)(2950100002)(102836004)(1076002)(3846002)(6486002)(3280700002)(10090500001)(10290500003)(305945005)(72206003)(6436002)(6666003)(26005)(5250100002)(2906002)(186003)(2501003)(105586002)(76176011)(66066001)(7736002)(68736007)(25786009)(6512007)(106356001)(86612001)(8936002)(107886003)(81166006)(2900100001)(5660300001)(4326008)(81156014)(53936002)(14454004)(97736004)(316002)(22452003)(8676002)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0936; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Xj9vew7cdAxHvl1Ip2T5B17PJ7wvabevldEJcG6qctlvmRHdYUo27XMsq10FhU9r9oBk9/DJUnDOub+0wPUfBPejLzj/88UMK7PppcA1wIcj2os9MANbWp4qATlKSTSPxuWYJrxCBe6mriUa3EGepAvKvWL9x9FzOsFQr6M9KU8mIeVNAwJuJ4QWJsIuuXmVFyrP8iamyvj6/YDC51OSkKgEfUPHhyOt/ScLojLUENdNXBlQcEXnYiXTkDgrHCJU6kQCEGiPsMF0TldfeB+CzQP0buk7C4bJs4EzNvEsoEolDaZsxp4KB1WCawYDBbtprj0xGtsN/PX50NiTX+d5FQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42561d2a-962c-46bd-fa82-08d584b12c56 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 04:57:32.6726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0936 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Viresh Kumar [ Upstream commit 1d0d064307cbfd8546841f6e9d94d02c55e45e1e ] The commit e948bc8fbee0 ("cpufreq: Cap the default transition delay value to 10 ms") caused a regression on EPIA-M min-ITX computer where shutdown or reboot hangs occasionally with a print message like: longhaul: Warning: Timeout while waiting for idle PCI bus cpufreq: __target_index: Failed to change cpu frequency: -16 This probably happens because the cpufreq governor tries to change the frequency of the CPU faster than allowed by the hardware. Before the above commit, the default transition delay was set to 200 ms for a transition_latency of 200000 ns. Lets revert back to that transition delay value to fix it. Note that several other transition delay values were tested like 20 ms and 30 ms and none of them have resolved system hang issue completely. Fixes: e948bc8fbee0 (cpufreq: Cap the default transition delay value to 10 ms) Reported-by: Meelis Roos Suggested-by: Rafael J. Wysocki Signed-off-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/longhaul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c index d5e27bc7585a..859a62ea6120 100644 --- a/drivers/cpufreq/longhaul.c +++ b/drivers/cpufreq/longhaul.c @@ -894,7 +894,7 @@ static int longhaul_cpu_init(struct cpufreq_policy *policy) if ((longhaul_version != TYPE_LONGHAUL_V1) && (scale_voltage != 0)) longhaul_setup_voltagescaling(); - policy->cpuinfo.transition_latency = 200000; /* nsec */ + policy->transition_delay_us = 200000; /* usec */ return cpufreq_table_validate_and_show(policy, longhaul_table); }