From patchwork Thu Mar 8 04:56:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130962 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp6125718lja; Wed, 7 Mar 2018 23:02:30 -0800 (PST) X-Google-Smtp-Source: AG47ELtp0Zklde51Q5Ad8C/P0IbeAu+PRMKDV+bEd3hEhq1fhPcOXoeWR07438KTMkWVaBXDEEEJ X-Received: by 2002:a17:902:3183:: with SMTP id x3-v6mr22925351plb.383.1520492549858; Wed, 07 Mar 2018 23:02:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520492549; cv=none; d=google.com; s=arc-20160816; b=bVA0bW2TD/nepkynDuR5YM0ZA6DwR3Cf4hYOF8ogU0aYjnipJ7ItuwHqkf0RWBlB7X JYj30yxxg2eMMq/p48nhG5ch9nNA398BGUCSrTWDq1uh2VqdjZkXeEQ7VSTe+PIPF0Zn BoGchOtFR6y9+W14dIFLSFdlqQLR3LrSln3YeHpzAjAczBwxTA65c7AzkTOw+Uoi8Z9H bkEz/k/YQGf0MjJlmRU2cEsHkwe0JepasrDjjbbvBEMIYrb/3JzqvhuwYXRBpC8lM1ac txaRe7HU2Pbc7T2EarJ7UWD6pUK21CRAtoWRFOBd+B4bMhOpTDc46DjBOUyt2LJUEntj VUCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=NbwClYHcGl2iVLBaur5Np7VVD3WQVd/3TT4LvjP/DLQ=; b=W2UgM0mOpumGJ4vhLSUBuv/+vkCxKUkxXpbr+dw9zGPY3v5N/Bx6uPfMJCumYAk/mV ee9x8xq9wvkDv02LgIcTFWKA7JOScC6wkJYO1l/4qe7JQqkCUOE2WnBls2thqZ9apFIb qr0jAbY65LQHIuavK+pRpmdHTdLZqwDdivF7bOtCB9eYVFjo7W3fTyDDLEYM8uuC0ADR X/GThK/QJcq8JfcCvw6G003XERXyfLf2PtSnzE2gXe9Nbdp21pcx5cm4bII+muLaNmQe VdlL1OokEH67yZ/TSKk6qOAoFaMxWu9tqJdAJwJj7dnlLC3l5IQc4zq1RFMiVruR6LAH Pcdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ZHu7J3na; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v4si12466527pgt.83.2018.03.07.23.02.29; Wed, 07 Mar 2018 23:02:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ZHu7J3na; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934873AbeCHE5M (ORCPT + 28 others); Wed, 7 Mar 2018 23:57:12 -0500 Received: from mail-bn3nam01on0102.outbound.protection.outlook.com ([104.47.33.102]:13054 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755212AbeCHE5I (ORCPT ); Wed, 7 Mar 2018 23:57:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NbwClYHcGl2iVLBaur5Np7VVD3WQVd/3TT4LvjP/DLQ=; b=ZHu7J3najXAYEWNjxKpZEmVwnWVq4A2IasoQ+k9snf8etI5E2gY/PQNTP8G5YbRKpP/P8w0Ym1aMc2OdR/mFZznjSUdjxhR+aq0UljVYd90k/W0020loTzyPLOtRlei7AvWwOgn0alOvaf9+vgQI0957G1Nq7o4M7ikr6S4kl6E= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1079.namprd21.prod.outlook.com (52.132.130.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.3; Thu, 8 Mar 2018 04:57:04 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0588.008; Thu, 8 Mar 2018 04:57:04 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Jerome Brunet , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 36/78] net: phy: meson-gxl: check phy_write return value Thread-Topic: [PATCH AUTOSEL for 4.15 36/78] net: phy: meson-gxl: check phy_write return value Thread-Index: AQHTtpnKj1bzUDm9ckao0zJwpMWJ8A== Date: Thu, 8 Mar 2018 04:56:17 +0000 Message-ID: <20180308045525.7662-36-alexander.levin@microsoft.com> References: <20180308045525.7662-1-alexander.levin@microsoft.com> In-Reply-To: <20180308045525.7662-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1079; 7:LDmgMeLCNkdCeIxdXzUEhFU9B0JiKQGeKgzFS2WdqjdZXOE/mGqCpjz+Ca0/MNOI6fQZAR2j8F7mJDrjo7IxBT6HqB6Y7/3OUnjICUCXtFWjbZfmmzUXl5H6L44oxXG/qjBzdfCbmi/ljn/2LVw4+BkLiwFcfOBtuHuxmsJfVO2vlVU4O5sVrqG1F4QPRgr3+0aqQoFjgYVGycEotgqGO4nv8metKAn84y2oXGWDVgsUY+2wXkjZ6mVoG92+p2Cf; 20:Crwx0ZDTHXaF1XSbIs4HGyBeMzSJ1Da26mE1FCyQbPjg04xzy/PY1LIKN0cELWq8XWCzNlb9nDzdW3qohEp2FDs3SsNRApQwHIFERwQXeyhOPymFg/4LYw94X86FZJQ1zPc+zB343SOalb4HDojOR1qkOCzatbSXi9aHBaEPc6I= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f39dd92f-7ccd-45a8-3ab8-08d584b1094f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1079; x-ms-traffictypediagnostic: DM5PR2101MB1079: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DM5PR2101MB1079; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1079; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39860400002)(39380400002)(396003)(346002)(366004)(189003)(199004)(36756003)(107886003)(4326008)(97736004)(2906002)(2950100002)(1076002)(6666003)(105586002)(7736002)(186003)(3660700001)(5660300001)(106356001)(305945005)(6512007)(3280700002)(25786009)(14454004)(575784001)(86362001)(86612001)(81156014)(10090500001)(76176011)(26005)(99286004)(66066001)(102836004)(110136005)(81166006)(72206003)(54906003)(5250100002)(478600001)(59450400001)(10290500003)(6116002)(2501003)(8936002)(68736007)(53936002)(6506007)(6486002)(8676002)(6436002)(3846002)(22452003)(316002)(2900100001)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1079; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: trZsldvG004wsoXW1HQmlt9JxJLkm4aABWXE6eV5T/Ew7GUb9jfomcEBS+s74eVy+XVRDZZJgj4z6SRday5+mnNEfcVFFd40hma/b5WvbaaLPS2i6Wy/Zga5A2dWxYZ3UefSPv6PHSJ1K85yGexje+HGKhvUPGM/fKT41lGdGdQxXPoO9D2Wvqwr6k5DjlqQh6lGmxaY/QUY+MAiyLvoNNeqQ0cZqaqx9BbaSBNAMD7XoJjQ/fM4zgzqfzmJ6yPgX32sYy4KZfopjKbmc30WMUaGzgwi2kuQtHcBcLA5UaJqotnzUZ6hqkMHSSNh6L64emK63HSrY7d2AR0YW+8E0A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f39dd92f-7ccd-45a8-3ab8-08d584b1094f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 04:56:17.3480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1079 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jerome Brunet [ Upstream commit 9042b46eda33ef5db3cdfc9e12b3c8cabb196141 ] Always check phy_write return values. Better to be safe than sorry Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/meson-gxl.c | 50 ++++++++++++++++++++++++++++++++++----------- 1 file changed, 38 insertions(+), 12 deletions(-) -- 2.14.1 diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 842eb871a6e3..f431c83ba0b5 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -26,27 +26,53 @@ static int meson_gxl_config_init(struct phy_device *phydev) { + int ret; + /* Enable Analog and DSP register Bank access by */ - phy_write(phydev, 0x14, 0x0000); - phy_write(phydev, 0x14, 0x0400); - phy_write(phydev, 0x14, 0x0000); - phy_write(phydev, 0x14, 0x0400); + ret = phy_write(phydev, 0x14, 0x0000); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0400); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0000); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x0400); + if (ret) + return ret; /* Write Analog register 23 */ - phy_write(phydev, 0x17, 0x8E0D); - phy_write(phydev, 0x14, 0x4417); + ret = phy_write(phydev, 0x17, 0x8E0D); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x4417); + if (ret) + return ret; /* Enable fractional PLL */ - phy_write(phydev, 0x17, 0x0005); - phy_write(phydev, 0x14, 0x5C1B); + ret = phy_write(phydev, 0x17, 0x0005); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1B); + if (ret) + return ret; /* Program fraction FR_PLL_DIV1 */ - phy_write(phydev, 0x17, 0x029A); - phy_write(phydev, 0x14, 0x5C1D); + ret = phy_write(phydev, 0x17, 0x029A); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1D); + if (ret) + return ret; /* Program fraction FR_PLL_DIV1 */ - phy_write(phydev, 0x17, 0xAAAA); - phy_write(phydev, 0x14, 0x5C1C); + ret = phy_write(phydev, 0x17, 0xAAAA); + if (ret) + return ret; + ret = phy_write(phydev, 0x14, 0x5C1C); + if (ret) + return ret; return 0; }