From patchwork Sat Mar 3 22:26:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130588 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1153357lja; Sat, 3 Mar 2018 16:11:14 -0800 (PST) X-Google-Smtp-Source: AG47ELucRACdR7YnJGM67YZllqIXUTpKMoMzE8sLgaw3kHTFqixMb98MbeQB/Y4+RGkoGpl2EleW X-Received: by 2002:a17:902:6589:: with SMTP id c9-v6mr8917390plk.51.1520122273876; Sat, 03 Mar 2018 16:11:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520122273; cv=none; d=google.com; s=arc-20160816; b=nQbyhQ8XfKhgCtVtj1QZbKT6EgQf2NSP3rPCTVEeNmsYd8ZbuRJ2vwB1lBcX7zHIEo VvODxSr+fF4C9FjrdQ9M35yHR80sM4C54sCGzlJm/gYJB239fUQMcSObK7agdCePNtaP /arXWzoskRyvnMr4a476TzrIID1ZshBxSEW1TvHaJOZB2dpwJb4xdqBNb2GUviNWUIqq JPEhcoMBzMe/6+It1XPtSuyZ/MfXpbz7g+XQGRAdH0cFk/IMFTjmUgQSY3VPtIw4Zgvh GAtzy0S1slUVpqjpT9SSc9q3ulTbwJaMpiWwb1/a9E/zqZ6Ii/dMIeA8zpgvfG6iWVt7 Tgrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=mt4nG4sUT74HEaxl3b8c5FbOEu3tjr70KGyumiXEEoU=; b=Db33VfTs8XAwP05nDh1WTHE8rrz46Aen/y0ZSSQ1joLt9CmwCV1EBtkLotr/TBQWrh 0koSHFcowhB/yNA5rbAP8H6GYqHIIfrZIHgzCoom/bdqaY4fzcBD/N8KC+Vj4XbkIH52 BxoKqtieeNltXqa18tL3TjQtYFcU0/bsr1eshj1OP2tFko0QI7nTgZIkWuLQ8me33BGI R67D46bfCdWtxu3C/m9M5HrcPtBX391AeW4QBgPSV6AY0MdpqAGf4X3LMO4NGINRGdm7 r4mfKr0Mu33G9tU2lc7WciFAAclKdAu1FauPvocVo0KJRF6ZCj7Leqoantm/JkfqOZcN xbTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Zi37r9od; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si7456970pff.8.2018.03.03.16.11.13; Sat, 03 Mar 2018 16:11:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Zi37r9od; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933730AbeCDAK4 (ORCPT + 28 others); Sat, 3 Mar 2018 19:10:56 -0500 Received: from mail-sn1nam01on0137.outbound.protection.outlook.com ([104.47.32.137]:51749 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933263AbeCCWa5 (ORCPT ); Sat, 3 Mar 2018 17:30:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mt4nG4sUT74HEaxl3b8c5FbOEu3tjr70KGyumiXEEoU=; b=Zi37r9odbKryEJ8gHank6eo+fIwOfq8wFX8i/9ok4G/8y4XvnwFWJcED4M0d8qTjFzEu4aNU/JAdHjEME+6rlbQs+7Hlgtyiq64Eo+wKMdeS4VQgvQcSCEtmycP1/b+MX1li8O2ak80NVWbu9P9SUH5YvGKWfjJLB0FmjrhePwM= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB0970.namprd21.prod.outlook.com (52.132.146.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.3; Sat, 3 Mar 2018 22:30:54 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:30:54 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Arnd Bergmann , Jason Gunthorpe , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 83/84] IB/mlx5: revisit -Wmaybe-uninitialized warning Thread-Topic: [PATCH AUTOSEL for 4.14 83/84] IB/mlx5: revisit -Wmaybe-uninitialized warning Thread-Index: AQHTsz64dPWHHYQF+UCzdJRp0t5ltQ== Date: Sat, 3 Mar 2018 22:26:48 +0000 Message-ID: <20180303222518.26271-83-alexander.levin@microsoft.com> References: <20180303222518.26271-1-alexander.levin@microsoft.com> In-Reply-To: <20180303222518.26271-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MW2PR2101MB0970; 7:TBv08pD5h1F2H7ptOByN31i7dCzKiW5DlAP9zkZt8JkHYq0ECbauNcFWZjllN8EVfK9669TQ1BAAB4FNUrRYATISp6Dwm3wrLdcA9RQQ7y8Ffvm/9XeARGaj4IIFMk3tiazHL24l65UHxa6oziS3lucVOia/f56UpcJ7ODoKQd/cC7MeLoyGajeyPHjK6+GKvkPvGr4EOk+6JH9bpOgu8AxZdI+B0TDrUwzgbKQqqzqOFoy+ke7IF89ibYXBURjQ x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5a52c0a1-3986-4b74-16b5-08d581566d18 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:MW2PR2101MB0970; x-ms-traffictypediagnostic: MW2PR2101MB0970: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231220)(944501244)(52105095)(6055026)(61426038)(61427038)(6041288)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:MW2PR2101MB0970; BCL:0; PCL:0; RULEID:; SRVR:MW2PR2101MB0970; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39380400002)(366004)(396003)(39860400002)(346002)(199004)(189003)(575784001)(86362001)(110136005)(4326008)(6506007)(14454004)(99286004)(8936002)(1076002)(36756003)(2906002)(102836004)(76176011)(25786009)(6486002)(316002)(478600001)(3280700002)(107886003)(186003)(54906003)(26005)(81166006)(7736002)(8676002)(6512007)(81156014)(305945005)(72206003)(59450400001)(6436002)(53936002)(6116002)(6666003)(86612001)(68736007)(3846002)(2950100002)(3660700001)(10290500003)(22452003)(10090500001)(2900100001)(106356001)(2501003)(66066001)(97736004)(5660300001)(5250100002)(105586002)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:MW2PR2101MB0970; H:MW2PR2101MB1034.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: TiDhZ0qHZmmY4f5Ghf4odr718re+TNv7fFZpI1RXd2NsM59WMHhD6mmrDYJGU18QXrc0ifAZALXI9Yeg/5a/YW1N1WZoTFYK0jPyNDoNyagSberOsWsVHJFZepi7nuFeSVZrtlPCnNKejRMPUib5ZQfX6sH6jsvFL3nma9AxwI8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a52c0a1-3986-4b74-16b5-08d581566d18 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:26:48.9161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0970 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 1b19b95169cd52fe82cd442fec0b279fe25cc838 ] A warning that I thought I had fixed before occasionally comes back in rare randconfig builds (I found 7 instances in the last 100000 builds, originally it was much more frequent): drivers/infiniband/hw/mlx5/mr.c: In function 'mlx5_ib_reg_user_mr': drivers/infiniband/hw/mlx5/mr.c:1229:5: error: 'order' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (order <= mr_cache_max_order(dev)) { ^ drivers/infiniband/hw/mlx5/mr.c:1247:8: error: 'ncont' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/infiniband/hw/mlx5/mr.c:1247:8: error: 'page_shift' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/infiniband/hw/mlx5/mr.c:1260:2: error: 'npages' may be used uninitialized in this function [-Werror=maybe-uninitialized] I've looked at all those findings again and noticed that they are all with CONFIG_INFINIBAND_USER_MEM=n, which means ib_umem_get() returns an error unconditionally and we never initialize or use those variables. This triggers a condition in gcc iff mr_umem_get() is partially but not entirely inlined, which in turn depends on the exact combination of optimization settings. This is a known problem with gcc, with no easy solution in the compiler, so this adds another workaround that should be more reliable than my previous attempt. Returning an error from mlx5_ib_reg_user_mr() earlier means that we can completely bypass the logic that caused the warning, the compiler can now see that the variable is never accessed. Fixes: 14ab8896f5d9 ("IB/mlx5: avoid bogus -Wmaybe-uninitialized warning") Signed-off-by: Arnd Bergmann Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/mr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.14.1 diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 37bbc543847a..2520320845ee 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c @@ -1206,6 +1206,9 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, int err; bool use_umr = true; + if (!IS_ENABLED(CONFIG_INFINIBAND_USER_MEM)) + return ERR_PTR(-EINVAL); + mlx5_ib_dbg(dev, "start 0x%llx, virt_addr 0x%llx, length 0x%llx, access_flags 0x%x\n", start, virt_addr, length, access_flags);