From patchwork Tue Feb 20 11:54:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 128876 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp4553537ljc; Tue, 20 Feb 2018 03:58:21 -0800 (PST) X-Google-Smtp-Source: AH8x2253wblqPKSWPEYvz2+0m6VpsnlLHovSP+pK4FUfdOECZd1egVc9PHGChkG8jhY+3I9UGPjl X-Received: by 10.98.73.4 with SMTP id w4mr12977490pfa.227.1519127901697; Tue, 20 Feb 2018 03:58:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519127901; cv=none; d=google.com; s=arc-20160816; b=R9oAw3BLUbHzC+6cO+MOEH6q7WV5k1t2urfNlCRsNfLKiqfkL0JPD1TYifCFJ2mNPu 7G9MUd3J0UmkpoqtWciKWH/VPQwVsQ8WXkPTlKr7JrVjzF/0c0k90+JxmKIRvXxiVwfJ T0oqdNyehQdk4UIGBCZ3OoMym3YYyD/EYNl2TxueONw+qb25kAe61iTwNOsyQeqpaV9M NuiNreFcWq+JLpJ1yNkc2wi5Yt0Fin+oh9k2WEOMHPcGkomENjkQ/6a2dEOPjyUZl3Fp bIbHJScP45x5LYEKZ1i9JQ+3MiTtiJMiMQlUPRogjcwf/UCGQTrgcE2VhgBz+yOLzhlU x+uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=STSrsdSZmoUlUAqVwDcFIBAqos3dA4rp7T4aA2+T7O4=; b=JYq36YU4skKIAXyV0TljRfLnTzPCMwWEL4ZnOkr4gOLMUOHYsg7xCvEHt1kR/XTz17 JhVullwud8f5HKrsVu4c/8W8TzQi9FpIxc1F/dbbBlci9/GLz7HcsK4ucPvaWKqs6f6y Ng1rqNX9k6VLQDskAdf84BXY8EnGVY1kVOvh6GLFlGiIWlGHhAMN636atqFsHPGG9df5 HVuL71FGAhpm2Uyk0z0S9cIoWLGNR/RxbQVyNPUaC8vTM2iztFKi9t/4xGnd0+8XeN5u gUTWe7EEigUjKwVlffCS8BDiZpd7AkH+cplCpyv5Kp04E99iPH5fO0RYTRyoQrLMuyhC LQMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h132si2645311pfe.12.2018.02.20.03.58.21; Tue, 20 Feb 2018 03:58:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbeBTL6S (ORCPT + 28 others); Tue, 20 Feb 2018 06:58:18 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:56953 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbeBTL6O (ORCPT ); Tue, 20 Feb 2018 06:58:14 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lwqt6-1ehkrK1CO0-016S9F; Tue, 20 Feb 2018 12:58:10 +0100 From: Arnd Bergmann To: stable@vger.kernel.org Cc: Greg KH , linux-kernel@vger.kernel.org, Arnd Bergmann , Felipe Balbi , linux-usb@vger.kernel.org Subject: [4.4-stable 07/22] usb: phy: msm add regulator dependency Date: Tue, 20 Feb 2018 12:54:54 +0100 Message-Id: <20180220115527.1806578-8-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180220115527.1806578-1-arnd@arndb.de> References: <20180220115527.1806578-1-arnd@arndb.de> X-Provags-ID: V03:K0:miWI7lIqEySruyoPC5QOab508UIXOc5C36Aq6xCvquT+69B4jFs ouZeQIm9pKPio9VfFNJM1U9WfJLi3N1vvgrWS2Hm4GB58HzlQtXMkZV+poCvoL/9ehpJz0m B/D81jGIE51ws9joOcFJjJZd2STkb7f0qaz1EiOuOT3+uimFSI2dsWqTeEcj1sxzuKPZr7N D5A+VuLiSXc4nGuVO5RYg== X-UI-Out-Filterresults: notjunk:1; V01:K0:7m2px9/9L0M=:VObOA2bj8KFL4+s/3LQghN S6YdxPk8dshAE5IA6joO70VrSv7tLOhs8R9KsHpkOe/FzOl1CUIjHr4m/3wwf/VW2XUUJuDK7 4nONGhH+kChAUi42QExqmSWWCsE+cM+LUmkaEyC+f7xmrsi9YB+mrh/tNiKk5h+hoNyfFrXSw ljKLegdFWhxqu2vK7TYV+s72N+8fi+FaZ8uAI61tCWsSXI7TV59ER5XkFMmLLRB8KH05hcapD 9EGq+Qfko9krvgc7MetpqDkjVPs1/MjK2mv1DNgrgf+7NCt7bbS3qIig6sANr4e958B0DpCHG 34NE6LYI4ClLsYFqiASjCRmxOyKrzb0LJr24WV9P4fWGsebM9KWFeCZ9SbI00+edWP+/g/3GS u0wkcM6Ko8uf5uADMGkKGlC03L7CzWXRJRJiY0oC1+S0Ag/Nhr0ejs57DZZpTWZr515r2HsoO lQQjcjZTFPgiheevLw0o4XdNsEEXh5cVhJwzqq0LQ79je4v0CnDyu/nhqH70zpzJLM2mh6Ga5 yi/mAu8t64h3D9gNPjGo4mzQuugQcWkCIdk/Lq1aSXo7r33bokE95kiaXnAqQYsa3zQxUvA6f S53FFVwQYA3vHbyomvrME+e6pLVSCbn1Fj23s7NrZyjYxMRK7ggX590IK6cJFxNsUmG7hEg4U iuvKZsqgWdSe7ekUaW+GIhkG4Nt7CfsK/sbmJIUJelrvd3q27AacrLkQqFg/f9lFOT2Umt8VL I25YNTjJISG39461qkgW//Z2fBDsiLjpMGT0+A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On linux-4.4 and linux-4.9 we get a warning about an array that is never initialized when CONFIG_REGULATOR is disabled: drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_probe': drivers/usb/phy/phy-msm-usb.c:1911:14: error: 'regs[0].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->vddcx = regs[0].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ drivers/usb/phy/phy-msm-usb.c:1912:14: error: 'regs[1].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->v3p3 = regs[1].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ drivers/usb/phy/phy-msm-usb.c:1913:14: error: 'regs[2].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->v1p8 = regs[2].consumer; This adds a Kconfig dependency for it. In newer kernels, the driver no longer exists, so this is only needed for stable kernels. Signed-off-by: Arnd Bergmann --- drivers/usb/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 22e8ecb6bfbd..7a72bef35acf 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -140,6 +140,7 @@ config USB_MSM_OTG tristate "Qualcomm on-chip USB OTG controller support" depends on (USB || USB_GADGET) && (ARCH_QCOM || COMPILE_TEST) depends on RESET_CONTROLLER + depends on REGULATOR depends on EXTCON select USB_PHY help