From patchwork Mon Feb 19 10:13:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 128791 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp3330930ljc; Mon, 19 Feb 2018 02:15:23 -0800 (PST) X-Google-Smtp-Source: AH8x226PSKGsI+1GQLUt6rsjUHupRx9Gy5gFgNmuznE4QP2wMs+Ewam9Xw8GLKqc309BKKZ3Ujkk X-Received: by 10.98.204.69 with SMTP id a66mr6887662pfg.33.1519035323530; Mon, 19 Feb 2018 02:15:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519035323; cv=none; d=google.com; s=arc-20160816; b=Wgp/QSkEydMP/G+yLQMXt9z/1EVDs7JCOefHHKfyW752Aazn44ztKsoHk8sXUpTh30 AeeyWxdN0LCUAfl+q9Krvdr9dJCRTUF5aqc1MOSsC6kisX37Uov7El6/IUFMd1RmXDqF b5jcJMmz6qiclHiNMbKFik06OLkiBhTiylb33XXPogmVJS2RKJG8MRPyRIvZcgaEi0GS llkhJaG1CmtHgUgFM4q/q8KeuZM/hFzTpSli9Hl9eQNeEk5SEX/N7GY11yQK6MUA1Q0y xz1XTUHCrVIqnWWsM3tbGAs6eOyiLToPJtZAZMr3gWhVnuGcOa3Y/dByOILGWJq0wL7u UgMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=MbZBj/uXVsw5CuRAPUWEux18gYWqwLTcdZIbHBCThvU=; b=imB73cSELOML3o5ekuoHZ4huu6yjDAlWugvl5ttuv4FaF7oQ3gAUOSjQ0Zj6GO0bQP o5TC/E77+ILi46Ei2Q5RuY3u+mrTPZZnzbgQ+1bk3z8jjlL3yQgQplJpPB7y8S0TUI1C DtW8slSmBUq3cFREf7TEFulLOmZBODT8exxzu/FXXhlzt0usAK7V38aYBpQTIWIOupK2 5XufEprtwVDJHtfmWM5MxbyLO8xrW+x0fsJsFEmgHPxB9y9fnoimZ5jzQZ2wZ6VNvKrh 5j3hXlxtewL5m6xZjMeCAllHft6BZUFlWx+3YTfyZyGIKANIdYm1ibK3qYHDF02rvhVs rrYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11si5991098pfi.35.2018.02.19.02.15.23; Mon, 19 Feb 2018 02:15:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbeBSKPS (ORCPT + 28 others); Mon, 19 Feb 2018 05:15:18 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:42061 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbeBSKPQ (ORCPT ); Mon, 19 Feb 2018 05:15:16 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MY0TD-1fJONE3P4p-00WnvN; Mon, 19 Feb 2018 11:15:11 +0100 From: Arnd Bergmann To: stable@vger.kernel.org Cc: Greg KH , linux-kernel@vger.kernel.org, Arnd Bergmann , Felipe Balbi , linux-usb@vger.kernel.org Subject: [4.9-stable 8/9] usb: phy: msm add regulator dependency Date: Mon, 19 Feb 2018 11:13:27 +0100 Message-Id: <20180219101343.2922561-9-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180219101343.2922561-1-arnd@arndb.de> References: <20180219101343.2922561-1-arnd@arndb.de> X-Provags-ID: V03:K0:iigpTvVPK3Wr0NV/L8CQi7004USg8TJWd8yIZB55rZVkogSbbod z83GZwKgvYj5Xf+9Mmfny9nJjIatOf4TWUCi9juRFJRAoc9Fa49ne4lqPsorJ+SYOb+cMzM gKRnsXTw8WNsrWWBjhrwgqhz5mEJl1o9Ez0IGzk8C/mYAEtQrttLrGRwRzKlk+ErMdio1zq AOLRFkb2fwaofH63nb4tA== X-UI-Out-Filterresults: notjunk:1; V01:K0:R0ygRDGouG4=:LN4tgf61Hu6kTa/xPpqowI J0K9oesN311D1kPp+0pFlF5/ZizNj9v9pWe9eJBVTq/t6uAKMkoygbf2Q9A3jm2lDDrejfZFv 3IKg1V3IAHKNcIYE7OzBvDJmbGX1dCQV8pAVo9X1RXGSr1J2LV/kCaPFaHIwZuQM8Af0xw+tC Gq+edbm2JifEuOYuTui0qxc9j2dbwWRo2mUW5wnyi2NOmqSObgb4Loqdc8HpjSugYFpyyqgJ1 jWuaL1vAx445GFaKK44dqt1iFDd0GY3VogZz4HYUQf6k4hno2gvWnApIhS7lws9PyZHf0Pj5S wg7gRcYWsFO8WjXWEmqQftswsk+2Oov8HjzGx8qBXKKNjY+jhH8l19IAPNZldSzCL0YSHQKaO VGI7HQW3/EKMuTgDqPHMfqXZFqJMu5sjZEGNB7/ox/g70JPYuqf4kHUXFB5aFBNzy3AtE9tKQ PZjSqqIdziiglE/q0PbcfwspQZPfO3wpx7j3MHnlhKngjD+R3+jzoGFp4sM6F6NiokMnwq4w3 B8/nqRpySsoUBfBEVL/i4BkJyq/8ENK1Bh2IYi0uOnyAjvVwABLqc9Vm5FFFToTcDnYVYlpFk k/ykGcicTyvQRsQoK6uIttY/I7HlqxjD4J2+6daoGLveaMt0122HmI3zDg7u9721kf4IHrPt8 nzIIo7alsHqPL9OFqTYX+hqRlWPbVKhbrJDbu/6xwMkxQ1ZO4k/0/qiWiW7pGLavp1cj6kMFU /AlcyZ50soTNBOyAmwE72tVFy551CNeHpEy8pQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On linux-4.4 and linux-4.9 we get a warning about an array that is never initialized when CONFIG_REGULATOR is disabled: drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_probe': drivers/usb/phy/phy-msm-usb.c:1911:14: error: 'regs[0].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->vddcx = regs[0].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ drivers/usb/phy/phy-msm-usb.c:1912:14: error: 'regs[1].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->v3p3 = regs[1].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ drivers/usb/phy/phy-msm-usb.c:1913:14: error: 'regs[2].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->v1p8 = regs[2].consumer; This adds a Kconfig dependency for it. In newer kernels, the driver no longer exists, so this is only needed for stable kernels. Signed-off-by: Arnd Bergmann --- drivers/usb/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index b9c409a18faa..125cea1c3c8d 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -147,6 +147,7 @@ config USB_MSM_OTG depends on (USB || USB_GADGET) && (ARCH_QCOM || COMPILE_TEST) depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y' depends on RESET_CONTROLLER + depends on REGULATOR depends on EXTCON select USB_PHY help