From patchwork Wed Jan 24 09:57:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gaurav jindal X-Patchwork-Id: 125630 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp305428ljf; Wed, 24 Jan 2018 01:57:24 -0800 (PST) X-Google-Smtp-Source: AH8x226eNXOV2Gqip7Qc6VunF9qesWbaYDEecADZiYjx1Wy/2FHjbjck4N84kncJ4Ml0uhMi5fzr X-Received: by 10.98.130.142 with SMTP id w136mr10282691pfd.236.1516787844230; Wed, 24 Jan 2018 01:57:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516787844; cv=none; d=google.com; s=arc-20160816; b=gjdHAvjlLQhriBc9IJv+EKpFaQwrenZlMJCrjiMduR1mKv3aYNTdMTNfZcbMWqHXja l8xTkCSValUOoTDSLK0wW/n7FmobhUzquRpeuST3zT/AsbfKcNgGsaT6mx7+GPuKm4MX dLECVr0HZ/VVutGv3bC+GG5dacGFDdAhol6/rQs2YKyaA7kBTJeAwzkWBNfEUGPT8dRC 1k1nKOFgaS9u8X8/k24sFMuLSYyoRU5oS8xT7cy0WqkJlIuF5FMNpDR1rNw1kjjCX5o+ jT4WvAXPkIFGjTvrFThCS4Ajd1NeicVAp5jR+DvdQsiGnbrzmCogPOXg+lTzhXHyZ8xX kN9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=AL641IAHhq8Li6o94GQZKQ8yO2lrtLhv37jr/E9QH/8=; b=hO+aLQ5rolo4Poxthg9bf0/tXF+EFkfHZwkkXhX+BqsfRneGwADfMsbeytvBWt60+2 T6l41ctURFyINR0iHCEV1oGwTakVx2mUGiFaj+pOUjUfIITYcpG/P0ZriUV3zuP21Q8Q hVIifEDZzwL1/lAXjrdInB21Jt6fTou0TFhI1DWp++Hp3+BwNaQO6mekS7Gwmo5KYZ9l Vc4iRLRbfKH6NYlD7NcUZEwd/+QP4TK1DCFuI3OpfYfTO7DO3x8LzZFmhsA/LoFyJnXT s18UuQ1bUMYJARX5ZVYG/oqgFrsyT0p+6x08B+73kztYbpmRqj3ohG/OyFmvgYuwpfXM RpWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q0pKzEqo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v69si15745642pgb.303.2018.01.24.01.57.23; Wed, 24 Jan 2018 01:57:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q0pKzEqo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933059AbeAXJ5V (ORCPT + 28 others); Wed, 24 Jan 2018 04:57:21 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37624 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932696AbeAXJ5T (ORCPT ); Wed, 24 Jan 2018 04:57:19 -0500 Received: by mail-pf0-f194.google.com with SMTP id p1so2646436pfh.4 for ; Wed, 24 Jan 2018 01:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=AL641IAHhq8Li6o94GQZKQ8yO2lrtLhv37jr/E9QH/8=; b=Q0pKzEqobTMw2GbiNgGLHlNnf3RKMZTd06b25tGILqAxMZOXoFpE0AVAmE1/U0kplD NWm1jsiYF80ha7PgiQR2EWgAyVH+kVqsIyoX41EZDQt2iu9fTWofeqh/d8oePKDr0pUX 9LQcmELav3kXM+4G8t1I9RY3+pN61tw+0xLfda7MxObNncY0UxRklrfajbt4PzCEXvO6 KBpCUXWVFlZ07HwM8fphoC4aCY/7/ISy+NKUpqzgOzMFHvVmYljiGnUTc6V3d0x60nTt yL5bWlsgAD13bOQglo2iF4R/L0QbLMl1aFj4gYui0RfgCl5GD1xnxc54wrzOYsyZcFYt m5bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=AL641IAHhq8Li6o94GQZKQ8yO2lrtLhv37jr/E9QH/8=; b=iRFnia8ixBQTpxSJyZIzLqXYy8h6m7aca8MZGzJdNb7C/jvTVlP1/hpgM2yMtz0LH4 g9XJJsYl+qumlg2J8PHsn75GJQe2mLABxNt0DMFwDQpA/1En8UXVuiRx8sr+kLkg8rho QvTfnkzcoS+Vd7u5PSFyIfLrcEvzcr5a3+rbBFV/14omT1PbZuXBbMr74Xcc1Y+oNzRC SnJYa+KlDbI5P2n+JDP2FPv1o/5bcjDhdrg2R5Goq2JIl9LyUMEwKhqk/mJa3WdD0kam UnyAPpVkdsQPfQmps/EEyt3mEgSwrABOQRWZUMf5kTzK+E04EC+lTyyE9itRU8EOZMxf lhsQ== X-Gm-Message-State: AKwxytcbRPDPHbxStimBMotGtdlxsLgi5AHxAyNB9ZPX4E9hkp+A6f0t Cmpj1RmJ8uS6IDNqv7H6pw8CEg== X-Received: by 10.99.182.12 with SMTP id j12mr10913544pgf.113.1516787838516; Wed, 24 Jan 2018 01:57:18 -0800 (PST) Received: from localhost ([182.73.133.58]) by smtp.gmail.com with ESMTPSA id r13sm31531226pgt.27.2018.01.24.01.57.17 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 24 Jan 2018 01:57:18 -0800 (PST) Date: Wed, 24 Jan 2018 15:27:14 +0530 From: gaurav jindal To: peterz@infradead.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH]sched: completion: use bool in try_wait_for_completion Message-ID: <20180124095714.GB20693@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use bool in place of int in the function try_wait_for_completion. Signed-off-by: Gaurav Jindal diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index 0926aef..3e15e8d 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c @@ -283,7 +283,7 @@ int __sched wait_for_completion_killable(struct completion *x) bool try_wait_for_completion(struct completion *x) { unsigned long flags; - int ret = 1; + bool ret = true; /* * Since x->done will need to be locked only @@ -292,11 +292,11 @@ bool try_wait_for_completion(struct completion *x) * return early in the blocking case. */ if (!READ_ONCE(x->done)) - return 0; + return false; spin_lock_irqsave(&x->wait.lock, flags); if (!x->done) - ret = 0; + ret = false; else if (x->done != UINT_MAX) x->done--; spin_unlock_irqrestore(&x->wait.lock, flags);