From patchwork Thu Jan 18 18:45:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 125009 Delivered-To: patch@linaro.org Received: by 10.46.64.27 with SMTP id n27csp247659lja; Thu, 18 Jan 2018 10:47:07 -0800 (PST) X-Google-Smtp-Source: ACJfBou8vu1OynivlLXf6h/FyA9g5JwIHb39biLhMEapTE81d6WUcZNZ4GgSNtKg63kjYC/zhqud X-Received: by 10.99.149.67 with SMTP id t3mr5718491pgn.411.1516301227507; Thu, 18 Jan 2018 10:47:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516301227; cv=none; d=google.com; s=arc-20160816; b=ECVh9dRdbqQi0A6Z/qk49ZnLXoCMHfZAxBv07DwNKL3mgijKyLjcRRVj9DFNhl+xD4 jFCWt6K7eGOePqkgNLxmCMpUrHlj5VbiE923mLaEX8/ahrsPsyVWYU/mzqV1ApGjM3FM PuHTIcKyw07u7tOEi7XQggWJTOcscAv+gC1UQXnSfFyYNp+2mVy4BoXt2JDDeN/LhU7J eyI7RB2RXcHVqnL8khjT//FuHbp5Akotkd5MEncpv++hBYEfyqHb8e2KP/kj8btKeh9L 2xk2ZxdU0L/KzNCvIY+xeMHpNxc60Nguvs9zNeVqYitYA8GWgvDYR8qnIWShgN2rzpnw PMKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=+XIrCgDt5NBe08Q927BYRS4towZAMgpTkx6cXoR4EhI=; b=od8S58jFD3n/bcJeXi66eBKjOZFdEmFNRzQ1b9Zqc7IFdHFzvkAqySC1hSUoQDxKNG Z0EqMBMqZJBOf89yEspNBWkBYCAGf5jRu/hrzGObsuYpz9b1HqA9wx4KLBktZPPC/AuM zOo6JxNwilfqWfWxbuMm3Ol55RlcqZswn147RJ/r2o1XB3ayJxtn2eImJSOqSa8UFRVM yueE8N4BMZx4IMsFW6pfCb9vseS30oSeugiQ3vo1tEF1aB0AW6d5rWvD27urDrLlp0dO 8K2qrouCdhEBNB4veeanYlC4zzlp+AhQ3g+5JwkKowhn6ywc0ddX8zy3NxZQqCJ15m7M xobA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=qXG1kbzO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10si6665263pgc.192.2018.01.18.10.47.07; Thu, 18 Jan 2018 10:47:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=qXG1kbzO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932537AbeARSrG (ORCPT + 28 others); Thu, 18 Jan 2018 13:47:06 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:40484 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755003AbeARSpk (ORCPT ); Thu, 18 Jan 2018 13:45:40 -0500 Received: by mail-wm0-f68.google.com with SMTP id v123so24983589wmd.5 for ; Thu, 18 Jan 2018 10:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+XIrCgDt5NBe08Q927BYRS4towZAMgpTkx6cXoR4EhI=; b=qXG1kbzOal5r+PxBXz2LwlbpFPBhILf/LkcGK+9vDkI1usqejM0jhIKSWtD7jkEnIR z7O3zdHPTpgEM8pZ82PNz0hjzaK9X0yKm21i8LhXZ2/JSmJIINt5ltWu9+k7Y2Vni6Hx KloSG365KMUlnnZpE7HIRordpHaQyrOvN89enwmw/L4z77q8KKcL6UnEMsgzOamfs+Ur IYbKtuMXokEWEQnhRYvpEymzchtJ8BuZ7na3jJI6Ru+9UlSkXvBByLgmBK4XQ11133Y0 BrcCyAG4gTIS9mbdHy6VnJt/g6eWb9VB5WAmJOt5PEOBgZY+5V7UPOSZ9/KnYWDHk48T X4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+XIrCgDt5NBe08Q927BYRS4towZAMgpTkx6cXoR4EhI=; b=GX1mvuXPhmxRDcDEbqXP5oqz5hSVlaRNA3E7Kj+RWbpCJuu+MKiVEXd7nZFCf+oe3N qq7hlNLqHKYCIYrnZCjmmE8phwUInZRZvxleCuN8zcUNQsaUSRcicfIRQs+cabkDVra3 vQGfTHUEo8vf7awrhW5dchTEC9qUUfmhZ8DnEiFyfPhBdWB2/mDF1b1fYf4aDBUbQ8QF XtFwO71SuwcZFviJzkOCaFi7nI/FCgoSrisx/zorddOJhn6WBRjzpUep/Pbr4dS1RxrG JYtMaG1uuMZZJCj81MhCm42odzkAA6lKliSNd9UJvQdpIOYf3sjDXhkQl0Jig0QPl30E nhdw== X-Gm-Message-State: AKwxytfz0JriniGlx71Gag1v55PcpRmkcdz4CPDi1JiVC3Sd/SpL5QaE gSCcFs0Ft+8hxhHuiRmTzA2ZL01c X-Received: by 10.28.140.9 with SMTP id o9mr2610060wmd.28.1516301138915; Thu, 18 Jan 2018 10:45:38 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id y62sm6240236wrb.48.2018.01.18.10.45.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jan 2018 10:45:38 -0800 (PST) From: Jerome Brunet To: Neil Armstrong Cc: Jerome Brunet , Kevin Hilman , Carlo Caione , Michael Turquette , Stephen Boyd , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/9] clk: meson: use frac parameter width instead of a constant Date: Thu, 18 Jan 2018 19:45:27 +0100 Message-Id: <20180118184532.6856-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180118184532.6856-1-jbrunet@baylibre.com> References: <20180118184532.6856-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the fractional part width in the calculation instead of 12, which happens to e the witdh right now. This is safer in case the field width ever change in the future Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3 diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c index fa4cec13d6e8..d9efe725b7ad 100644 --- a/drivers/clk/meson/clk-pll.c +++ b/drivers/clk/meson/clk-pll.c @@ -80,7 +80,7 @@ static unsigned long meson_clk_pll_recalc_rate(struct clk_hw *hw, reg = readl(pll->base + p->reg_off); frac = PARM_GET(p->width, p->shift, reg); - rate += (u64)parent_rate * frac >> 12; + rate += (u64)parent_rate * frac >> p->width; rate *= 2; }