From patchwork Fri Dec 22 20:45:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gaurav jindal X-Patchwork-Id: 122658 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2715670qgn; Fri, 22 Dec 2017 12:45:33 -0800 (PST) X-Google-Smtp-Source: ACJfBosMZwZgAn2g398zTWXJQNDoGSQe3nvECBAPXrmES00cEsbwaZPHI3f4qEvZr5vAzSjlXXxj X-Received: by 10.159.253.149 with SMTP id q21mr15175585pls.195.1513975533412; Fri, 22 Dec 2017 12:45:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513975533; cv=none; d=google.com; s=arc-20160816; b=Se/+RXlDMXUsbdgsBwDFLl665Y07rrK0f8q1OSHn57PCXLMSONquUXQhUlSf7CDBNa o1RhBmkn2eV/pMtgjad0EG56cprxnOSdT9oMbaSA1S9tABe6GTw4IElawnvzRFYzulBs BYPHrB1CBqC6hQ3rpa4eojmpET+dtqsdrBFofBI8qQJr3sz0R0+3JZmAz0U3SOYSSNgw bxMLTXh380F2/Rps2B76cFlN31nsK1F4xb3vsWErsKB0VfXxuFcVu/w2NKKd4+bAehAI jAJazz7eM3O9zlDJySzRL7fe6zsEEt3eeKnsGzud83t2FMXBeVNyaaPqHjzS4oMW4ikz PrCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=WygDanmWDtgJsygABJoOzEFlFURw6K3VYjMtb8WS0q4=; b=NYR0GV04XRCKcZFNRx192Oe010zoamyl4dds8jqwIIfhkWTahBwJyIBsv+etLQmJOt 1LmBqK4MkyukaaAeOyk2+pYexkv95pX2sT21K5kcsT9QRHzMReTsleA60xfDoqzXI2Gl tP5H8+KlBa9O+L4UXBw+7zqfKn3xp0Dm0qtTMI/tKoX1yKmXk3jqEs97wiUnrvAdtsF9 DL0fuxn0j195vdgJfQL+jf04Ps6IWvNoXe+wHb+RrPC8wB2XHNfd+XBGWrA6rK7JBy+3 USfA4JXhEqAE3QQnngyjWuf5vpS3rSvg8wikpJlGebkPB8I4tKt5D0S4mNWSWE0rXNEr geLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IdWQ0KZP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p13si15727960pgn.197.2017.12.22.12.45.33; Fri, 22 Dec 2017 12:45:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IdWQ0KZP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756799AbdLVUp2 (ORCPT + 28 others); Fri, 22 Dec 2017 15:45:28 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:39799 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755941AbdLVUpY (ORCPT ); Fri, 22 Dec 2017 15:45:24 -0500 Received: by mail-pl0-f67.google.com with SMTP id bi12so13515930plb.6 for ; Fri, 22 Dec 2017 12:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=WygDanmWDtgJsygABJoOzEFlFURw6K3VYjMtb8WS0q4=; b=IdWQ0KZPi/j+LJq5iZ65u/iiS6xeDHGpWHBOuJGbDJ31zLd2XTumYNAxBRgawycJLd 9biLTkreaRucumJLyivkxsJjtRf+akAgI3rHWrVER1ROrzlkf5uUCeBFj7Fb9s8v+6vP mTltJoZy+mpt/b7ZpE+g7Imq5sQebWZdynzEIheWJkEhQDzwPT273xFOlwakfo0XUESl VxerHgWKKenHFei8iX1nl2NcYy2o1og+i9M+XrGw11HXom2iWs9mqYD1STSVrEPr/Vd1 aTf3PdxqbmGgis0jdXGr7f4eRY0IwTxqduuxSk8n9y6oq6iRyQIY9+ST6v58g7uaK6jh 79Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=WygDanmWDtgJsygABJoOzEFlFURw6K3VYjMtb8WS0q4=; b=Z5ywcNh9sji7FEMrtDibGdyJbeQiBmsMTCJM4GYTzpJr5ZpmUFJj0RXvmAgduMu8Qp h+C8H5GRX84vqdz5GGDFQdcMiexibYP+eEFfBame+AbbJP8OcMxaoQWOdiJ7kNHDAATG 6UalHxCmeByW6odxNCj6rfP82ynIY/I4QzKDbdafkA+tTA3gbfXuATIW5wd6Okzl5B5J kpHWz3RwTnK6+WB6UyhEzRqdG6hXlQwmCGQ6a8tf5lFxuM9YBy/6JweGyNqsp1wTM617 MMdwBoDbUKenT//2JPQiZnQcZt7dyOox3n8iIl/0nTDmHeXz3z50zcJ6007mnUKiubS+ K6Jw== X-Gm-Message-State: AKGB3mKVs08oHI0WUr00B556wOveY8qONK7hG5kh9ut5MxpDixmLWgpw /1nh04inUh61ig1nSeWOlV0= X-Received: by 10.159.241.9 with SMTP id q9mr15444664plr.190.1513975523670; Fri, 22 Dec 2017 12:45:23 -0800 (PST) Received: from localhost ([171.61.186.94]) by smtp.gmail.com with ESMTPSA id e2sm37918890pgv.34.2017.12.22.12.45.22 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 22 Dec 2017 12:45:22 -0800 (PST) Date: Sat, 23 Dec 2017 02:15:19 +0530 From: gaurav jindal To: peterz@infradead.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH]locking:mutex Print warning if trylock in irq context Message-ID: <20171222204519.GA12047@gaurav.jindal> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since mutex_trylock must not be called from interrupt context, a robustness can be added to this function by throwing a warning if it is called in interrupt context. It would help to make debugging easier in case of undesired calling of this function. Signed-off-by: gaurav jindal diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c index 858a075..fe1cace 100644 --- a/kernel/locking/mutex.c +++ b/kernel/locking/mutex.c @@ -1176,7 +1176,10 @@ void __sched mutex_lock_io(struct mutex *lock) */ int __sched mutex_trylock(struct mutex *lock) { - bool locked = __mutex_trylock(lock); + bool locked; + + WARN_ONCE(in_irq(), "%s wrongly called in irq context", __func__); + locked = __mutex_trylock(lock); if (locked) mutex_acquire(&lock->dep_map, 0, 1, _RET_IP_);