From patchwork Mon Dec 11 23:43:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 121478 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3431039qgn; Mon, 11 Dec 2017 15:45:50 -0800 (PST) X-Google-Smtp-Source: ACJfBovThxv1tJkTeCDkeB2epaFBeciENzr9Qt6yyYy6SLO0IEpzKNvQx1nc6LXg43ak1EZ8jdaC X-Received: by 10.159.230.3 with SMTP id u3mr281194plq.2.1513035950195; Mon, 11 Dec 2017 15:45:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513035950; cv=none; d=google.com; s=arc-20160816; b=UJiuV13N2erfxVc8zIQwFnDvs8Qz+H7/KAYVBArBBbVfNrEafsZc9eUesx6EXllgvJ tj96ImCnqxX7CxJmixvvsCTn470xZLx/3sdhSlbox6Kk1orspyV8CZFjw8HHTLZo470Z Xz0qYNeaQc+hRXhUfJsJDdB9Po19sK1508CW1Ud/NioFWMc+Wwo5Vg6/IbJ7O6ZJ8LAi 9wKw8vscilLCAuQu6PobJ5ji5leyTzsdZYYUjRuawEaT4DwX4CJwK95E7TYeupeoH80N Iyziz8Lp+/Ea3RksAHDbKnyl3axAk0Q7qdcCmFLjvqtJTSR+O6FQIzIE/JgcdjiEdGnH 2RAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=ERc6jD/GqMasHUaMgGiPYtVC+zp11tYtnn8PjLR6U9I=; b=q/NAN5Z2g8UdmDkQtsmFCo6FQ+6TJm7GkYhtv71HUhrDvwkSYTJofA6D4gSFjazS9C 4UyR+Xq8z+A1zyUxp2b2nd+QVNgtndTrsbRk8C9NVwk13VhFjVXnmFLe3/9SUaVE316z Wza7OY7xWpAHSl2nFgep9dr6SprFItGHMzTPX3VELxiHrd6wu4jk8fDdIKcxMxtqn9Du oXHO/VjKq9qWSrij2B1yNaafZ5nnLZOi45XHCG/seNxkbQJTvBBhh2mAZKvzucOH3q3D V28jCFOfVpSOw//obZDe7B4t20DPfCnPZw2qohw9ouioyINIEKiF3T6dJZP4y4hccT2G xy1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZBkOyVtX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si10735824pll.191.2017.12.11.15.45.49; Mon, 11 Dec 2017 15:45:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZBkOyVtX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598AbdLKXps (ORCPT + 19 others); Mon, 11 Dec 2017 18:45:48 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33056 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbdLKXpa (ORCPT ); Mon, 11 Dec 2017 18:45:30 -0500 Received: by mail-wm0-f67.google.com with SMTP id g130so15251369wme.0 for ; Mon, 11 Dec 2017 15:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ERc6jD/GqMasHUaMgGiPYtVC+zp11tYtnn8PjLR6U9I=; b=ZBkOyVtXNJSaf+2RebivlFfHsYw36L+hFP4Rm/Shp3vwXQdLd+QtLDGiYwU0gwDUHV fISIm1J4mdg5i994pTP9pZZQNoR8mfWhJBujof6TXz6Uqts2XhBxrGx1dlAADNXKPGJI gwOJhLAo3HA0xzNjcFd018s23gUzAaIC/fBnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ERc6jD/GqMasHUaMgGiPYtVC+zp11tYtnn8PjLR6U9I=; b=GBC0kER9fMyLREJKKjKScglkEQO4bW4DMhAhp3kViX9VMQd+dCpkDuT97vbfdOQul8 npEGXSdPBepfY/fqmlQ3O2HTktSl68UW4bYG3Grj+ydHFErh1/9arH8599zM7EJQgLS7 AnOh9P7V1e0pgBe8freRhH/obFzjUXE4CQk+7D0LVxYTPemZ3/XWhLoKj2ZdPjaoOGDw XKTR9+uB82c5KRNMEKUJgjQX56ccBXTsWl0GttpxX91dsEgOdZxLyEB5ZrFd8Q7U2sir yhbXCG/V8GqxfhDdEZ5vJBPFsY1X6fXoRE3PjNSQofNgizQR8vEknfPHT3l4i9dePs7V Cpwg== X-Gm-Message-State: AKGB3mKdSnWPhv221wc522oY58zW2kR+gqdCRK3b8jPNvSCqaqNikj3X s5eaTRpSGKjvhseJ+0OPNFJr4Q== X-Received: by 10.28.108.3 with SMTP id h3mr12175wmc.129.1513035929000; Mon, 11 Dec 2017 15:45:29 -0800 (PST) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id k69sm10673615wmg.8.2017.12.11.15.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 11 Dec 2017 15:45:28 -0800 (PST) From: srinivas.kandagatla@linaro.org To: Mark Brown , Greg Kroah-Hartman , alsa-devel@alsa-project.org Cc: sdharia@codeaurora.org, Rob Herring , Mark Rutland , Jonathan Corbet , pombredanne@nexb.com, j.neuschaefer@gmx.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH v10 12/13] slimbus: qcom: Add runtime-pm support using clock-pause Date: Mon, 11 Dec 2017 23:43:06 +0000 Message-Id: <20171211234307.14465-13-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171211234307.14465-1-srinivas.kandagatla@linaro.org> References: <20171211234307.14465-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sagar Dharia Slimbus HW mandates that clock-pause sequence has to be executed before disabling relevant interface and core clocks. Runtime-PM's autosuspend feature is used here to enter/exit low power mode for Qualcomm's Slimbus controller. Autosuspend feature enables driver to avoid changing power-modes too frequently since entering clock-pause is an expensive sequence Signed-off-by: Sagar Dharia Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ctrl.c | 101 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 98 insertions(+), 3 deletions(-) -- 2.15.0 diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index ace85ce3de90..35ad70dbfe3a 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "slimbus.h" /* Manager registers */ @@ -65,6 +66,7 @@ ((l) | ((mt) << 5) | ((mc) << 8) | ((dt) << 15) | ((ad) << 16)) #define SLIM_ROOT_FREQ 24576000 +#define QCOM_SLIM_AUTOSUSPEND 1000 /* MAX message size over control channel */ #define SLIM_MSGQ_BUF_LEN 40 @@ -275,6 +277,30 @@ static irqreturn_t qcom_slim_interrupt(int irq, void *d) return ret; } +static int qcom_clk_pause_wakeup(struct slim_controller *sctrl) +{ + struct qcom_slim_ctrl *ctrl = dev_get_drvdata(sctrl->dev); + + clk_prepare_enable(ctrl->hclk); + clk_prepare_enable(ctrl->rclk); + enable_irq(ctrl->irq); + + writel_relaxed(1, ctrl->base + FRM_WAKEUP); + /* Make sure framer wakeup write goes through before ISR fires */ + mb(); + /* + * HW Workaround: Currently, slave is reporting lost-sync messages + * after SLIMbus comes out of clock pause. + * Transaction with slave fail before slave reports that message + * Give some time for that report to come + * SLIMbus wakes up in clock gear 10 at 24.576MHz. With each superframe + * being 250 usecs, we wait for 5-10 superframes here to ensure + * we get the message + */ + usleep_range(1250, 2500); + return 0; +} + void *slim_alloc_txbuf(struct qcom_slim_ctrl *ctrl, struct slim_msg_txn *txn, struct completion *done) { @@ -511,6 +537,7 @@ static int qcom_slim_probe(struct platform_device *pdev) sctrl->set_laddr = qcom_set_laddr; sctrl->xfer_msg = qcom_xfer_msg; + sctrl->wakeup = qcom_clk_pause_wakeup; ctrl->tx.n = QCOM_TX_MSGS; ctrl->tx.sl_sz = SLIM_MSGQ_BUF_LEN; ctrl->rx.n = QCOM_RX_MSGS; @@ -618,14 +645,81 @@ static int qcom_slim_remove(struct platform_device *pdev) { struct qcom_slim_ctrl *ctrl = platform_get_drvdata(pdev); - disable_irq(ctrl->irq); - clk_disable_unprepare(ctrl->hclk); - clk_disable_unprepare(ctrl->rclk); + pm_runtime_disable(&pdev->dev); slim_unregister_controller(&ctrl->ctrl); destroy_workqueue(ctrl->rxwq); return 0; } +/* + * If PM_RUNTIME is not defined, these 2 functions become helper + * functions to be called from system suspend/resume. + */ +#ifdef CONFIG_PM +static int qcom_slim_runtime_suspend(struct device *device) +{ + struct platform_device *pdev = to_platform_device(device); + struct qcom_slim_ctrl *ctrl = platform_get_drvdata(pdev); + int ret; + + dev_dbg(device, "pm_runtime: suspending...\n"); + ret = slim_ctrl_clk_pause(&ctrl->ctrl, false, SLIM_CLK_UNSPECIFIED); + if (ret) { + dev_err(device, "clk pause not entered:%d", ret); + } else { + disable_irq(ctrl->irq); + clk_disable_unprepare(ctrl->hclk); + clk_disable_unprepare(ctrl->rclk); + } + return ret; +} + +static int qcom_slim_runtime_resume(struct device *device) +{ + struct platform_device *pdev = to_platform_device(device); + struct qcom_slim_ctrl *ctrl = platform_get_drvdata(pdev); + int ret = 0; + + dev_dbg(device, "pm_runtime: resuming...\n"); + ret = slim_ctrl_clk_pause(&ctrl->ctrl, true, 0); + if (ret) + dev_err(device, "clk pause not exited:%d", ret); + return ret; +} +#endif + +#ifdef CONFIG_PM_SLEEP +static int qcom_slim_suspend(struct device *dev) +{ + int ret = 0; + + if (!pm_runtime_enabled(dev) || + (!pm_runtime_suspended(dev))) { + dev_dbg(dev, "system suspend"); + ret = qcom_slim_runtime_suspend(dev); + } + + return ret; +} + +static int qcom_slim_resume(struct device *dev) +{ + if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) { + int ret; + + dev_dbg(dev, "system resume"); + ret = qcom_slim_runtime_resume(dev); + if (!ret) { + pm_runtime_mark_last_busy(dev); + pm_request_autosuspend(dev); + } + return ret; + + } + return 0; +} +#endif /* CONFIG_PM_SLEEP */ + static const struct dev_pm_ops qcom_slim_dev_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(qcom_slim_suspend, qcom_slim_resume) SET_RUNTIME_PM_OPS( @@ -647,6 +741,7 @@ static struct platform_driver qcom_slim_driver = { .driver = { .name = "qcom_slim_ctrl", .of_match_table = qcom_slim_dt_match, + .pm = &qcom_slim_dev_pm_ops, }, }; module_platform_driver(qcom_slim_driver);