From patchwork Mon Dec 11 11:33:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 121372 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2673180qgn; Mon, 11 Dec 2017 03:34:20 -0800 (PST) X-Google-Smtp-Source: ACJfBov15LMALMnvNddOamDBOvl6T/8pya2vcTJY7g4not7wVk16HOUOE1gDK+B/9nm+qJZN+Pb/ X-Received: by 10.84.193.129 with SMTP id f1mr51008pld.363.1512992060310; Mon, 11 Dec 2017 03:34:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512992060; cv=none; d=google.com; s=arc-20160816; b=L7mDbjH41UVj6kREZgq0l5ccQFqtcAfDcgHPceQB40ToJzlm1sdEIa1+bzkzAec7Xz 4zKAYEpcqHHI4IG87GS3rlvTABnsMjgyVHasE5piIYdz4tAfmr+syBCMNeiLcJTM3XwX v/ENnD5XoJFdCD054pgZ46I3iW5Rmo4oQknSS/UyIXijhWlKOj9N4sRLvMBa4Ws73Ia0 NohZjwzeElWUusQIlZ1XcBy0BsOGbnVR3XheN0uPBwTqu/GVd3i5k5n2n7/dPeVXoIPB hJxUyRNnQPOjQ39XGRmbTFp5ywS/cGQtdDSmTOjbYUVZkwfX+HpF00jeIY6nJLAJKnRA PbNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=z2leuDUOgs3WBQPMabYNvTmk74yCfvWBuWY4WRYbdF4=; b=o3ob3LI9gYACnNO44+1JPyAKc+5q1j/N9QAu8qanE55wYtW6djdyF/GLcw6SShX7DR 8CmZUxEXRioYzLwm3aO9c2qRKIzX8lA1yT5j2urEDffYGbmrkdmTL/KCBFnTo6I/o2lm buZaw3taPD6QJgvVbK/SXNJL8ZBFJFQwp3lTcmglD1wwXYdqalNiYDBf5/DBy5bn1DIx TTQWQ4W4ODuJQUXKFcupdDCNzMZ8kcjHrvDgoTFXXxJkajO/+zfFCdJRGITiPTkuyOdG pG03PeYi6tNNW2670/WEB2mAw0FJu8j0uBXObbwxQRyV5J+rJWfILEpynsGjhmrNOfrL vd9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si10732595pfn.123.2017.12.11.03.34.19; Mon, 11 Dec 2017 03:34:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbdLKLeS (ORCPT + 25 others); Mon, 11 Dec 2017 06:34:18 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:49455 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbdLKLeR (ORCPT ); Mon, 11 Dec 2017 06:34:17 -0500 Received: from wuerfel.lan ([149.172.96.106]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0MQwFa-1eTCAo1eWM-00UMbv; Mon, 11 Dec 2017 12:34:00 +0100 From: Arnd Bergmann To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com Cc: Arnd Bergmann , Jens Axboe , Hannes Reinecke , Bart Van Assche , NeilBrown , Mikulas Patocka , Dan Williams , Damien Le Moal , linux-kernel@vger.kernel.org Subject: [PATCH] dm: fix uninitialized variable reference Date: Mon, 11 Dec 2017 12:33:45 +0100 Message-Id: <20171211113358.3599287-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:eanmzdg3vfEiqPyNnb+Jr2Yp713M19J/r6ndQ+tngcloPp7OppW kJgXk0beDDC2sDmNkM0izZKKmGTqMNKXRJTHJKQso6NJ7Rt3piiqONwuFQpbh2/snZK3rHY hPZk48wmdFphw69nM8nUd95ChvBsAobIqcwbSFi4FEGgHc0lATQ70meiRgG7MEM2PwHeJj0 TN5TcKPAImBxHjk5xxtEQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:ba3m0z6L+90=:OF/C6i6182SoHv+JnJBfTl BZyITqB+OPV0NUIlW8FKdkiJGu9DsKdPsfsF0rRS0cTrKIYXHhSpxFLMgRxsqqhdCuAYCxYMg bgbfoq3nR1AWffUosmo/BGsEnrKLWqIqMhcstsRILJKlCJJ8vG2rqz2kCgU2coK2v2HCO73nO NAvhmjU2ZOw8VakjVo4poh5pAvqBHz+7szTd+g4Ca/zVrhrvpsD5YZIcpkxp01Gp9i1u3tsRR p+QSX+p6PxJWjBk+sbJVuY77oBmdnRcQetsyrKSB0So3bD07athymvVmT8mnK8QD09cZAWqi+ bO6I3Cs57gqhaqx/6KHd5QIyIUV2pfekWi1hX/M2ItxoxJo/NlI1El2BgCMAZOvU5O8r4yz66 bDSVMvpzjuJofbZRARBLpgEM9uvSzQoz2CAUYAdiO97UDf3id65p5UjHyT11W6asRgdEtXYQD 6VKAvW4Z3r+OI8ejD9AiC1+HQpFhrJ5ZI5uJsyYIv/HCX3GgL3kaWNGFM7oRNA8jP+LWc+ygc SNk+OcKj91PnQvBP1SSlj//4BAg6u9imeLeRF9hM3E9dNQE0jDMxsB5Hl7Xk+RXmui2IlMYMJ zZ+n6Z22M0uvtkapJA41jjmBMy77sxNwy2SKwDX+CDnNmyii03y/XDpOs3+G8c3wl6iJrhJdM SMTDmFCUOPgcr6oTL17agozTAmPstYoARROxU/FcLbzl3fqL2R0tTdLEUVHgoMkVHgt/Kaa1c o16OeZ0i/+3aq4ksJw+U/Rnx1KkOMMXi5/4JAQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The last bugfix apparently introduced another problem, as shown by this gcc warning: drivers/md/dm.c: In function '__send_changing_extent_only': drivers/md/dm.c:1365:28: error: 'ti' is used uninitialized in this function [-Werror=uninitialized] This restores the intialization of the 'ti' variable. Fixes: aecefd4919de ("dm: fix __send_changing_extent_only() to send first bio and chain remainder") Signed-off-by: Arnd Bergmann --- I did not test this or give the patch much thought, this just seemed to be the most likely fix I could come up with in a short time, so please review carefully, and ignore if the solution is something else. --- drivers/md/dm.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.9.0 diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 05aa9c094352..f19e9787076e 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1356,6 +1356,10 @@ static int __send_changing_extent_only(struct clone_info *ci, unsigned len; unsigned num_bios; + ti = dm_table_find_target(ci->map, ci->sector); + if (!dm_target_is_valid(ti)) + return -EIO; + /* * Even though the device advertised support for this type of * request, that does not mean every target supports it, and