From patchwork Thu Dec 7 15:49:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 121036 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp8654522qgn; Thu, 7 Dec 2017 09:44:50 -0800 (PST) X-Google-Smtp-Source: AGs4zMa9l3f/ImBgm8vUXfOwHxQMWgt3boapQZigi2PI5WYntf9saBPmmnxOBka8pN8G7CjDvVYu X-Received: by 10.101.97.15 with SMTP id z15mr12951895pgu.267.1512668690685; Thu, 07 Dec 2017 09:44:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512668690; cv=none; d=google.com; s=arc-20160816; b=tv8sse3oTbnkOQ6Wd0KAJ2lhSFCaTXhLuUo3aQHX7jffDg1CB94RvTASzLwqLr1LUP kWFnWodmdVzhIIAZOC+/FiaosLuJsIxkl+tQ3r1sXi8BfBCQsq2w424qIC4PQQY6LZgY sM02QPkvNp50Cbtl42tTFpefb2KRhXvDECh4osue5Y61BkOOtbUrNvaEXdCVWUidKlhz yNpr+mIJY66Diby1AYHldrbruHuOCqV6t9VbnW1ZmJWhmcC8YOBT/HKOaki8B0lUYplT d0ykWn64E2dhCCDE8UYN3x82ORxONf0Dr/aC104JKyIjQwxcZEzbCV0fkX4QpxT+nr4M oGHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:cc:from:dkim-signature :dkim-signature:dkim-signature:arc-authentication-results; bh=QE3fhy5kTiGz3OYrFyOHPpnD/OkyFlxMDb97mAJqaBc=; b=me89SCfzygdgdoa2kasVZPYspelaIyrgn3PnRf6jB7aqfDQr9oaSKPeBH9yvNqeAvj xnJBGvB6KVtrTvsq7a7GDC1WHCGqwbFBEyW2a6xSGc7U0lD1RovjVDBAsi6cScOenO9g AEn5QNdPmJ6OwT3U/V7ljL4tPPE8pvgFYBMcg08JSjQ+kkxx8CntmuMW0g8R9l7bpdYJ Pqqq+WOAcffPG8JFl22wWzFWRdmgZNeAqX3+vn0Owqz/AJtNlYLDeMDXkiFeFsK9jLSM q1idXbuD8QkFbGHpXdYpfQHc4b6yDjig+Glei28HErNPDwL2kHkwmldcvbAN4Btcjpt4 CenA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@verizon.com header.s=corp header.b=QRKUFjxx; dkim=fail header.i=@verizon.com header.s=corp header.b=fwfmBYhc; dkim=fail header.i=@verizon.com header.s=corp header.b=JqIsLq4C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f84si2827226pfd.161.2017.12.07.09.44.50; Thu, 07 Dec 2017 09:44:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@verizon.com header.s=corp header.b=QRKUFjxx; dkim=fail header.i=@verizon.com header.s=corp header.b=fwfmBYhc; dkim=fail header.i=@verizon.com header.s=corp header.b=JqIsLq4C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbdLGRoq (ORCPT + 14 others); Thu, 7 Dec 2017 12:44:46 -0500 Received: from fldsmtpe03.verizon.com ([140.108.26.142]:60849 "EHLO fldsmtpe03.verizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756024AbdLGPt1 (ORCPT ); Thu, 7 Dec 2017 10:49:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1512661767; x=1544197767; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=b7oa4n6AGktf2UQ5qBBH8PYQ/rN4UTMFzJYvWNRFzSI=; b=QRKUFjxxqGCPk3Qav3QjEwns2rXNbZg37ARPLacOfl7i1uNuzalXBCEo Qn6gZeOPcvJF3SUWIoBYmbmpbFoBo6HZ7M0Vjp9F/s1zLMr3wi3YzpziN OFf+FTpOaS0N+aM615TTxdw1xyZwL056oqNpZ8oWn4mh+S3wOXT7ed9f1 A=; Received: from unknown (HELO fldsmtpi01.verizon.com) ([166.68.71.143]) by fldsmtpe03.verizon.com with ESMTP; 07 Dec 2017 15:49:23 +0000 Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO apollo.verizonwireless.com) ([10.255.192.101]) by fldsmtpi01.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Dec 2017 15:49:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1512661763; x=1544197763; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=b7oa4n6AGktf2UQ5qBBH8PYQ/rN4UTMFzJYvWNRFzSI=; b=fwfmBYhcv50UhVz3BChaUbTaiW+c/r3N8O3R/8LGaMUooWVwokBNo/w+ nwz+f0LgcZ+lwNGoelqE6bTq8NDhfmhjG84oMGADSiiK1nB+3DjN7YYo2 D46r1W6knYuveF4loWGc2+T3JcKODxDH3T+1xdWdvOrW3pbPVHrvhYCwA M=; Received: from surveyor.tdc.vzwcorp.com (HELO eris.verizonwireless.com) ([10.254.88.83]) by apollo.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Dec 2017 10:49:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1512661754; x=1544197754; h=to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:from:cc; bh=b7oa4n6AGktf2UQ5qBBH8PYQ/rN4UTMFzJYvWNRFzSI=; b=JqIsLq4CUuMwNB1FiVlMFW+IZYUdtk9LaAPhanfPV016XtEJP5T1qWgp hnJJqzO1AXfax/tgwhfengmWVS8wXETpzlSTIrFb0sk/8KcX94PwCq8Dl ulfydf5twRjB/nmMu+CfKM3Jpq4q3QpdLVZaWQdKlnpXtULyuYtoHidSO g=; From: alexander.levin@verizon.com Cc: Arnd Bergmann , Marc Zyngier , alexander.levin@verizon.com X-Host: surveyor.tdc.vzwcorp.com Received: from ohtwi1exh001.uswin.ad.vzwcorp.com ([10.144.218.43]) by eris.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 07 Dec 2017 15:49:13 +0000 Received: from tbwexch28apd.uswin.ad.vzwcorp.com (153.114.162.52) by OHTWI1EXH001.uswin.ad.vzwcorp.com (10.144.218.43) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 7 Dec 2017 10:49:14 -0500 Received: from OMZP1LUMXCA11.uswin.ad.vzwcorp.com (144.8.22.186) by tbwexch28apd.uswin.ad.vzwcorp.com (153.114.162.52) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 7 Dec 2017 10:49:13 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA11.uswin.ad.vzwcorp.com (144.8.22.186) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 7 Dec 2017 09:49:12 -0600 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Thu, 7 Dec 2017 09:49:12 -0600 To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH AUTOSEL for 4.9 030/156] irqchip/mvebu-odmi: Select GENERIC_MSI_IRQ_DOMAIN Thread-Topic: [PATCH AUTOSEL for 4.9 030/156] irqchip/mvebu-odmi: Select GENERIC_MSI_IRQ_DOMAIN Thread-Index: AQHTb3LnmWCBAhk2jU6O2cHtNalBOg== Date: Thu, 7 Dec 2017 15:49:01 +0000 Message-ID: <20171207154845.4814-30-alexander.levin@verizon.com> References: <20171207154845.4814-1-alexander.levin@verizon.com> In-Reply-To: <20171207154845.4814-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit fa23b9d1b89fdc34f296f02e496a20aeff5736be ] This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled: drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type static struct msi_domain_ops odmi_msi_ops = { ^~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type static struct msi_domain_info odmi_msi_domain_info = { ^~~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags' .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), ^~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function) .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'? Selecting the option from this driver seems to solve this nicely, though I could not find any other instance of this in irqchip drivers. Signed-off-by: Arnd Bergmann Acked-by: Thomas Petazzoni Signed-off-by: Marc Zyngier Signed-off-by: Sasha Levin --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.11.0 diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index bc0af3307bbf..910cb5e23371 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -258,6 +258,7 @@ config IRQ_MXS config MVEBU_ODMI bool + select GENERIC_MSI_IRQ_DOMAIN config MVEBU_PIC bool