From patchwork Thu Dec 7 14:27:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 120987 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp8425903qgn; Thu, 7 Dec 2017 06:28:27 -0800 (PST) X-Google-Smtp-Source: AGs4zMaIKPd1ItwtGDhQbmC1Uo3TzwqoqGkxvtRa3su7nl/xPAV8IXphbIFk5Un+Y0CUPWZCJrrf X-Received: by 10.159.234.75 with SMTP id c11mr27282910plr.422.1512656907031; Thu, 07 Dec 2017 06:28:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512656907; cv=none; d=google.com; s=arc-20160816; b=EsqMJY1RGhHnyXgA6f1RLGLo8np1vuVZD8JO9kjo8niT/5FlYp12fJhesV8XPZautm cw2hCCCvJ+LS435+585sArz7OKyGHGnlJJzSrb8oH6P/EK8Ik4TvA3TMLBR3IeiDrc27 Nrpz9c1ducV8UvFssxywK38/xd+uq4IcDIsJ0qK8e9hj1LSMi4T8cznpSrUsHnH0c9Id cG6gc7bFfdUgLtNmCSD44FfEb9tPSSmkQQAtN9m5nejtsVmtjiQU24MFTZB1Sd8cJXAP AG7TJy7lMmeI52wfFUganH8Aa8I9dvnBSpTYEp75ocORnI9UPZkCrUdt/59Ts85NCgUz u0Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=k41/HapxpcUteShWzrcLk6o1is4mUHfA9p2+aRvDPxA=; b=pe5jP+78GWjcDqw+yYCKiMP9VvTkXkkXgrQNWPWGapiqPHDvNsh/gf0SgUoK4sbeka mWl2G9kN6dXOgKJ3cvMZTF57vesqvpJyBNCz9eCSj6TU6rHIF1dAXsIgubQ9vsG7hmwO yk2w7vNgirjuuynJBoA6m+3rsHyP7+uqk+rz1ph82pfIMKkt0+az+Kr7eb/Rp3B0i4HP osQmDRq3do6A9sho0GYcJT5eoruL9nW1hfr7RujC8s3nMIlc0KbdMhOleenJIofP21it vqjADm+65ec/Uiqhg7zjgko5wK1ar39a6tfN3x6TNrSeIfWHliHZXvJ52D/VhZw/FNeI fknA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=F1SFKqpY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f65si4141473pfj.298.2017.12.07.06.28.26; Thu, 07 Dec 2017 06:28:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=F1SFKqpY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbdLGO2Z (ORCPT + 22 others); Thu, 7 Dec 2017 09:28:25 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33499 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753559AbdLGO1Z (ORCPT ); Thu, 7 Dec 2017 09:27:25 -0500 Received: by mail-wm0-f65.google.com with SMTP id g130so894466wme.0 for ; Thu, 07 Dec 2017 06:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k41/HapxpcUteShWzrcLk6o1is4mUHfA9p2+aRvDPxA=; b=F1SFKqpYxgHELHqUkO6OMmL9IvNfp1jGFCizUHPhmHvV3DNsT4IgsSHa46qT0fqpSS /U1GgZ+L7JZwnWnGVEwt1QNqBB6EuSkoCaXpAUdgXMdSH+vgXgavS+HQPwNJtY3Q4KIn ig2hheIi9jmbps4DXJYRynGNPZMFRJhXt3lyFaBou4CCFQY7cH0idravIz93t+GfHe3b niEl+LydNTA3EFGfEG7OUAMNvx4liSJfC1g+PnCLHVEKllrwbENFka59x/98pPiy6vlm c6neTaJbKk0+967tpnjJ0WI/MwwNQv5jDDMlEQY0yjSez8OJMx7bR9qMdI8cyusj24I7 GjYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k41/HapxpcUteShWzrcLk6o1is4mUHfA9p2+aRvDPxA=; b=oW8COj2xjE2b8UZsJwghcJkhGR/09JPCJ3vtDS7d5/JXz0D2oL2XBOmoUkaU4tIE0r TwKentODulHjuuVWPNrIzMj9pm7jCL2ZjHuWGeOEHiZRPzN7NKkVybag/yXCl9d8IAgu 90xPwi57BEzd2odfIEvhVr5O+0Zi4wbeKXb8e0520d4T9CAIfGh9f9WSQwu1uFXKVHlN a6HeYSzBuEXIz20jPmNUe0eGbYXjBDKkf1p0iO+KtjrXmt8hP7mloyx9sHG6rF6U5RwU aWphk8Yra5c9Yt8ambBNnZLeCa81zjLBx4HaOBg64I6TeDo8btx1m7YLcqI5ChjYZPpf 6Wkw== X-Gm-Message-State: AKGB3mJ+QS02l3nVtIagRhac8L0og/FuJiCfW4dXrK55/6ydG56PZpHN mPifKXwLp2TRcmCTxGzohg5FXA== X-Received: by 10.28.110.26 with SMTP id j26mr1289069wmc.46.1512656844203; Thu, 07 Dec 2017 06:27:24 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id t138sm6264520wme.16.2017.12.07.06.27.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Dec 2017 06:27:23 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Cc: Jerome Brunet , Kevin Hilman , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched Date: Thu, 7 Dec 2017 15:27:13 +0100 Message-Id: <20171207142715.32578-7-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171207142715.32578-1-jbrunet@baylibre.com> References: <20171207142715.32578-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PHY performs just as well when left in its default configuration and it makes senses because this poke gets reset just after init. According to the documentation, all registers in the Analog/DSP bank are reset when there is a mode switch from 10BT to 100BT. In the end, we have used the default configuration so far and there is no reason to change now. Remove CONFIG_A6 poke to make this clear. Signed-off-by: Jerome Brunet --- Out of curiosity, I tried to re-apply the ANALOG/DSP settings on speed changes (patch available here [0] if someone wants to try) but I did not notice any change as a result. In the end, I thought it was safer to keep on using the ANALOG settings we have been actually using so far, everybody seems to be happy with them [0]: https://github.com/jeromebrunet/linux/commit/b594288e629a61574e76112497474fd3cf46c781 drivers/net/phy/meson-gxl.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.14.3 Reviewed-by: Andrew Lunn diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 726e0eeed475..5325940fe899 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -38,9 +38,6 @@ #define BANK_WOL 1 #define BANK_BIST 3 -/* Analog/DSP Registers */ -#define A6_CONFIG_REG 0x17 - /* WOL Registers */ #define LPI_STATUS 0xc #define LPI_STATUS_RSV12 BIT(12) @@ -126,12 +123,6 @@ static int meson_gxl_config_init(struct phy_device *phydev) { int ret; - /* Write CONFIG_A6*/ - ret = meson_gxl_write_reg(phydev, BANK_ANALOG_DSP, A6_CONFIG_REG, - 0x8e0d); - if (ret) - return ret; - /* Enable fractional PLL */ ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_CONTROL, 0x5); if (ret)