From patchwork Tue Nov 28 16:48:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 119892 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1946979qgn; Tue, 28 Nov 2017 08:50:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMYuSrxQ3+NldULmZjimg7AqAclPmtfugCFN0/0/BbpGoPaeflTQR4aK4SIPM9f8wJD8M6mO X-Received: by 10.101.68.65 with SMTP id e1mr15267384pgq.282.1511887839111; Tue, 28 Nov 2017 08:50:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511887839; cv=none; d=google.com; s=arc-20160816; b=g2t+ibenqFR5RaIoi1vorfK4GcBXHCrK9o3PPzKk5rsDFWcr3EThCIz683RQ44cdFn jqs/wYyJRXeBgWWg9UdInssl+1fcbIzXozDeqvJvyMqq0koCh1HxUrI5V73Kmhx/ySav Ftym7WlG8ajSpboyvZxvF5p4P4UBVVV7lC8DcAmLVNroZ7s1zmbeQsL3OxH3dIVpNOwd 9F67XFov3xWrcBmvpJOb+e+EKVzfpJrFSwncZMvTJzF8cvyS9gUpcSw2fG2FuBj8drZE R9Q85xhpsfbllbo4X0GXJeZdImbn2gLpltKRcCVNR4cSgj8zN7Q4leYWDuBDaVIelN8e 9H+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=Ue0M7fOwjDZC/vGU00RbBsThucY3Y+oh9zQSdssHSAw=; b=HFBS7NTQ6VRysohKGf3jpv3osovbp1d0rXlkXTt3stxvJo5uNFkd3yAN7uYM+21Bwa o2glG8PmGQPpzoaG6P5PDx5Ac/yIkwr+1Pcvdd7kF6WiISzbUsq5kB7HjDYsQagE3spE LRfXyrGuSMeFKuqAc03EpXUz1Maa+y/S5qrAfqIWh+nVb8dOq5yVTDWmHQt0uXu3/Jpp +c2eeHox5nAHTH6ubEwTND20JiSYFMPClwTmNOS2WjXkCQNo73yHW6CmSaqNGhLQyEqH odVVPhsx4Eorg1fyB2P1sBOUeZ8MgCLPXUE+RFJBEBOOom0LlTP+Dt1nGCV97DFj05yt PdZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nqMTWQky; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u193si14628270pgc.319.2017.11.28.08.50.38; Tue, 28 Nov 2017 08:50:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nqMTWQky; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918AbdK1Qug (ORCPT + 28 others); Tue, 28 Nov 2017 11:50:36 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38151 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdK1Quf (ORCPT ); Tue, 28 Nov 2017 11:50:35 -0500 Received: by mail-wr0-f193.google.com with SMTP id o2so702421wro.5; Tue, 28 Nov 2017 08:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Ue0M7fOwjDZC/vGU00RbBsThucY3Y+oh9zQSdssHSAw=; b=nqMTWQkywrDgQrCi5HSJjrI4pQeu+naE1BJnZiuJo/FHA3fEKH0HJc4wZdpAlS3U/M gpl10SSKZ7gtdcLI2SKO2pX7JHzLBxtE/izOTxoiXhPf9/TDo6ZmX7MqPYUsc6lCi0lm okkW45scLrYwhajrlqcFfsGFPtMszqu7cmoxm7F2/Y/9JUtiqRj72BTJh/gwLc2CrIXS gaZeY7WJx+hkuwXLwdmmV9BwBD39PTe5ZaNuwmAe8rST/RnfrgubQNQqqomzpiWO3Zm9 7SzV0sB8DpW++NxjDDip2RsfQqMWQx2bPUHS3E6yHpbtMNjployFJA2rCr4sytDh5/Gx 036g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ue0M7fOwjDZC/vGU00RbBsThucY3Y+oh9zQSdssHSAw=; b=tRimtbEhbg9QsCScu77/ISB3gYBAhelI7iCOHrnpvzj/1otGrZUf874Z8Y5LlidEqJ CROIkM+nAVA7BRfWEnqrTJ7SKhsjPoA0O6eN4CKxk0YThPLj7pZ9WETbNcFiYh0zb27C YB58f1MwiVkzbWHSNy+RDW2t9bYZFY2DY6JHqhN7LPzmT0w1wPbnDfvjpCR4P9jyG5p9 oylct0U/7D2RbneWZJHJ8FP9LP0yHgtP5yB2HoDxX+l+V6PF/2gsE4tADO3RwlEkE55M hUqAOGrS9TNJXvjjBV0BXrotzcC5wxHeSAvQ/n+txbIbphxoKMEP49yk8iNjKyBjz6U/ fZ+A== X-Gm-Message-State: AJaThX40PBO9bZpw46VQ1Q0eL4lv3ON+OtXb4gl53K2jNpfXOixnk4ny Br7xye4vHE2TsEtLAyaPXUo= X-Received: by 10.223.186.9 with SMTP id o9mr25931956wrg.221.1511887833745; Tue, 28 Nov 2017 08:50:33 -0800 (PST) Received: from Red.local (LFbn-MAR-1-580-204.w90-118.abo.wanadoo.fr. [90.118.159.204]) by smtp.googlemail.com with ESMTPSA id j15sm3259603wmg.48.2017.11.28.08.50.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Nov 2017 08:50:33 -0800 (PST) From: Corentin Labbe To: alexandre.torgue@st.com, maxime.ripard@free-electrons.com, peppe.cavallaro@st.com, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe Subject: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Date: Tue, 28 Nov 2017 17:48:22 +0100 Message-Id: <20171128164822.29218-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.6 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.13.6 diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index e5ff734d4f9b..9eb7f65d8000 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -808,8 +808,7 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) val, reg); if (gmac->variant->soc_has_internal_phy) { - if (of_property_read_bool(priv->plat->phy_node, - "allwinner,leds-active-low")) + if (of_property_read_bool(node, "allwinner,leds-active-low")) reg |= H3_EPHY_LED_POL; else reg &= ~H3_EPHY_LED_POL;