From patchwork Mon Oct 16 11:32:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 115899 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3572579qgn; Mon, 16 Oct 2017 04:33:16 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCxll9J46EZrLA2Xf6Rbd3Wrj67nNecMzb6SQxpUW/gfbbCRSrz3NYO4Y6A/X76O+dwZvWb X-Received: by 10.98.20.197 with SMTP id 188mr8627346pfu.94.1508153596630; Mon, 16 Oct 2017 04:33:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508153596; cv=none; d=google.com; s=arc-20160816; b=es+hFVXaILNdgc73E4ddWIk36eyVQhUF0HF+olfLwBnTVaRX8sGeAQkJFYBp+yLHL4 /xSLe3z3P+4lNsXTiKJv6KedxekYP6iSlt4hb1g2DZEzPYczjYUUK2Y88JjGnmgLeqrH DqYH54f8EFdmungjGw0nn+ehaUwpnRuMN6q+nRxYANoDk9Kq2H63DL+g8dp65FRVNjSg A73lYQp0R2Uaz6bFx0QWKWXEh5kF7PePH9f8DZBE9TzwnHIrRM1MteCAyHEG1VR1VecW m6f9S5upp66mH9b4NtMLRgIyGo20tZDAA6fqpPhYx2t/K4BjIo8Kyy9bgQCQy+vVZ2YS kGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=spFzz2HE88vTCH9+1rGp4KGYve+UYvYRnSR77dOnlJQ=; b=Ayes6Ed2IBqlS6kqRmAliGhNwoOjUOQg90DXfPO3wjAy/RY9K76SL79cmLxhsHaMuP Lun5QvE1FkjhvoYUJTaLn+8tiQ70uyGWnaySPBvvFUZoOCiwKKPSrMqjNqDboQXzv0DQ wwQzrHUIoUB35SkN/bl/FLJGEp9+uFnU01owgMAm2ZjSgjxMs/gImr/TKEVH16LG3cuc lU0DJ/lEBHkcw006Z+kSOl4CGPGsP7zpvjskBsRaGRrSKRMIqpp22F3mrAr/52ZvQXSR v8YdagAqdjekjxiKVeVCQN+/sXdTAfKJbasoC7LbovXgjnpJzhX0W6y3MritSq1MJhAl Ql/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x70si4253401pfe.582.2017.10.16.04.33.15; Mon, 16 Oct 2017 04:33:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbdJPLdN (ORCPT + 27 others); Mon, 16 Oct 2017 07:33:13 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:56277 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbdJPLdL (ORCPT ); Mon, 16 Oct 2017 07:33:11 -0400 Received: from wuerfel.lan ([46.223.139.202]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MXjM2-1dhbKY1CcQ-00WYyE; Mon, 16 Oct 2017 13:33:04 +0200 From: Arnd Bergmann To: Florian Fainelli Cc: Arnd Bergmann , "David S. Miller" , Michael Chan , Sathya Perla , Nicolas Pitre , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [net-next] net: systemport: add NET_DSA dependency Date: Mon, 16 Oct 2017 13:32:36 +0200 Message-Id: <20171016113258.3735473-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:+f8hdD/TFDKaKhlLDqv/Ej9kRSWh9pb1wiPEKas6Xam8+2RsThh O2QVje4bCkCxfsoLU0heA6Pq+7p+kf2eBMZws9DjbsJgB3h96ln9kK2g35qIkKVmufLBRqZ qhMXNEZH+EGHpG939yTOdr8S1mnKvIBne2X9a2LC/DBfUsF2+GWBF/I7P+k6CBd9XYro6Fa 4xo36VzNOc4V3p5G51n9Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:o/XgGRXYzLQ=:B/KejvX0h060pyxbp8ve4T P113oistQxdGo88VL+v/0QerOmK70CRmzGGTnf8zEM3AWP4WjQ+9dW2UTL+BdJDQBaCGPoMGC CpqE/MRXbd2NgCCap6xF5J7dUKbJIM9+Tgp8QxBl59vcNAlPMweEDY5ZJkLuaFvRc1ZjNMz8w DGGUxfDSs9Cu/imrD42IFUgXKGubIsELiYwJBk11Ea6pF/diQ7E5iIsShhsG/brgqqdqE7Azk 7TMbDv6hpxgu3XGxJSCqmACv5FA8qaYT/jb1yhg+u2GcfQY93TvjvaLkD/319y02LGJB7lz8x dXubTUzH6pNEQqv8pDnsYYKU1kWb4i9L59u8vfDztFrtnZsWB/WgDBAMhJ2rCpdhvUrt3Su1q 3moBKXuPKBbgW+iDqF5FYm+0CaLDR/0/Gj9hcaKdNpvrReFWQ5I75m+VZaomGxG0xlsjtCITr RRlpBgfsKEudiwEpfML5KdDvd80W4iciyRcRdQZVkPaxjI76ukEUwj4mR86PmikTQs3oCP41p zt/SYFDocBblqvXRslr3TRV+ZxgLIi+XmMlRERZGrwilLey/naS33lGRhgeX6G21thL4A2M8X 11xlSrRTRaFnZkkqU9Q9Pc6KFaTSEnSWMghZd0/jasdIfpdud+e+bv1/n8IyuAFZ12BqVYkRc wHjstmhoFHjqxIuImDdFT365MicknP+2iwR7AHyXcaD+QkdfrIf2wRKvwbVEeGoVIjC29DdtP TrjHzQ6STFzYI20UzFcB3+KE3pKmNEJZn2p7YA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The notifier cause a link error when NET_DSA is a loadable module: drivers/net/ethernet/broadcom/bcmsysport.o: In function `bcm_sysport_remove': bcmsysport.c:(.text+0x1582): undefined reference to `unregister_dsa_notifier' drivers/net/ethernet/broadcom/bcmsysport.o: In function `bcm_sysport_probe': bcmsysport.c:(.text+0x278d): undefined reference to `register_dsa_notifier' This adds a dependency that forces the systemport driver to be a loadable module as well when that happens, but otherwise allows it to be built normally when DSA is either built-in or completely disabled. Fixes: d156576362c0 ("net: systemport: Establish lower/upper queue mapping") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/broadcom/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Reviewed-by: Florian Fainelli diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index 67134ece1107..af75156919ed 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -184,6 +184,7 @@ config BGMAC_PLATFORM config SYSTEMPORT tristate "Broadcom SYSTEMPORT internal MAC support" depends on OF + depends on NET_DSA || !NET_DSA select MII select PHYLIB select FIXED_PHY