From patchwork Tue Oct 10 09:14:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 115368 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp3523997qgn; Tue, 10 Oct 2017 02:14:42 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBObZAhZmUa8trKruOooMsENgRvUYdaQ49i9mVYi2Y1Yw3XcQsHScdk6kvxHat7ExJNo5Ph X-Received: by 10.99.0.4 with SMTP id 4mr11915726pga.417.1507626882813; Tue, 10 Oct 2017 02:14:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507626882; cv=none; d=google.com; s=arc-20160816; b=yNhVVYC7It0Wt1YKVPbmLcG//nhqQUvrQ3yrT4RwKn1toGDwGXMvsrtU7BCeNwlC0f Cw77NDgcs4WYtlT2A/g4YCvoGhRPwbTf0ul1YgOvKFFHxiuuz4WKk38Hqtbr0nT76VNW 7Kg9qVu3uFQ+fW1iQWtFE8rS/UBEG3GVqvzF6qs4iUpSE713xohNJmqDwi1heEMFjMm0 4QpyCNPGXfC2hdTU4NxrsVl0dQ6oW7qRKHianMmtUXWcGYLmnPz39v2mSbPBvVU/I3h0 ePfTtAYWZnt44lBtZtfyGip/Ff0U8KoM6n6xtjBKTcQgI+RDc24WKTY4xqHG1DG4M8iN FXKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=n3E9M49ASrZK4uXtU1V/we+1HAJoKVrf4MJYNLMDC5U=; b=ZcyT398TuLPhxPBEnCzyTKFpUDojBWeqLaR5crEQtrgfp+s54L/pgo3OfQ5K9r/HPz zSPvpPd01e7ZzD+UhtKQuzkET53vqfPo1t5oH19V+cgx5Vt+/rD3syZda6hdDDApHDU0 tKDZGx0oE+X+fInwfG+oosKimUX+EoA2DRYdCye1qmZ6aCDE7KBBE+F/nLpNK4IUegue ong5r3hajpxaF9HSplU1G0/nrZb2nmGROIQh38JBaOtbtsjkbY3NMQR6xLq3NJMtZ2P0 ytDiI7LOjG8qMiJn8yFRZxYdOJ0/ZTDT78tDy70A6kQjuEULxQHIrH2V4ORi3dcMBbCJ Dx/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si4083117ply.789.2017.10.10.02.14.42; Tue, 10 Oct 2017 02:14:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755134AbdJJJOl (ORCPT + 26 others); Tue, 10 Oct 2017 05:14:41 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:65523 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755844AbdJJJOh (ORCPT ); Tue, 10 Oct 2017 05:14:37 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0MGiBd-1e6ZZF1Rz7-00DV0m; Tue, 10 Oct 2017 11:14:28 +0200 From: Arnd Bergmann To: Adrian Hunter , Ulf Hansson Cc: Arnd Bergmann , Ritesh Harjani , Sahitya Tummala , Venkat Gopalakrishnan , Subhash Jadavani , Bjorn Andersson , Vijay Viswanath , Pramod Gurav , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: sdhci-msm: fix x86 build error Date: Tue, 10 Oct 2017 11:14:16 +0200 Message-Id: <20171010091427.2244260-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:d3FZTzIgjlU/E7I4kIANUGaWMCslWUEjzyL0DHbTQeQmQAy4fpU GRsQcxZ+U4X4ZYxR92SyR/eDfBWX8euY2LjCkfiklUlFaaiFM1vONQrrNwm5WWGszd1s8e+ KZ0Z96p50w4sWVaI/qlydqZ4iicc95q2eOktuBXr1trlQ8RkG7Q8VVTpdIbi6hxgQyNhDbj MNzb20ArQ7WfSa3+C0mpA== X-UI-Out-Filterresults: notjunk:1; V01:K0:Xl7YEsd8DbA=:Yy67bJPbnZaM4IUvL/dNoZ hwo3LjkF8If9iK4UttPwRuV5ZrTOfwO1K33W0qW9+ek5HjbLahSwgR2G7U91KbrKuA2xcspZe 2SrRzdUOSrxlsxqPMghDrtEM0uzBzXE5pIGBOPj7jN9byZk48h0UwfuGlReYyIdilXBuuS0ze 8spSjwsT/YRxVs8hioua0+4oamwpwkjblNW+/RJR5AtbTCkzPkQJhzXJVYwjCchZSqtu8f+v3 NFdFN7rz6ccjps0bLREFvsewejQnojc+REIuiL7E73QAEWoPq6mJT8RMjJOM98tqHLcWfKaUt AJwBTwg3Z6r1u9tXb3mvcD/4/lgLx7aaALuEKFEtSKiYamrcQcUKAhqVt1ZKC5GrjMYu0+vYs 55oqsOTKM7X085/mGz7iFYMwZO0HT0SWwl4SAIjCOW0GZti1gZky2rfVEDV24owgXM0EhSRNq aK1JQFMocB++akM0f7qqOWjzEih9ipOZGb5M499qrVJk0RGjxf/R9wZO7vvAVYKdTXcvbAG69 TkPxekyTW/CHPr4VPWN6yTiZdp5pAW2am4xcgGLrY2wtEbRgtqO70n4jOxhwl5rIEgiMfgUOv DCI4cq2K/jCYAHUuhvVXyi47iIhsbVuUA2/bfxLFj0HLnbKl78gkVCOgRE0iDZh87ONvMrC9/ K8Aubta06/MAyFV+r7mOSTtIAdYr0WoYaEYHC7AFLvDzGwo23Il/Vs0MzggNIHDbnvB0m+g2v 9JxP9UDaVPfsEsHy3BUPTizZTbBJQvPUZ1dbEA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The __WARN_printf() function is not portable across architectures and causes a compile-time error on x86 and others that don't use the asm-generic version of asm/bug.h: drivers/mmc/host/sdhci-msm.c: In function 'sdhci_msm_check_power_status': drivers/mmc/host/sdhci-msm.c:1066:4: error: implicit declaration of function '__WARN_printf'; did you mean '__dev_printk'? [-Werror=implicit-function-declaration] __WARN_printf("%s: pwr_irq for req: (%d) timed out\n", ^~~~~~~~~~~~~ I assume that dev_warn() is the function that was meant to be used here, so I'm changing it over to that. Fixes: 6cdf3287f490 ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq") Signed-off-by: Arnd Bergmann --- drivers/mmc/host/sdhci-msm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 85a882b4c541..3fb7d2eec93f 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1063,8 +1063,9 @@ static void sdhci_msm_check_power_status(struct sdhci_host *host, u32 req_type) if (!wait_event_timeout(msm_host->pwr_irq_wait, msm_host->pwr_irq_flag, msecs_to_jiffies(MSM_PWR_IRQ_TIMEOUT_MS))) - __WARN_printf("%s: pwr_irq for req: (%d) timed out\n", - mmc_hostname(host->mmc), req_type); + dev_warn(&msm_host->pdev->dev, + "%s: pwr_irq for req: (%d) timed out\n", + mmc_hostname(host->mmc), req_type); } pr_debug("%s: %s: request %d done\n", mmc_hostname(host->mmc), __func__, req_type);