From patchwork Mon Oct 9 13:26:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 115227 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2561124qgn; Mon, 9 Oct 2017 06:29:44 -0700 (PDT) X-Received: by 10.84.194.3 with SMTP id g3mr9332423pld.246.1507555784870; Mon, 09 Oct 2017 06:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507555784; cv=none; d=google.com; s=arc-20160816; b=le9T1dQv+9onR7naFYAd7fuUi2f/J9AiqHsedTI1Lg38v5OOmGolMo1uFy35Eh0pP7 nXa7wy+olZotfGg4l4lFta3b1aMIeRPiMl2ToQ5nZDB+A7D0Hcvkqno3joQTtYPbvglP c8nv8zeWfXCv20v02efjZfnC94UEOcba22nFVK8Q7y3Tmo0QwSSb1CzbKM13PgLzppZv +KKx1qBIa60cD+bMEiq1tQgdO4c48G5Yi7ura8gZvOiTCESDbM2rJJUQEgN8DqD0WXwp OmEr8v+C4/45FCyR5qOgLKEDgU4zvTv6WTOcxUTt4gQsfTi8vj9iQU+LAcYYQqkKRt1c kEsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=BKyfWudeTmrJrYhwZLyr0RG0OC0Ttj7QOFrNHXRlVSQ=; b=ndZd5kflr8Y8PRNOLbdMjtTk0OwRWamocA2a1YyPYpWrMBYJtYdtQVed9+mhuQnqw+ rUesm7aUC1SvwMRppXtZo+Q62vemCJkt7uSykJF6zV02aunBVpFq1mjV8Ei9mbiSxSK/ G5nVhJG0VWtEKlt67Uhp9CmjEBn/k5qhG6VE8S7nCfhgulCm+NYfdUUTeYYPnYYJz+c1 9qa9Qejw3HSSV4Rt3q94EunEGiWci1yvFjyVfeaddOJ6p2dG6wAbAg1XqwRupbiQmRKS q6o+JyoB+0axdPyipUgrO+UvJU9IZXCURlvG98ZavfSkmwTvNF3uKvrrkxN8Ymynf9TP yU+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kzTRRsZK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si7037718pff.305.2017.10.09.06.29.44; Mon, 09 Oct 2017 06:29:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kzTRRsZK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755053AbdJIN3n (ORCPT + 26 others); Mon, 9 Oct 2017 09:29:43 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:53982 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755397AbdJIN0z (ORCPT ); Mon, 9 Oct 2017 09:26:55 -0400 Received: by mail-wm0-f41.google.com with SMTP id q132so23466757wmd.2 for ; Mon, 09 Oct 2017 06:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BKyfWudeTmrJrYhwZLyr0RG0OC0Ttj7QOFrNHXRlVSQ=; b=kzTRRsZKDQp0KeadqASEa9kk99ULy9409uRttFwGsCYTJGux/1w0c3I+GmmeHyPQUe nxWxkSvvWJ4b1z0SK7ptbHa5Rzs/Wyy20yKj4WKjbSKHMDzR3BzV5cstGbTCDMiJDDtF SjrcuhZuV/aHUVGH/E13dfKe5qUBVsIm3A/KU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BKyfWudeTmrJrYhwZLyr0RG0OC0Ttj7QOFrNHXRlVSQ=; b=E13Stt2KAOA44C22tmRcNVmatbJ4yhuEzIurjv9Hy9DkmQ28a2p/hv0Hp7FAfGYPnR ejTDuu6N8Hh2JwjirRQtjC1K6JFAodk6RYWZOmquH0pzPjPrlacJ8vxEIqiuY2XF+g/h N2q+0/jLTpeCpnXescTVQbbYrSvPwhMb+AsJxVRM86NpVdy4sJSA3Jiqfmur2Oi4UAb9 Em2QUkAuF0fNKJM8KMMUGyeI1gUQKLPvNIyU6OD1teSTOKkOBU1chmPjzvkVlErL08Ns WkrSVa69CvRRexiCFlv6Xb3VIAa3QETJtfuO23IXpY1i6B+8+shQSET02lr99nAJePji WntQ== X-Gm-Message-State: AMCzsaU7WoQ+VW6WZ2pTuK4++rO1xvIQH0Or1bRnSU71Vkk0MAn8RY1x AQr9lzyp27jG5hO+dzazq+FCHw== X-Google-Smtp-Source: AOwi7QBjSwykUcqHeh0CCnkqoeCTTgmbd+Mdbu9jpeZfNzoHw0YmJCcT3dinVpI013D1QzyTUK/h5g== X-Received: by 10.28.16.142 with SMTP id 136mr9352772wmq.62.1507555614113; Mon, 09 Oct 2017 06:26:54 -0700 (PDT) Received: from localhost.localdomain (static.8.26.4.46.clients.your-server.de. [46.4.26.8]) by smtp.gmail.com with ESMTPSA id 31sm3775340wrm.0.2017.10.09.06.26.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Oct 2017 06:26:53 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org, Masahiro Yamada Subject: [PATCH 04/12] nvmem: qfprom: fix different address space warnings of sparse Date: Mon, 9 Oct 2017 15:26:33 +0200 Message-Id: <20171009132641.27169-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171009132641.27169-1-srinivas.kandagatla@linaro.org> References: <20171009132641.27169-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada Fix the following sparse warnings: drivers/nvmem/qfprom.c:23:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/qfprom.c:23:30: expected void [noderef] *base drivers/nvmem/qfprom.c:23:30: got void *context drivers/nvmem/qfprom.c:36:30: warning: incorrect type in initializer (different address spaces) drivers/nvmem/qfprom.c:36:30: expected void [noderef] *base drivers/nvmem/qfprom.c:36:30: got void *context drivers/nvmem/qfprom.c:76:22: warning: incorrect type in assignment (different address spaces) drivers/nvmem/qfprom.c:76:22: expected void *static [toplevel] [assigned] priv drivers/nvmem/qfprom.c:76:22: got void [noderef] *[assigned] base The type of nvmem_config->priv is (void *), so sparse complains about assignment of the base address with (void __iomem *) type. Even if we cast it out, sparse still warns: warning: cast removes address space of expression Of course, we can shut up the sparse by marking __force, but a more correct way is to put the base address into driver private data. Signed-off-by: Masahiro Yamada Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/qfprom.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.11.0 diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index 2bdb6c389328..b96730e99580 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -17,15 +17,19 @@ #include #include +struct qfprom_priv { + void __iomem *base; +}; + static int qfprom_reg_read(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct qfprom_priv *priv = context; u8 *val = _val; int i = 0, words = bytes; while (words--) - *val++ = readb(base + reg + i++); + *val++ = readb(priv->base + reg + i++); return 0; } @@ -33,12 +37,12 @@ static int qfprom_reg_read(void *context, static int qfprom_reg_write(void *context, unsigned int reg, void *_val, size_t bytes) { - void __iomem *base = context; + struct qfprom_priv *priv = context; u8 *val = _val; int i = 0, words = bytes; while (words--) - writeb(*val++, base + reg + i++); + writeb(*val++, priv->base + reg + i++); return 0; } @@ -64,16 +68,20 @@ static int qfprom_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct resource *res; struct nvmem_device *nvmem; - void __iomem *base; + struct qfprom_priv *priv; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) - return PTR_ERR(base); + priv->base = devm_ioremap_resource(dev, res); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); econfig.size = resource_size(res); econfig.dev = dev; - econfig.priv = base; + econfig.priv = priv; nvmem = nvmem_register(&econfig); if (IS_ERR(nvmem))