From patchwork Mon Oct 9 13:26:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 115229 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp2562043qgn; Mon, 9 Oct 2017 06:30:32 -0700 (PDT) X-Received: by 10.159.229.130 with SMTP id az2mr9363368plb.113.1507555832543; Mon, 09 Oct 2017 06:30:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507555832; cv=none; d=google.com; s=arc-20160816; b=Vfou16NAlwR14nY7HtqXmkK/C4FPryG5oJS4jvfIGCFqFnw886dPGvnC4bXNkxKSMe uKBhtplmn3Xy4PcNkUYp1dmH9EU2NlizTD5H+GzRkTAFIWCNpQDAlPh7Fb2sI2/fWDDh CK/RFd2Je1jYynIcLBwhTTbUS/vA+BbvEY9Wgm8aIHIShKwPFxHP/Xd1RU0BZR6Hjvtv 9fw5yZoqKCyRQlOlIOIUr2QnOTxS+AohEzA/0xDEOx7/JAnrgw0uofArPlEH3L3FhkI7 0ZWKi3bDF2Dj7nKaWR+1TgSCfppfrwTaLyUxj2tY8x63jQWjZEiF5C7xLdrDS6tVnFPV Virg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=8k62d4914PQiINiygZjU/XJP/IgpIAVS5tK/heScP0U=; b=b49PCeSU3rhEyNRmFzAXei/ziFa4ufeLjSblfhIJT/FA65p1e8/cYWyeWfWXHj/TWN 2CxJ+uoLEDPJYX5MsiESDSZgczvHn4y/LH6w77aWwa8YobaJO1srhXTcfi/EINGS4uEe CFI6jQX5zkSU6hkDpB8BdU9XbW0PbIxkYFWk28z2RhQQs2fDRaKzkeCb4xRI9iy7pFq9 5HYrORvYJWZIqoJ29ZrJxRkyOa4F4dcXqCm6/ANrz6p2slmS2qnW8u/MRVBffarFYH3K OPi9B3NfGKA2ORiTiDlSkJSfOsAIjSjS7hPwKjBn/5tossI/GDtZZoNR7m8bXe9pDaLm ipUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L0K4gAGy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x65si796547pfk.375.2017.10.09.06.30.32; Mon, 09 Oct 2017 06:30:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L0K4gAGy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755077AbdJINaa (ORCPT + 26 others); Mon, 9 Oct 2017 09:30:30 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:46422 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755264AbdJIN0w (ORCPT ); Mon, 9 Oct 2017 09:26:52 -0400 Received: by mail-wm0-f49.google.com with SMTP id m72so22557833wmc.1 for ; Mon, 09 Oct 2017 06:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8k62d4914PQiINiygZjU/XJP/IgpIAVS5tK/heScP0U=; b=L0K4gAGysVC1r4jtmv9nsbqPU8w+pLMyk2Np1ju9A2pHj2vxZfMlpJqedOXrvt/dRZ 5I+WvQnNO2EHqLrBaAohpo10dPfdPdR1DJA2R6BAfawaZYZojDMBs6hzR+5XLEwp3BQ2 vjfhAckvzLRlkhpDr1nE4V2ElK5up21zlAKv4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8k62d4914PQiINiygZjU/XJP/IgpIAVS5tK/heScP0U=; b=Pu6oBE2AVoHT6PH5tUKxOiuL8MHm0NC3JiXHKA4ohXaT2hksyhuYrSyYJgTUmA2/lp co1GIjrjbNIQihQqP01OjvatjEi39ksgNEjeV1jXaR22Wix7uF6Br5pMUQPA8ICBvgHE 0zShgYrSPsU0Vna6v3rl8bdNAiNJEUL+K4d8auQrEFod5bkP7BSAEZWK9EwwLj5+CYsh snYd2usM9sYmtcd2aorDkhVey8HMs2CBUIioa2CJzYZMzE7QPUQbDfVU34djf65hgRan BIDAomAMXJzPHvJbQlmxDadmio2ZdPwEqzs15H9X4/5oMHaOwkMIvX+xBHgcfSBsp31b lq/g== X-Gm-Message-State: AMCzsaVx7TXWeajqMgY4SfghUyxa1tQ1izx9TkO8bpPCe3UKNX1DRv/K Rl3NdikhqXWTPcgu8ICUe66TZEMI7Mg= X-Google-Smtp-Source: AOwi7QBGKfFsIOFKZltvWD5heR/B+Rc9dSQBhbti53Mg9iU+VE92QAO6Tp3/PCXBJVTLmdsqO31lAQ== X-Received: by 10.223.169.143 with SMTP id b15mr10716958wrd.127.1507555611114; Mon, 09 Oct 2017 06:26:51 -0700 (PDT) Received: from localhost.localdomain (static.8.26.4.46.clients.your-server.de. [46.4.26.8]) by smtp.gmail.com with ESMTPSA id 31sm3775340wrm.0.2017.10.09.06.26.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Oct 2017 06:26:50 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org, Masahiro Yamada Subject: [PATCH 01/12] nvmem: imx-iim: use stack for nvmem_config instead of malloc'ing it Date: Mon, 9 Oct 2017 15:26:30 +0200 Message-Id: <20171009132641.27169-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171009132641.27169-1-srinivas.kandagatla@linaro.org> References: <20171009132641.27169-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada nvmem_register() copies all the members of nvmem_config to nvmem_device. So, nvmem_config is one-time use data during probing. There is no point to keep it until the driver detach. Using stack should be no problem because nvmem_config is pretty small. Signed-off-by: Masahiro Yamada Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-iim.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) -- 2.11.0 diff --git a/drivers/nvmem/imx-iim.c b/drivers/nvmem/imx-iim.c index 52ff65e0673f..a5992602709a 100644 --- a/drivers/nvmem/imx-iim.c +++ b/drivers/nvmem/imx-iim.c @@ -34,7 +34,6 @@ struct imx_iim_drvdata { struct iim_priv { void __iomem *base; struct clk *clk; - struct nvmem_config nvmem; }; static int imx_iim_read(void *context, unsigned int offset, @@ -108,7 +107,7 @@ static int imx_iim_probe(struct platform_device *pdev) struct resource *res; struct iim_priv *iim; struct nvmem_device *nvmem; - struct nvmem_config *cfg; + struct nvmem_config cfg = {}; const struct imx_iim_drvdata *drvdata = NULL; iim = devm_kzalloc(dev, sizeof(*iim), GFP_KERNEL); @@ -130,19 +129,17 @@ static int imx_iim_probe(struct platform_device *pdev) if (IS_ERR(iim->clk)) return PTR_ERR(iim->clk); - cfg = &iim->nvmem; - - cfg->name = "imx-iim", - cfg->read_only = true, - cfg->word_size = 1, - cfg->stride = 1, - cfg->owner = THIS_MODULE, - cfg->reg_read = imx_iim_read, - cfg->dev = dev; - cfg->size = drvdata->nregs; - cfg->priv = iim; - - nvmem = nvmem_register(cfg); + cfg.name = "imx-iim", + cfg.read_only = true, + cfg.word_size = 1, + cfg.stride = 1, + cfg.owner = THIS_MODULE, + cfg.reg_read = imx_iim_read, + cfg.dev = dev; + cfg.size = drvdata->nregs; + cfg.priv = iim; + + nvmem = nvmem_register(&cfg); if (IS_ERR(nvmem)) return PTR_ERR(nvmem);