From patchwork Thu Oct 5 03:50:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 114839 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp144280qgn; Wed, 4 Oct 2017 20:53:16 -0700 (PDT) X-Received: by 10.101.67.201 with SMTP id n9mr20963987pgp.453.1507175595977; Wed, 04 Oct 2017 20:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507175595; cv=none; d=google.com; s=arc-20160816; b=csHv1EkJmkjdn5bRwZVWaA5BLrDlXHxhuPQBwSnTtWPOM4RbCo6q3IKifGXS5ZHHR7 0Ax4B/5/RbpIlg5tcUVAq+YXVxtumPWLKTyuDwy/SyNQGQQTYIckmls4Fte+DCfiQLwV ANRWf7qF+sl9plGL6/3b4lCW3wBFa5rSVPTGW4SHl471l3Z+UFUxbt4NSuKtjRx1SWZs FxJrAWnf4W3110vFlDOEnS9asPx4B5tVnPjuisohzTVolCTPGejSIel1HdZeX2Bvvc+X ohcHtU9btQbYlZkVwfZyyVYvEkcm0qp52Y4bDglHWzCAenh69p4mjGdDDl659fZQ8xho V2Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=pe0Jh3CwiTp5SnyNs/m5/YaMLQuCFoTgalo/e1k5T/c=; b=v7LqoHPcDrW39DuTGiE6uHY4+BzmLFskpVrwZTIDohmjVsiM81TOMyvsgGMNPZcTM+ D5/FcgaP9sGTcd9hwHd2oBIQGKdMYocwxtEvantZShdqvAiBjimCjBN6AsP52ZNlJBwg vKoVlq0IEUpmGuIo9MPb+eU+TaDyuNptdtDHUuWZROFREfNaC9vb9u8BuP7caGKSoZiS bQyF0fmCQc0A7upmfwgNUwcr0cV4UYKIHgI4LOvQyQLiNDwRv03MI0QvE0MaQBNHKKsN PBypLumkQFw4/BEoxTbT5VLQT5ANA37vHaOKcn7jIoXQgI0ETP5O/BVLwbNsJG3BRGFY 5zvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WW6UcpA1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e23si1710017pfd.376.2017.10.04.20.53.15; Wed, 04 Oct 2017 20:53:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WW6UcpA1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdJEDvP (ORCPT + 26 others); Wed, 4 Oct 2017 23:51:15 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:47734 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbdJEDvL (ORCPT ); Wed, 4 Oct 2017 23:51:11 -0400 Received: by mail-pg0-f54.google.com with SMTP id r25so5230605pgn.4 for ; Wed, 04 Oct 2017 20:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pe0Jh3CwiTp5SnyNs/m5/YaMLQuCFoTgalo/e1k5T/c=; b=WW6UcpA1MrciJCh0jCzn8lVBPHqqsG05FKUeXnWuZkLpTzeXRMwnYjxTgpQTc+P3nl tjruC5R52LM6xYzDsVgx3NJ2JdNiOODK4dX5bSjJcFCeAdQtZP85Cc9HL6sNQ4SGZLUK p/OdU+U7pUurvSWBlxJa/GMEksuv+siT6BVrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pe0Jh3CwiTp5SnyNs/m5/YaMLQuCFoTgalo/e1k5T/c=; b=e9YP2IfSVSkuw709DdRRNZs1Vn2Fs69/PZ9oZlLnhk6LLGKL9xqWe5GX5BwKLM7xsj PzpubIHU2mVyJ29NslTojeqNKpHymzBgth8Rl/L2vwa/tGYWFqIsE7+aoI5ysvjwdkWB 4pNLnGOdKsXT6swreo9z2OkGz5XIxBIxwVSaWZ7KxXY4210e2qjHVc24cNQi/gop26Mi Rmm98suyYpmXAb9xWdHfntLJWN5YJH+79rNEkpNGK9n47ZhKwF8fdacZ+kaYZih7LOXn Sozs87DVSlU5pdrTnXpKWCDmoUh5bi8KqkwrcScs37iHk1DNQ0wiLF4abEznvUuy1MnH cZQw== X-Gm-Message-State: AMCzsaVHMsgcAueJ6SK0gBTLpwNXLSPLaLF1lJ5gP7YdRAuZdVP4Kno4 zqE9Eu8stHAuDkPytzmYBH0LGvfAGzU= X-Google-Smtp-Source: AOwi7QBTSj9xWSXfpXkH4EKYMKasxIb0iTSM4WMbDzl5+0xXxEDXQcqiEnbrAmNrgc/zn9Lrv2ugXA== X-Received: by 10.101.74.193 with SMTP id c1mr3494091pgu.260.1507175470668; Wed, 04 Oct 2017 20:51:10 -0700 (PDT) Received: from localhost.localdomain (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79]) by smtp.gmail.com with ESMTPSA id f131sm13067035pfc.27.2017.10.04.20.51.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Oct 2017 20:51:10 -0700 (PDT) From: Bjorn Andersson To: "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Chris Lew Subject: [RESEND PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err Date: Wed, 4 Oct 2017 20:50:59 -0700 Message-Id: <20171005035105.14677-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171005035105.14677-1-bjorn.andersson@linaro.org> References: <20171005035105.14677-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.12.0 diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index c2f5c13550c0..7e4b49a8349e 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -541,7 +541,7 @@ static void qrtr_reset_ports(void) sock_hold(&ipc->sk); ipc->sk.sk_err = ENETRESET; - wake_up_interruptible(sk_sleep(&ipc->sk)); + ipc->sk.sk_error_report(&ipc->sk); sock_put(&ipc->sk); } mutex_unlock(&qrtr_port_lock);