From patchwork Fri Sep 15 19:31:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 112748 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp979325qgf; Fri, 15 Sep 2017 12:32:12 -0700 (PDT) X-Google-Smtp-Source: ADKCNb7c9rME+DlbFG/i0M1nMLebowp73EA0TatH9hmLUc3EhTvInYl5is+5vv7v+KIxyY0Ln3ii X-Received: by 10.84.234.197 with SMTP id i5mr29021280plt.184.1505503932552; Fri, 15 Sep 2017 12:32:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505503932; cv=none; d=google.com; s=arc-20160816; b=SYynKkPa2Mq7bZ/ISIyGh8BZ5M9J1mcKRpf5YPV2PhB4VWZHepzTMsHhGfe1v/LfrW m2pumw4UUUvACMHmhexL4h5HdcOP9vyA4XPLSlwjoU/lnJJRn41urlmHiLhXMdnAN9Nz 7sTgdGhgO9GjHyjyIvxL3JW1OtVGBs2zxvhOWHmPNSlIj33u0fWH9YrOhnojeMjzzS6L KXN2FCiRVvsp1RVUH33eW3cX9sJj3yucHrm+JMcHmmdjHgAynWnoJwQEkrEMM9JHg86W t1luSYiW3oMn6vWtnj4Z8++cbklg2aKTPXZjobuLNYp087t4fTTaGNpXxRwAUPyG76n2 2IlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=I2/Yb620sNnOtgaNYj3berrEJ7/IfjkA5f+XM4u3R1c=; b=B2vw36s7sQOeZXVaDeRxPDO72FlBtEceLbNuevlKmGpYk5FvIQ1NYcYJXp5qXVQrwI AjBFSxxl3sfTAcVidrDSltbl1wb8YwcH4BFRaxvCyuYijc6cIizS0Rm6advm2gc1CPa3 LsmR5jKMQjwD9+hdXbe8MJxv4tMmESufWu5N24s6Ae8Gyaz6WXqHU4nL7FZErF3NseKj 7Je+2cgW2ptaAvMIVHtKbtPsxwD39kBfoscfBJHxTzjPCVDr8GbJyaIFNO7TvyKFC5Lr UJU6ZiOE+fdtslKRRqS29P6zixxl2bdkaKOXIlcvtafRJ+zNcgL/00zVQBItB0ROEtJn 66Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si1154668plk.36.2017.09.15.12.32.12; Fri, 15 Sep 2017 12:32:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbdIOTcK (ORCPT + 26 others); Fri, 15 Sep 2017 15:32:10 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50035 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdIOTcI (ORCPT ); Fri, 15 Sep 2017 15:32:08 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MHtl3-1dpubM2WuD-003dzr; Fri, 15 Sep 2017 21:31:53 +0200 From: Arnd Bergmann To: Andrew Morton Cc: Arnd Bergmann , Michal Hocko , Vlastimil Babka , Mel Gorman , Hillf Danton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: meminit: mark init_reserved_page as __meminit Date: Fri, 15 Sep 2017 21:31:30 +0200 Message-Id: <20170915193149.901180-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:rugLZlvsziAul8pryBXcT/MIaD4rSWkMXUquYskxBBsH7KqhbWq 0BpZAY1RiyDrSB921fc6SjQ1M0gy0xHv60eyR9cXhJX2KElev9UYwMhUBTtllagWw121EZm 4LhmzkFS72/H34eHTd47idJtEGY4zwhRbgr+dFDTKbu1U5XLYpnTSWQNC0hKV9pMeJLw6Nb RaZFpJcQAAhbNIhZqRgXQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:F576bJSuem0=:eSJif6GLyWWVB4YV6es8NE 3D0hefFBGbJR6j6k2LCwqywWEb2od+zX06ptnL/DA9EJntY2xKPbxXbd2h2el6imD6sJFXrAY A7Wlk+LPm1iwd9CVkwY19q1aygKa3JWfkj3LStSQcqNO3LdKVex2HiLnKQxwQAqEua08txYnT ZzWp0htidH27Gwv6gKjcO8cFGLMLxxkf8up7CF+jTGENHI1VAUW4hi9Oqb0yl2QAMhcP1CuLl kZTtMjnVjqWKfzpUtx+/wvY0PyHoEgZA9XS52wX4iWoHwHaYWxmd8iW43OVp/fiAh91vPFSD0 h0T0kB2B07e0ukl4j0G0ajk7zsPepY65keCX2OSsX3HNN2bRw3y+e2789qMiiev2ssADkapOU yOeutZPRxk6ezuzeggkysc5nPxd6+oC1DxroODWRvF/VoThL0rzIH8h7UQhXb2IO0e3Pyii0D FWYgp3POl9tNYlHHytaHVc7KGYkQn13T2JiLXBYSoV9Gs5nOX0K+uoczgi7ZtmvMRIPZC6jKD Swc+G4r+7L2GvpMKm3OAQ8Yig2XycpTXMdWJFalaD9sQLm3yvI4hAkxr3ToMged0tWp0d5PNQ 39LVkFrTFE+1Ch0g99FrnvltIR19fQTocnJfjGNlU4HXzVCuTA5p11JDXQpT37/SBNIfEZo4D oFUSV61xBSx0R4slYAGX/PHcYk767l+xMrkd5sLyI2qJBgq2S451YEVKknj7UDIpx7GP33EuP FnN1fNuewEmc0uXY6P3uXyR2y3/aE+G4O30bAQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function is called from __meminit context and calls other __meminit functions but isn't it self mark as such today: WARNING: vmlinux.o(.text.unlikely+0x4516): Section mismatch in reference from the function init_reserved_page() to the function .meminit.text:early_pfn_to_nid() The function init_reserved_page() references the function __meminit early_pfn_to_nid(). This is often because init_reserved_page lacks a __meminit annotation or the annotation of early_pfn_to_nid is wrong. On most compilers, we don't notice this because the function gets inlined all the time. Adding __meminit here fixes the harmless warning for the old versions and is generally the correct annotation. Fixes: 7e18adb4f80b ("mm: meminit: initialise remaining struct pages in parallel with kswapd") Signed-off-by: Arnd Bergmann --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Acked-by: Mel Gorman diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a123dee01872..ff45b8ebace3 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1190,7 +1190,7 @@ static void __meminit __init_single_pfn(unsigned long pfn, unsigned long zone, } #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT -static void init_reserved_page(unsigned long pfn) +static void __meminit init_reserved_page(unsigned long pfn) { pg_data_t *pgdat; int nid, zid;