From patchwork Wed Aug 23 13:30:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 110831 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp4133085qge; Wed, 23 Aug 2017 06:31:01 -0700 (PDT) X-Received: by 10.84.248.14 with SMTP id p14mr2966337pll.205.1503495061719; Wed, 23 Aug 2017 06:31:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503495061; cv=none; d=google.com; s=arc-20160816; b=T4IElsxQwxlo0FUH0FbPJ2uLVfwxvx0dRueQmLRbcbkstuiz/9IAUzUf/dd8wWdoPa r1yYxWBEEPnBmOuPF1x/n4U5+uoWjm/aTPPtRoZqFWTPtQKlEVWAvoByl2wD/kgyCvRu 8rZQHgNDLOa/05kii3aeN3CRLUtB+Zwn9IABw7enLnPrW6++oofGTYTInclAUFakHfuO vAwwXMi78+o9BszBi9ja1mhrs6Tx+2bB/MxdxVlCA9O9h0hpZwd3eP5zD94VjOY6Zj6S u8dijvRUekwEJehQm5Gn3nmha24u5Gig1GwIh5hKbSiojeYy4KdSDMM+ZJSzmJpvGL3N K+6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=WVHncepmPA/P2QRpEt3FWTUoWOeyAvVtvsB6xRShER4=; b=g7AMEuL4hui5pIffvfkGSE39vSU/nhBrdg5nG/P80ait21icbB8soZsE2pjh1lM/Bi 8dpI1Xo8AnREsoZ+IWyGGdtOE8c7cUkNn8yf06avhaKxfNp0fF+apShwpwKWbLBqshlk nLyGVqcJGjPGK8MoFH8kmGGKm3M97mhlFdOQj/e8gOuQJaxMKHJDOh2AuK156EGb016U TAuEiynGhjieZafvjUpwTc3lXU4GYcOfSdUBILCHK3ZbOHCsp08bmdx1Fcr5GYY51NxK Rl8kHmp/0vLuieuoiTR0F4Vbs0AvLa0W7zdP0zWKVu1P7k7vfHf4NfSdCJNNm3cyTgu6 5T/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1si1183213plk.737.2017.08.23.06.31.01; Wed, 23 Aug 2017 06:31:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754065AbdHWNa6 (ORCPT + 26 others); Wed, 23 Aug 2017 09:30:58 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:56571 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753973AbdHWNa5 (ORCPT ); Wed, 23 Aug 2017 09:30:57 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0M4VfU-1dLApn197E-00yhg3; Wed, 23 Aug 2017 15:30:47 +0200 From: Arnd Bergmann To: Laurent Pinchart , Mauro Carvalho Chehab Cc: Arnd Bergmann , Sakari Ailus , Pavel Machek , Sebastian Reichel , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: omap3isp: fix uninitialized variable use Date: Wed, 23 Aug 2017 15:30:19 +0200 Message-Id: <20170823133044.686146-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Mremp0+xmJLdQJ0YmsZZUbIMTlqwcAAaOWNujvm1lfC6OfX3SoZ HuoLjwHUr0EA7VTBuEibbxTRhCwFB76zV2YsgjKxR58NdocFFMpsQOKkWUzb53m5kl+/TLN KO9/6lqZ0C/L/NqhipYayo4iIERwqS6Y4WQc7Qq4Sx6rrkKEbYLQHuAcLMHjooDCSKN6CIm 7TARUtSy88ErZpruu9/9g== X-UI-Out-Filterresults: notjunk:1; V01:K0:LEAw2dL16oA=:cGyw+sOXLyGUWIozgLgxKg N2nKzZksTLRqKCOs+5USwyZPmptB+TMdxNFw34Y2jATp322JceZ02c5yB5TcLN+1UX0ZgT5gi kZ0GSoI3uJSGdB2KqZKbtvA2FiFx2j6sWvxZH2X7q+zoh5QcOiwkFv6NYIDdXe71jqKieUyq1 ixTpb79E7XhbfiwEfXqo7Tkk5wGDqIOOyXCZLVoi1YnH4wEBmcqBV2aI3g9CLQ9MlHq1d0YMW oOpV2X4yWt+JWP4VTDXeI+b7A1yCpxAgPClnSyqPJe65HIbv3PPrbNqcNXA5C3Z+xaTvGDp5h h9R/I5QGjgUbCi/NjMSCrQMk081SaKmif8vKM6MYFJfQEFFEoPEg0iI62ZLZnsH7yUckzh1O1 m6JmiyCYhsyuUnDNSwkjD9UcjrYo9lg2jtvK71zMu5b3RbHUjdpyR4roUJcssxESh+eVdx3j6 lcj93ZasKNTZkdGVL4ao4z5/j7pBlH/1LuxP8JyF5bLMDy6DkTmUnwdf8gLEEj4P8vL5DRG2q FytqqKuwTWtaKNE7NwAFbtP4xEQgLxjmWISGEHSKW6yfesmK+tA8IFsXQmw3NOiwuV3dTFu6A uPL1RkVPLzlkKCRzKmUV6gyTy8eXieuByOWMOBHv7oz0z+9CGL75rapwr1MKdP/NhVGHuNbj1 IDrET7sNNdUB9VPQfj1vEQzktZnG8xHW4/p8j4U3M00KbqkxxixkDkqFPIDC8Uw16jrsTYe3/ yYZ7wVu7FG4wWmXR2mMNMX8ehwooOSLbN0TXew== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A debug printk statement was copied incorrectly into the new csi1 parser code and causes a warning there: drivers/media/platform/omap3isp/isp.c: In function 'isp_probe': include/linux/dynamic_debug.h:134:3: error: 'i' may be used uninitialized in this function [-Werror=maybe-uninitialized] Since there is only one lane, the index is never set. This changes the debug print to always print a zero instead, keeping the original format of the message. Fixes: 9211434bad30 ("media: omap3isp: Parse CSI1 configuration from the device tree") Signed-off-by: Arnd Bergmann --- drivers/media/platform/omap3isp/isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Reviewed-by: Laurent Pinchart Reviewed-by: Sebastian Reichel diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 83aea08b832d..30c825bf80d9 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2092,7 +2092,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, buscfg->bus.ccp2.lanecfg.data[0].pol = vep.bus.mipi_csi1.lane_polarity[1]; - dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i, + dev_dbg(dev, "data lane 0 polarity %u, pos %u\n", buscfg->bus.ccp2.lanecfg.data[0].pol, buscfg->bus.ccp2.lanecfg.data[0].pos);