From patchwork Wed Aug 23 13:22:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 110828 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp4127297qge; Wed, 23 Aug 2017 06:26:08 -0700 (PDT) X-Received: by 10.98.141.70 with SMTP id z67mr2750251pfd.289.1503494768567; Wed, 23 Aug 2017 06:26:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503494768; cv=none; d=google.com; s=arc-20160816; b=UbToDGqMg09J4kYv7xqushQ4BsxY3UKiDkO/CqxmVPB6ZHzK9X1FdBjkResUoIKf4J vcstrwzlyRgeBh8Kz33NzESgn+xuKDMsiynQ1Bvr0oNqinbCP2YNBdLZUWB1Q0qbUD11 cfH11i7kdw2zbT35wZQOtkoq8KSi4ovoz/pdgQF2G4YNghpC7aEIJCUncWqilb5BzGpt Ws54yfhkw9+7+EDObQmqjyRYJguYOU8iWWQUUx67uV4Sc4Sl5O+IHNP7JXcCLo07ovaZ wjBJhaioSNGPIL7YMkxVaOV4eeEFXZ4b64PWg3X+4pFK1aeim48NkZXQJ95OaLWzWIFd eFSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XXPwmPujqdEmgEGL99ykjiDt8SgDE+OmgM7zKhxQWCE=; b=GcyTMxHJ1OwXWqCywxnFTxoCmhF/nWWYMZR2Rwh8F/UBJbn7U7nLWLEIV5RirDYUqN 7oXXfyU8DM+tcfgn6S8etwZkDB4/avEiLF+6NNTqc2gdp5vBzYYXdlKqLRI98KcDEerm kBbl9vJzfP+DU78dy7jYUUwj2zfOR1S9Zsh+4YnZg1chHrZBI13hxkFbsWu5AiPO6Ym2 3OiR0npx5+Howns9ZsSJvrcUhvTOPpYmVW0yud77x67PivRLkHQv+3KedWEmH2jpMtuV GaWs0RTcIipqT5ZGh92mPPDKOs3tUZlZXzSEcewCX7UpaR25Wdea57CPJSSniLghwIeQ oZOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13si1078656pgu.50.2017.08.23.06.26.08; Wed, 23 Aug 2017 06:26:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754048AbdHWN0G (ORCPT + 26 others); Wed, 23 Aug 2017 09:26:06 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:56015 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754027AbdHWN0F (ORCPT ); Wed, 23 Aug 2017 09:26:05 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0MEVGT-1dmUmu094T-00FnRh; Wed, 23 Aug 2017 15:24:41 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Ping-Ke Shih , Larry Finger , Yan-Hsuan Chuang , Birming Chiu , Shaofu , Steven Ting , Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: rtlwifi: simplify logical operation Date: Wed, 23 Aug 2017 15:22:53 +0200 Message-Id: <20170823132337.517466-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170823132337.517466-1-arnd@arndb.de> References: <20170823132337.517466-1-arnd@arndb.de> X-Provags-ID: V03:K0:VFS2xiN6L9ngupkRzyPq+e+3fdqPEXGAr63cAGv9oyzWxOqk+QS wB+VOpuKzYaDNjouJIBY7L8Vb9cPFHJDxtcPH5Rr4w+A1slPyiELziWc+wOJP7ca8XbyL+l NGUKDbjEvvcUQeFztCHz5U1KCDNHJGGb7K9t27vEis1FWDi8e4L2ZuFXiTYTT0OqJRaRU7Y uvjcEZOK9cs6tdNHmlDRw== X-UI-Out-Filterresults: notjunk:1; V01:K0:1xVrwFR4yAU=:Qs30eCZ8eRi3QGj82+PzBg vBmOwL+pWSjBK0REhrwaBv1gZJ6FEoaZyWtv/iE7aTi9PqvTKYM3IriBRp5sl1NOkhcA6vQnX 6X/hZq+F9swMYtAlzYwu9LMe2oXaMxp/mXbl8VxKt1L39+nVKGxmdkVZlpYqGEAGyF9Dzp0qf kK0jehAyH76Gnnn3trBHAlBMbTM5XDAKZHEBmC0PfFkTZnNPJaaFWf0Mfn/u6xNGXbHScPuSt oltemhJq1RduqYQYgPujHSxce2az80PcJ6FYWfUEx7KWKm8GqKQG2r18wLIbvCItNeLdnVOIw oWYlOBlalXv5vWbbKDhEuqY239irAgmjjWqZ02a104iXmk0YG2ZVv5qqD9YNU/dTvDfCz8wmo 33ooFIJlVnuOVc6Oqwvt3cb6FShYML3GXSYlmMNphMKLCpdkmwLn7I6KI4v/R/BhY9OkIG7sm PaYmIidW3ocvIcqeWXpe+ZLNvF48+z6Nf9qn8QloJ+SUqkJit7kfiRZnEtHFBOv/EFmLUShrL 6q93eVkize6AIIu6MNAgFNR9ymrvy60y77CN+E/YLV/5y50Lson8aYVg7onqjypIQoAznwv/l 5/5Rz/08Loh9Iug2AgA49hB3TMycIdv4Flvcl/Pt0hKCwsWC75QuucFyjk/3UGNHkXDSk1rD+ fFm3hWz+rMIcp05hNxhkDnJd7gMmFDT4wUD+4AvPsOYk2kTgomPSoqgRQHD6AP6iHdkqDbPSi nKByxAzREkDE353cNjPu0ouO57o4vflHuknrYw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc notices a very complicated way to check a value for being equal to one, and warns about it: drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c: In function 'halbtc8822b1ant_set_ext_ant_switch': drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c:2105:9: error: '~' on a boolean expression [-Werror=bool-operation] ~switch_polatiry_inverse : ^ drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c:2105:9: note: did you mean to use logical not? ~switch_polatiry_inverse : ^ This simplifies this expression to make it more readable and to make gcc happy. Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver") Signed-off-by: Arnd Bergmann --- drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.9.0 Acked-by: Larry Finger diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c index 933d188d52b4..157395b85405 100644 --- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c +++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c @@ -2101,9 +2101,7 @@ static void halbtc8822b1ant_set_ext_ant_switch(struct btc_coexist *btcoexist, * 0xcbd[1:0] = 2b'01 => Ant to BTG, * 0xcbd[1:0] = 2b'10 => Ant to WLG */ - switch_polatiry_inverse = (rfe_type->ext_ant_switch_ctrl_polarity == 1 ? - ~switch_polatiry_inverse : - switch_polatiry_inverse); + switch_polatiry_inverse = rfe_type->ext_ant_switch_ctrl_polarity == 1; switch (pos_type) { default: