From patchwork Mon Aug 21 12:47:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Tucker X-Patchwork-Id: 110523 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp1227830qge; Mon, 21 Aug 2017 05:48:26 -0700 (PDT) X-Received: by 10.99.183.13 with SMTP id t13mr16264245pgf.66.1503319706598; Mon, 21 Aug 2017 05:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503319706; cv=none; d=google.com; s=arc-20160816; b=kavcObO5E7BDUuYLGLM8vyE0+jApn9m/4PX15YREGVcrAZZrNHGgMh2f2tb/YVg9+A 8YUZL8O45P5gjlW1gDejOaM6Ljt1xGgGMuINHfBvQ4KDq6CFaa7LLfa61SiwEDrN3bIo iMejwW4AiF/0Urz0YnzYKXdAUi48ysNEeTrGzblx3J/yjnRq1SUDNYr6CtI8CSAcnQZD b6kLe6vilPiFbOY4QtQxZet7ilgJlh26DKcyOxU2eQEHUZvGOGlmHmTwNYnYZq32XEuW ile2T/ur/fdmz2au3224W6ve9Nr0wsZCtBSuE2khQbLeDLLg26qXegN6jbMwVH1PWJZ0 aGow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Jd14yYWjpmeoWDJpg87oFIRCdDzhLTCyA6IOFbz8b1w=; b=K4TP94chyItgt/cgQ3XRm236rMMCPoTyTlI/htG/eLTzOJWEcArgTN1Xdr5tOOEICY gW+WPz7ZmHwMHPK+L8ZqN2eAbEz37MryS8+GiSkLb4tbZiteXAJjWE9aoNcK5tgWYIpK 9wHFvqIh4uAEoNFJBtki+hgR4D/Q5CoXpHOPdci42OajCt+4mwSYZPWWbtfx9x8KB6XX KLnXwX7kYCAc+E7RRZOnQfbjBqmuz1nVQhKg7L/ADXJ8R9RnwuRD9ImruFNRetmYAjqR wkxh57RaAckbqZCV0YvL60z9RE8ZUOAqed7waGRk3auBZIno65rFePSlGdTCgzWDObnP RvLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q71si7318961pfk.555.2017.08.21.05.48.26; Mon, 21 Aug 2017 05:48:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbdHUMsZ (ORCPT + 26 others); Mon, 21 Aug 2017 08:48:25 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:39584 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753752AbdHUMsW (ORCPT ); Mon, 21 Aug 2017 08:48:22 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 26CBB2602D6 From: Guillaume Tucker To: Mark Brown , Liam Girdwood Cc: linux-kernel@vger.kernel.org, Sjoerd Simons , =?utf-8?q?Heiko_St=C3=BC?= =?utf-8?q?bner?= , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Wookey , Guillaume Tucker Subject: [PATCH] regulator: fan53555: fix I2C device ids Date: Mon, 21 Aug 2017 13:47:43 +0100 Message-Id: <20170821124743.52924-1-guillaume.tucker@collabora.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device tree nodes all correctly describe the regulators as syr827 or syr828, but the I2C device id is currently set to the wildcard value of syr82x in the driver. This causes udev to fail to match the driver module with the modalias data from sysfs. Fix this by replacing the I2C device ids with ones that match the device tree descriptions, with syr827 and syr828. Tested on Firefly rk3288 board. The syr82x id was not used anywhere. Fixes: e80c47bd738b (regulator: fan53555: Export I2C module alias information) Signed-off-by: Guillaume Tucker --- drivers/regulator/fan53555.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index 60f431831582..ca29d49fdadd 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -476,7 +476,10 @@ static const struct i2c_device_id fan53555_id[] = { .name = "fan53555", .driver_data = FAN53555_VENDOR_FAIRCHILD }, { - .name = "syr82x", + .name = "syr827", + .driver_data = FAN53555_VENDOR_SILERGY + }, { + .name = "syr828", .driver_data = FAN53555_VENDOR_SILERGY }, { },