From patchwork Mon Jul 31 08:57:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108983 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp2037797qge; Mon, 31 Jul 2017 01:58:30 -0700 (PDT) X-Received: by 10.99.125.68 with SMTP id m4mr14687999pgn.259.1501491510331; Mon, 31 Jul 2017 01:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501491510; cv=none; d=google.com; s=arc-20160816; b=U80HftjU/5mhQSNVnPySkdP2lcnyEJ4Y0S8BzatY2ZE72VanlLixGR21CX4ujsrsRC 5R5mO5p6vvnyxgds1sbES6f0/0BPrEPgLoUcrXI4vuQRiMIdRPgHIxwdhSgqAjlChcj0 dP4Z2kmBsT5neR5bFJgxbNrD0lkRmMNWzvamlLZn97oWtJ4KkVBWMcgTgX4ilaBQA2p0 1KCRwWd7wkCdfSjcIrkSedju9MJzWrIP9iyKnKWkcC7IY4kp8LyLyarIrXA0ydJ7FENT Wf7AmaIdDw075aJvqBwIPrs15az8K7zpMSNO4cpyXXKEFZVjXvb+dktgy5ceQv8mSYaQ +naA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=6gNkXZoEl6JxTiuWNW8ncDM85POkn2abLvRLY1t012E=; b=qwE/itnkJykTUQgK5lc4Cp6lqP4rNye1HC9WrL9g43xi002YQLY19QGsUfHdqPzy6q 2TkdGZTx2Fag8eQOEyPu11SviPhmHih2LB+lUdHOIo/LTXT+QgaJ26F9MRxYTIqMLMwr j0euAEkAAWZRFas2pGGnQv0kSBsZUsFZN8Xbdq17wHDi5NUxWMg5DnbncrrMjxXqc2Za Fx6/7DE8TsZyDxwdRcDqCKD4Xhuu91veTelfKU/EZP/pKsGTZnTwO7BBiQGW7Qr6KrWQ QuBoiyAxhxaRKdd7qogtjUKkj/m2FPNEvtLSomUVwBrFSZKoiIBhB5EtbtYGdj97ler0 0wuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c4si10383456pgt.257.2017.07.31.01.58.29; Mon, 31 Jul 2017 01:58:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751862AbdGaI61 (ORCPT + 26 others); Mon, 31 Jul 2017 04:58:27 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:65039 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbdGaI60 (ORCPT ); Mon, 31 Jul 2017 04:58:26 -0400 Received: from wuerfel.lan ([78.43.238.10]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LsyLK-1dhvOW267m-012WaK; Mon, 31 Jul 2017 10:58:14 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman , Marcus Wolf Cc: Arnd Bergmann , Joseph Wright , "dan.carpenter@oracle.com" , Derek Robson , Colin Ian King , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: pi433: reduce stack size in tx thread Date: Mon, 31 Jul 2017 10:57:47 +0200 Message-Id: <20170731085812.361318-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:6aVxqXIpYqPxteNkY4J7RDE8U4KYX/WFyylJZw3ZhhPRtqnx2OW b8w6ULBwAOrs97XyNkGkP3b/yK6i04qiA2HEwnUCD0fGl/9AtiinfZBZMbTiqfM2n4yEh4x 4MlGakxJkyzXT8YXp/IbH+XDeqQmdlRqTWx528fPT1Z8aoreVhQAXJq/qc1M08SipqItuyT X1y3vcLRaAecSHbvmpB9Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:WkGhHYnK6Ww=:d80RVIbs7PGf/bGgyxiHkh bBqohZTyxCa/w07RvYQ8t+NDF3rx/bhZVwEPjqtcxIjWu0KkEXMG0N203rUh+qQOfNUao2WUb +V5/DVhCMi7L1rkbKuiQssa0Xbhz/i2BhvYsY/V9UcXqjF2vSC8pco9zIMn6o1RoBofjJCZQH +HDE0DIXpN8Lo3zcmzsWTH6mQWgki5nJRAezwG7gZnRwKMOK6pHsIaqqsGcg5HjUtMRb5VZ1P iQxBXnufJT74KiFHcVp+zHpNRsqXLAPewb63fg84LyPV7tssznUK+C3QnKA+3M08/4DcehJl0 UXQOW7+hQAOJXuHDVv33OenZtYkO+8OQZdxDG65bO0kcuTkNaskfDAFTyfhqViXlljyESMuBN FamCNtfRsiJQEEH5uShk5E+G2CzexzacdJJjtsrdjoul0OSrfxssxYJYyGtsfI+PQgQ7C0MhI qtAMQ78g3JELCuN32HCifNDij8iPm46eaMIABEOO3GavOAK3f/MYKxRGRGL91srDlv8MIJT+w bolQiDizjMGGVo5c1g26kJSzYMhHZVRtXqNnc6phHKacolxHTov1VJzdqZkXONDpbDoRY2EED N1RMt4yxVZUb1IqmiwGGSZM5WjO/YuH7qCjKhoRy/+D20oXwPRzNd7X0d4/PasehYrKZtyIdp ATTdEoUwiseG0SSe3XjBRH4TqqD8otkT3gMQxIqTmZa426VvxrxIC+LbICANWsk25P17u8V2s 5zhYX9iwKbIl2HW3nqi9ta357RL6YUkYcxcdCA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Putting a 900 byte array on the stack is a clearly too much in the kernel, and sometimes results in warnings like: drivers/staging/pi433/pi433_if.c: In function 'pi433_tx_thread': drivers/staging/pi433/pi433_if.c:645:1: error: the frame size of 1028 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] This moves the buffer into the dynamically allocated per-device structure. Signed-off-by: Arnd Bergmann --- drivers/staging/pi433/pi433_if.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0 Reviewed-by: Marcus Wolf diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index ed737f4b1e77..ec9811ae4735 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -92,6 +92,7 @@ struct pi433_device { struct task_struct *tx_task_struct; wait_queue_head_t tx_wait_queue; u8 free_in_fifo; + char buffer[MAX_MSG_SIZE]; /* rx related values */ struct pi433_rx_cfg rx_cfg; @@ -471,7 +472,7 @@ pi433_tx_thread(void *data) struct pi433_device *device = data; struct spi_device *spi = device->spi; /* needed for SET_CHECKED */ struct pi433_tx_cfg tx_cfg; - u8 buffer[MAX_MSG_SIZE]; + u8 *buffer = device->buffer; size_t size; bool rx_interrupted = false; int position, repetitions;