From patchwork Fri Jul 28 14:10:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108890 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp436890qge; Fri, 28 Jul 2017 07:12:24 -0700 (PDT) X-Received: by 10.99.44.138 with SMTP id s132mr7431247pgs.318.1501251144210; Fri, 28 Jul 2017 07:12:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501251144; cv=none; d=google.com; s=arc-20160816; b=fPVT0qZdFvCWYvRZcd1pNWTV0nfoHTSl3su4+i9iF/vCFiOynPhaV7d258bVfQZofo Km0Dr4rTnua1aLgBQzjMt1wVL1FJqdC7Kv3zOyrjcH+5Tdq4dHPjxLV2ECs7LOpPO2i2 /ry4pLpEFpxG3JrsxlfYzEBHbKd/JKOPA8ECGEEIYP2ULvtnke7dbEK4AKEegO/wWjKC edWrknNwgqTyPX9nYJXdmQfqCkQH9Bnt3T9E9QQ2ml/NNhIFFj5aiy8qYb1VpC7ZP02F M4XYgyHsdwRlVDdTA1+mdPqMMP+pzUax7YHm34p+eaYoVTVCRBLjm9wOcGSLefHOEwqs i+ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=H6spBpcF61iQ8t0g1kEr54L80OgPOKxuCw//F2nLhcQ=; b=uvQTCDNk9X11YItlt9D511eV4Rapno4q2gidwlLPjxpdQxCq8l0j98aM1TR+YIV2Nu yrr/2C2JHN7CLGBK6vvgWfKAoTbRX1dMgWnRxTtH6zz+xt3+7hwwCcC4JkBhBsH+oSGv J0I2ngJRrdy8zTNmABnuooGdNySHoLLd/TMvSAoowF4W6MTzItnpK43WCc/oQM6ZDqOu DS0NKwpXUKw3sTD1UQxgobrPf6SJs7+E2lrN/UwFZ0drOUcahfgsaB5sIJJRaOtFyUNr vVZAae9sKbSoD8/ZxTvaCTKSo0tv6blJpg1vBiyzCMpHuwADfNS7MDRmhmNQvNUU5V38 EDKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1si13512948pln.222.2017.07.28.07.12.23; Fri, 28 Jul 2017 07:12:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbdG1OMV (ORCPT + 26 others); Fri, 28 Jul 2017 10:12:21 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:57362 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbdG1OMT (ORCPT ); Fri, 28 Jul 2017 10:12:19 -0400 Received: from wuerfel.lan ([78.43.238.10]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0Ltibd-1dkowl15aX-0118hC; Fri, 28 Jul 2017 16:11:18 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Arnd Bergmann , Peter Zijlstra , Matt Hart , Stefan Agner , Chris Brandt , Ard Biesheuvel , Russell King , Nicolas Pitre , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL Date: Fri, 28 Jul 2017 16:10:49 +0200 Message-Id: <20170728141108.1283320-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:RiRCpkEgaga6B5H0aVWVkOElmqsWxa6zZy9W4k19b47gD77w/i7 YoWI1xUD+9aDqTw20SrgC0kxzLK1gOVnY/unH2IQFipL9N0/re1rwirtZ5/jVapVcYx4u2y y0iA0Xpz8J4HsaUlVOKPA/qi5IACdvTtpvO/6mW0ns+aY2Mhe2uB/FbdEI6YZ331UuOB27c FW0jCLw2FysKaihDNIl8w== X-UI-Out-Filterresults: notjunk:1; V01:K0:bT/qXh1YTZM=:aRWdSs5ngrKm3OQaqCiEPs GjkGLjv/3RppgigbIjcVObd5c2h1RwwjCW8zg4G3u/FSS1mW8EkPxLVfK+/KZ3iqL8HQx5J8J jS/yGgRQN9VvZN9wzTs+x3VMuhR5QjmmNAHsETCxVjPFoAGFSKqXfakhevVvnBu9gNBTCLwxY XJZoQoBlnsy9VqdZlHZe3EkDKNV+xF8jv4Gr7lQoYtbMlc+0RLIKLY0NzI9fzCcvOuZ7WcPDN Yla/6OSm16/JY9Hkvx0/Yybfdv7WDPbaOGmrWUzYkgAsFF+VhiZcITW4XhYKR0VRS9nNJN1qh E/Cthdou99R/+r3bEi3CjnW2PBQN9vBaqcHqaBoTIVKoLmveH2KBY/Uhv3qlthUQcqX7Vqgkm 8jgi7PJJMpXR1YZU4bS0n5cHlWwutyxOdt2ikLyZD9QKhPmgsvScmyWLVCabT7lhyEVkqb21I y3zNSQWrHLQvAaY/jQ2p/M3aYGTOSVJw0n0SCGXf7eZv3Tc+v8Xkb9mJaP3UmlvkvumwsG+GN yC8prMyYPLZxTe/xJQjpqdMPbMMaHQVypYckoQ0sRmLLcbvTe7zK3izlI43RIET7layLS95Km 6+ZjB4lOPI+J3hUfE3pFgk3X6E04QkGpnlY72ACmzGbXmTOH8FPdFwrtZj/Q55s1VGXF5d8dv NsMLjC50ATwrRJmYEEk4sOTqQz6cUb7DBj+7Xs3esJKthNbfmXu4qmjrgg9PWsZDqbeIXbAoK dmjv4Itj6egdEsvN73obeQpmJyP0zJflnbpU3Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matt Hart reports that vf610m4_defconfig kernels grew to 2GB xipImage size after the __bug_table change. I tried out a few things and found that moving the bug table into the .data section avoids this problem. However, the linker script magic is beyond my capabilities here, so this is almost certainly not correct. I've added a few people to Cc that understand this better than I do, hopefully someone can turn my bogus patch into a proper one. Fixes: b5effd3815cc ("debug: Fix __bug_table[] in arch linker scripts") Cc: Peter Zijlstra Cc: Matt Hart Cc: Stefan Agner Cc: Chris Brandt Cc: Ard Biesheuvel Cc: Russell King Cc: Nicolas Pitre Signed-off-by: Arnd Bergmann --- arch/arm/kernel/vmlinux-xip.lds.S | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S index a8ceec3e0580..1ebb40ecf411 100644 --- a/arch/arm/kernel/vmlinux-xip.lds.S +++ b/arch/arm/kernel/vmlinux-xip.lds.S @@ -241,12 +241,17 @@ SECTIONS DATA_DATA CONSTRUCTORS +#ifdef CONFIG_GENERIC_BUG + __bug_table = ALIGN(8); + VMLINUX_SYMBOL(__start___bug_table) = .; + KEEP(*(__bug_table)) + VMLINUX_SYMBOL(__stop___bug_table) = .; +#endif + _edata = .; } _edata_loc = __data_loc + SIZEOF(.data); - BUG_TABLE - #ifdef CONFIG_HAVE_TCM /* * We align everything to a page boundary so we can