From patchwork Fri Jul 28 13:23:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108888 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp448353obm; Fri, 28 Jul 2017 06:23:52 -0700 (PDT) X-Received: by 10.84.174.4 with SMTP id q4mr8220261plb.235.1501248232485; Fri, 28 Jul 2017 06:23:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501248232; cv=none; d=google.com; s=arc-20160816; b=JsVkdq5vkMT11Gw7ZI2A1SZayCUnC+g7sez6YeA9dZpnpGol+hLbPXX5Rq64zcznrT gEKDBPWIrPmWx8vbu4UueiLMZnjPoKRAg7cKTkrI0/I/jFM3qlHkhat1brMP0Y9stj5X eDomwRbk137517mRXRX8VbewoxDY94wkEsA3DvsIz+jJbAgdf7fcxddtQUDkF/fLSmBB 9iUyuzlHyehHwAN9ieZ4kJTsDL+8WdrMmxGNjdO/3IvW5eTkUtPKutrgVihPmPETgpzl vaQQXv/uL8J+YzqFsskltFYD3SK82vFKZwc+obpt09FQyG3HmC+S6TiW7Z/y579dAHBn VUVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=IPAOHfnMj4zYCnW14rss21jizGk2IK8c2XjM1CHW2D4=; b=pWPYvWwnbDSPx573aQpsirVrZogXCIXVEnU4+2R+4WGRqGwaURaF6W64lZhsp3JslO E4TNzwZPjGW8/Z/xlSYSaU+jtbezUzoMG1h2BIHWs4W3LW01dSmwuFiBlPNio6QGLsup qyZjyHSClMXgmOAUnKf7RDKo8SDhJeuGNM97lP6Leiu31KAXa+d18jxOX+Rw+XRpwRa8 /YqMMnc7ui8r1sQlP5AYydmuO5ZaPLRf9jdRpdTfWhnC5YrRHUK7TizOmrdo3LuIJKnc prfqf2pbbldFttkvtXfl56yARsHEGMZwBjlLlMSKA2x4oR3HPYWKM+6hk1hhN2v8QHCv j7cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si12624912pgx.597.2017.07.28.06.23.52; Fri, 28 Jul 2017 06:23:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdG1NXt (ORCPT + 26 others); Fri, 28 Jul 2017 09:23:49 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:62588 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdG1NXs (ORCPT ); Fri, 28 Jul 2017 09:23:48 -0400 Received: from wuerfel.lan ([78.43.238.10]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0LnX10-1e4LRY2Kgo-00haRn; Fri, 28 Jul 2017 15:23:42 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Marcus Wolf , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: pi433: use div_u64 for 64-bit division Date: Fri, 28 Jul 2017 15:23:12 +0200 Message-Id: <20170728132339.332897-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:tu4b29XNUsEXinjfLfaDsWneJZSb6GKfgv9LpWHhdXrE/7+trkZ fXXHMBQXuhdxoqAivFmGbZwAopcblsW2jGXWD/8NTfdEXtvwQ+AMxonxbnaMGWrhC2ZT/on JZ7crtDXfGDhnLO3jAKM8yVQ00IYcOAbVuoZWTxsYTEpQMs+CaGbGROGAV7QVbihL+Mygjl IcrI6Ct1oHCHlVQ0zkkdg== X-UI-Out-Filterresults: notjunk:1; V01:K0:kNNmCN6Sazg=:C0Ab3AGQD3nQ2zJeZ5lgtg SQGDVX5oWDBYn8FSK74RvwBfG288JAs6/aDI5cCNtt3ztHalxjLQLHXDhkl7pm3K7Ykrp+iER 4sb5RBUyI+5XTHoxkUiG0xsvOIhdqRBDu9zjmZK1rXo1J4g5rLnUNXqaYZTi9j6h88SAqsi2p RlvugnxxksJe/0R9dg7jwNzAOr/z6Oc4iBmyIlaVYnNdXpVH/3DUq+rDQUoxutIzTA08NhR6h 0BSxlFoX39h4zgmH37QQBOYBuHd1c0JUTJ9AmGp0TpcrfLM22yhGuWmzYZkDlXRlq3gFQFYRZ /PGPwz+iNgksJY0ebkS4dnCbQRQh7ndCVrwtygHHTlp9z/wS5zukG1ioZv+YnkRvPGv/VfHga MeXromG9rPHMZizEQxm8dwPlNz3035GKVhTMRQ5zCQ2+2v1geNz1xxODkqBbxIB9kdbZ32dib N2ZSGzeAWaSejPIofARHV4lAsu4AjoDVyQzVYKWP3nb88YszUDlB/Q0nW4W26BVG5oZsvlLj9 xhHoiGgF/hstSSylOqyxYpUeD7hHbvzWAiuq5EkT9QJtwjoZn7k8nAPpY8KGQ99orJ7JYwbdf EVfifi3z65HyLsJxv3jnQjyzrD7Lxhi2jKX4gGmWoe4KkNDQ4fiZx52EM2JYiCOrG0+FBmH3Q NmUNn/MgAWLE+Gp3W4N3rFWDVRtrS1I84l9XbStG6nmhovXmvBq5bwUpyDvCIkd31ivlgOk5Y WmuOQI6dV9QbBArJnDgo13zU50QbMWsTvPL2Mw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I ran into this link error on an ARM OABI build: drivers/staging/pi433/rf69.o: In function `rf69_set_frequency': rf69.c:(.text+0xc9c): undefined reference to `__udivdi3' No idea why I didn't see it with the default EABI configurations, but the right solution here seems to be to use div_u64() to get the external division implementation. Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Arnd Bergmann --- drivers/staging/pi433/rf69.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e391ce777bc7..e5267b5638c0 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -238,7 +238,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 frequency) do_div(f_step, 524288); // 524288 = 2^19 // check input value - f_max = f_step * 8388608 / factor; + f_max = div_u64(f_step * 8388608, factor); if (frequency > f_max) { dev_dbg(&spi->dev, "setFrequency: illegal input param");