From patchwork Wed Jul 26 13:36:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108758 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp811827qge; Wed, 26 Jul 2017 06:37:23 -0700 (PDT) X-Received: by 10.99.227.81 with SMTP id o17mr891864pgj.41.1501076243862; Wed, 26 Jul 2017 06:37:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501076243; cv=none; d=google.com; s=arc-20160816; b=AMs5eP1MX1AR6iayLxQZ9/HCUivFdGDJ6ImVoKBkhKn+9vU+/VcaskmdbFF1reEu7G xGPAM3RiDKTbSikUS1BrGty7s3Mx1EaKkGdxZz32orpi0v+fLzfro9H8k7NwB7BAMn60 473e8qFDM1gcHpx6ZY8/Efb7kOwmTIcW1S6zDHBdxrbVbvisXPpS8PXE60wBIGyeSahu wWpEd4GKc3KcxmcLB6RNtoM1mj+goMaY0qgqKmvLFHw1vGbvoCefEwuf3HdC/GQlpjgK YN6n0YxaT2PJ7HLRuGE8bda4qqeB8T3RkRU2vGAJA5IZrnkcaq+4bIG8zOK4l/BUkBAv 5TAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Ljf5dtjJjumfT0+9ZiUYkSv8qtoYzvMct4CVIsrrnwE=; b=AU+LBPM904lz3bZCs5qDjyLSp1AozmzmZorg5O8jkR9sWgm6CaIHVNxbD8d55q7efW SVaisdHmTV8mW1w7bTwVzvgv+/OZ7IuL8HPF9y7BuLU4TZZM84cbySe4VUXKNK27WG8W mnPwcvU+ceDggSpgrHjCj/bxXKvvTU2DuFZCCw8sKqJ5JwMAGZtdC58lBevWClU/ue+e 5asb5WS3ZPxiN0qBqsLsYTZoMDARwH/9hdsWxW2Natdvd39wgtXacfFPhvzqXvMEIdvp A18ephQgSlgeQOii+DVKxD0Jz4ElK84L8k0WdyZnjIYxqL2w3/G3O6IWbgweFLcF1MOL Y11Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11si4358203plf.1024.2017.07.26.06.37.23; Wed, 26 Jul 2017 06:37:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751848AbdGZNhV (ORCPT + 26 others); Wed, 26 Jul 2017 09:37:21 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:56119 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbdGZNhT (ORCPT ); Wed, 26 Jul 2017 09:37:19 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0M36tX-1dtor54BFP-00syET; Wed, 26 Jul 2017 15:37:01 +0200 From: Arnd Bergmann To: Andrew Morton , Masahiro Yamada , Michal Marek , Boris Ostrovsky , Juergen Gross Cc: Arnd Bergmann , David Vrabel , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v2] Kbuild: use -fshort-wchar globally Date: Wed, 26 Jul 2017 15:36:23 +0200 Message-Id: <20170726133655.2137437-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ScL5PYR8QVDPoRvmKNSvkXMY3o6MZtRRX/EpzTLtS0tUY0KIvSX aEmesN7KDkPjjDBnIm9HpXtvZPAYFZv4LV0HNQLnRerzkU+vVHN6vtKiqpxhgdA7I3uiCIr F4aVZvPNWiYNKv9uPnZdsbWSs1Mt1qtiWtG/yOxPsYrNJ5b6/RVuHkSKQ/H1MrFyaFpyaFc ckhHOtGCfXnbIPPdooCBA== X-UI-Out-Filterresults: notjunk:1; V01:K0:xbN5uHg7d7A=:JmsBsyNMFivS05LrEM35U/ 92wnsyuYgHgSEonR8+eRkVwLJxhbtgVZYJQmPl1Lw2dXxTuSwwGScynLt7vJC1B6KLsJJyFmd 2qQygZ0mQ3Pwv6j7myMAjadppiYt73IT3sdOBQZYbsr+1PJbZ0ZLPkT8QElazXKo1YYG0hrva LhV1Bg4amqHPTsh84sp4MD15J/v4TrZDDa1KuWzUTnneUMFVf2yGBdW94gMeE0STHGpqvh9aT dOaZV0d2GLdDQmHjTsgt4ImxuvY5VvVzsqAiWI+/nI8Yq0ytPIeViYr2dcoJj7wY43UBL5wHS vIiZ0qhTO4J6kfEddbmq/TC+Qwr5a024VfYJsMseNPmQ6ODL9iT1WwubDNpb5lqYu2HI/wKld yaY2i0UfS4eoWD0iDWvTf+PHv6vEdCNMxewgxzV9OVxyEMRzxoklkhBg9VuuLrfqyJ/UOflX1 7+uramquZtKfsdt1BTwdZ5M1k8s1nYUgY/9bj3Bq2LfFxTzSbqii4ihki/7OGEjCOfnFA8hh4 SL8Ci9cYoWlgGCZYvUBSzrHFjmlw512NsCyrZcp73yN4auHSRV/GkUiod08cibrDb493+FxDZ Acxufb2yDJJ6wd7RBg9TLUV7lu0PlVoLLlUiOrohOY3xCNjhlsPkIoidPplSPh6V8o74q1kpu DyjAn9QgypExtbTs/OGlEZqqqbGYcAjHYLohDRhQTrMqi17OECDxFYa8bfzYG97m6V+l2BqgD mcGUlSvMT/PQLcoByrDoqivtxYweHXoFqthJfw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A previous patch added the --no-wchar-size-warning to the Makefile to avoid this harmless warning: arm-linux-gnueabi-ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail Changing kbuild to use thin archives instead of recursive linking unfortunately brings the same warning back during the final link. The kernel does not use wchar_t string literals at this point, and xen does not use wchar_t at all (only efi_char16_t), so the flag has no effect, but as pointed out by Jan Beulich, adding a wchar_t string literal would be bad here. Since wchar_t is always defined as u16, independent of the toolchain default, always passing -fshort-wchar is correct and lets us remove the Xen specific hack along with fixing the warning. Signed-off-by: Arnd Bergmann Fixes: 971a69db7dc0 ("Xen: don't warn about 2-byte wchar_t in efi") Acked-by: David Vrabel Link: https://patchwork.kernel.org/patch/9275217/ --- I submitted an earlier patch in August 2016, simply removing the flag in xen, but there seems to be no harm in enabling it globally --- Makefile | 2 +- drivers/xen/Makefile | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) -- 2.9.0 diff --git a/Makefile b/Makefile index f1533423094f..0fe63a47fd52 100644 --- a/Makefile +++ b/Makefile @@ -396,7 +396,7 @@ LINUXINCLUDE := \ KBUILD_CPPFLAGS := -D__KERNEL__ KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \ - -fno-strict-aliasing -fno-common \ + -fno-strict-aliasing -fno-common -fshort-wchar \ -Werror-implicit-function-declaration \ -Wno-format-security \ -std=gnu89 $(call cc-option,-fno-PIE) diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 8feab810aed9..7f188b8d0c67 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -7,9 +7,6 @@ obj-y += xenbus/ nostackp := $(call cc-option, -fno-stack-protector) CFLAGS_features.o := $(nostackp) -CFLAGS_efi.o += -fshort-wchar -LDFLAGS += $(call ld-option, --no-wchar-size-warning) - dom0-$(CONFIG_ARM64) += arm-device.o dom0-$(CONFIG_PCI) += pci.o dom0-$(CONFIG_USB_SUPPORT) += dbgp.o