From patchwork Tue Jul 25 15:38:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 108658 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp710521qge; Tue, 25 Jul 2017 08:38:36 -0700 (PDT) X-Received: by 10.84.130.46 with SMTP id 43mr3023417plc.101.1500997116887; Tue, 25 Jul 2017 08:38:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500997116; cv=none; d=google.com; s=arc-20160816; b=bsZGee7tws4YwE1mMBYsEwfipRhhy2PCZdHEbWoKA7OdKIM83nRkuzGtM6PbgV+2zU VnsP5jgPZbnlo2eZjORdGSKVwFUO/NIM8006P7cxtOZFARZ2tFWPQlvvOzS/J7JTmd86 q8CP97fZgesvM1bQYhv1E9X+3ULJDSuawpKHFgScwshFuOEFhahaLNP39VfNxiTkoMa7 bcJDkGKJa8xJIUS7NV62gW1nGqzw+oNAJ64bDzX3AX6EXhV9lyhZI9abbVms7iwR78m9 bO02YTA7zOSf0IXFz14GZ1iDwTjF8jt2eGW5WJGML3NNJbxwAq0coBsbpekCwAAuvELj zovg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=n4QLxuHUCwitN6EQZk4FC3Wur0Tli/lyjC/TayIdJBM=; b=HaDMMZfqjUaWh8w7eutjqO9j4MKIPvmKpJLvtWGQGyZ18TlxBPPeT4XLpV/IxC7hpk iRqeEuTBjw/66D89GeZHUOqzYc8EvSMnhvfwrI4FO6PIQwfiqUyYWlwTxSbK/lYRwR0Y GoNYt/ez1P9V8QfhwlkxZmnPL1FanGDFu0vK8gAMEii18j+6wmjq0/aR7hNXdj0FyzRR NfQvg6CrooRZH88iPxPikePI4QnftRi4AkZ67Ksc0Zlncln08mbvPbA3H6OlhmxOCs6R hEt6RcZVb0PrL2Vy881o7jdolFMOEVTVBeHcPvMNpvyet/gEQCUEpAQ9EqCeCo60IdY9 fmNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17si3336642pfv.598.2017.07.25.08.38.36; Tue, 25 Jul 2017 08:38:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbdGYPie (ORCPT + 26 others); Tue, 25 Jul 2017 11:38:34 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:63048 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbdGYPid (ORCPT ); Tue, 25 Jul 2017 11:38:33 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lvk1k-1dfaIR07OG-017UVp; Tue, 25 Jul 2017 17:38:27 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman , Marcus Wolf Cc: Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: pi433: fix Kconfig entry Date: Tue, 25 Jul 2017 17:38:05 +0200 Message-Id: <20170725153825.272975-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:6RZhb2cG47UUulyxMzheFPTUIb68zEC79UUxkMjvLdHXabxYCT4 0C8N36sZ0/B/nVbgp+E15XBi6Aitb2pccjccPeshkxLt9M514doUnUxMeHy6j3/pK/8qJ56 lkNOxzrdXw1vGKtEFnIC8umbvRv0t76/GpHaHWTzKCweaCLpq1sCn6vPL6WPEMOZCOgju4F 30REV5Wy14NOHo10xpLog== X-UI-Out-Filterresults: notjunk:1; V01:K0:zNWA4gkRU80=:lxoLnSU8kMbJVKhZ9QW2mp 6oNCOAS2IWbtgMCX7RpuSyc0scUhDBO4z9WaAfxXZavzyxVx/eSoGgzf7SbEWC+vHJqeJ0E38 V4JNC9t8P3/nKeObF9ncYqHL32lCjMEZ+UlTJrFliLChCzrPPWjmnJrlQv/ZiUbr03PgeulF+ cLg3YXXHEEYbP2rfTqdw5saX4PeQXlN/cahcGa3dJioCLeNUNTpAUv7uR8B7Q9LA96nNghp7o QrdfanN+ad8NJwT8YaPAj7ueybE/0ud4V4rKEZb3EZKEz+WASQeO+Y8jMVhcXl7ozrcb55ZaR dXeO7764Y7z6SUHsKEQN50a/xSAJNbY1BylB+2m7jD07rsUEicUktCYNAqKBoTNpzipgcK59a kfmfvGSMIXubmWsdYYYiAzm5Dvvw6XXciFJO7VtoWRD9yZzGG4O9IxqiOJgNNFzAA1Faw/ouw zVt510b5kcgoPQDcRCf44fKmQRN6hpMgibGdMI/HOAs4gvQLz53/VU9f0XRe+Rh7s62rSybpU Wpkfz7FdSNIUja1LqN1kif40IkDUrjAJEOWp0nkArgDzfWTArTi6WkQMuIi++i63DWuIvHl8L PtbsgqfyBlYdP1Ce2ltSt13OP1luw6muppM+gsg6VzpGMaCgi/4HbKakPCIrzpSulw5iwqz7S NGx+LQBWT7GpRW8pf8uOC8N0H3X2G/d0QNqUNoUVBjVG2316t3vQxl9rs97/Cg28jOvvER3Bo bVYnmSfxT185SUYDIdMb+ld/4ei/xo9ncMX9JQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I ran into a build error with the new pi433 driver and CONFIG_SPI disabled: drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' drivers/staging/pi433/pi433_if.o: In function `pi433_probe': pi433_if.c:(.text+0x1d28): undefined reference to `spi_setup' drivers/staging/pi433/pi433_if.o: In function `pi433_init': I'm adding a Kconfig dependency on CONFIG_SPI here to avoid that, and since I spot two cosmetic mistakes in the entry, I'm also fixing the whitespace and remove the redundant 'default n'. Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Arnd Bergmann --- drivers/staging/pi433/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.9.0 Reviewed-by: Marcus Wolf diff --git a/drivers/staging/pi433/Kconfig b/drivers/staging/pi433/Kconfig index b2716b85d5af..2fd07991c871 100644 --- a/drivers/staging/pi433/Kconfig +++ b/drivers/staging/pi433/Kconfig @@ -1,16 +1,16 @@ config PI433 - tristate "Pi433 - a 433MHz radio module for Raspberry Pi" - default n - ---help--- - This option allows you to enable support for the radio module Pi433. + tristate "Pi433 - a 433MHz radio module for Raspberry Pi" + depends on SPI + ---help--- + This option allows you to enable support for the radio module Pi433. - Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi - or compatible. It extends the Raspberry Pi with the option, to - send and receive data in the 433MHz ISM band - for example to - communicate between two systems without using ethernet or bluetooth - or for control or read sockets, actors, sensors, widely available - for low price. + Pi433 is a shield that fits onto the GPIO header of a Raspberry Pi + or compatible. It extends the Raspberry Pi with the option, to + send and receive data in the 433MHz ISM band - for example to + communicate between two systems without using ethernet or bluetooth + or for control or read sockets, actors, sensors, widely available + for low price. - For details or the option to buy, please visit https://pi433.de/en.html + For details or the option to buy, please visit https://pi433.de/en.html - If in doubt, say N here, but saying yes most probably won't hurt + If in doubt, say N here, but saying yes most probably won't hurt