From patchwork Tue Jul 4 12:37:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 106963 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp953658qge; Tue, 4 Jul 2017 05:37:32 -0700 (PDT) X-Received: by 10.99.44.68 with SMTP id s65mr10738089pgs.101.1499171852456; Tue, 04 Jul 2017 05:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499171852; cv=none; d=google.com; s=arc-20160816; b=s9zjUwst5QbzRiPEbmzVOoZt6flUj5BLZ7a9NAAOJ6Set8mwW2OLvG+sLsiNJIEVVz IKnEwINbuTa3D1zkXVBKhvun4JseR7Cs077IiScqiiW/qRjJfNO8xEd+rx4NOUe14nXn Xfj9VIBRToMSHUQHHueF6AR99r6045OUAHDboxgXwTeteCDHyLoQaDclK1vYR3pEmB5l UX+rcZFLPngcia7zwOmyBnRZY6GJ5llZzatAja7Agh/oVpqQfWAOJCyo6TtKl/ys2Ec0 S30cfwWjnM3TrUjrKtT+Pyi+Pwm2t6Plk5reg+00QoOhcfRdZgHVX0r7wVg6z8iPHwfb 3p7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=+C6HwbQ6tPzM8eyyyd39lBoAHX5CgaemnRJ8WT8YEdw=; b=rr3BhBK/eVfLdnw7YcfSzVglLnnTdSGnbakl5TvqRXvbhxyzX2/OjBBXRjDR513age Ik5nImlONjyPssY1SpBnlyvDGKa4k+soPMi2g+l+KSaX96CHxgj7AECj1X2Lm9owCZ5b UXangFb3ph26b5JGT5tjeTP1JGpXp261vY5QqBj8OGvDm1/pE2h4kRHMzevmRiEP7NIG EOYMXArAxa7RdWnaA3IPcR0RVqC1uEWHZUTFzzroCRtry5lamM2bjxIBHb3L6iL06Vs/ paYofBCuYcFKgCo3xhbY36k9/bCFakhk267Jl3K9anIe/XTagA4VbY3Z/8wv0ppPbIU8 oCSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m63si15248459pld.547.2017.07.04.05.37.31; Tue, 04 Jul 2017 05:37:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbdGDMhY (ORCPT + 25 others); Tue, 4 Jul 2017 08:37:24 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44966 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbdGDMhX (ORCPT ); Tue, 4 Jul 2017 08:37:23 -0400 Received: by mail.free-electrons.com (Postfix, from userid 110) id 76FDE2090F; Tue, 4 Jul 2017 14:37:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id 3AA5721D3A; Tue, 4 Jul 2017 14:37:09 +0200 (CEST) From: Quentin Schulz To: kishon@ti.com, maxime.ripard@free-electrons.com, wens@csie.org Cc: Quentin Schulz , mylene.josserand@free-electrons.com, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] phy: allwinner: phy-sun4i-usb: Add log when probing Date: Tue, 4 Jul 2017 14:37:03 +0200 Message-Id: <20170704123703.18916-1-quentin.schulz@free-electrons.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When phy-sun4i-usb's probing fails, it does not print the reason in kernel log, forcing the developer to edit this driver to add info logs. This commit makes the kernel print the reason of phy-sun4i-usb's probing failure or a success message. Signed-off-by: Quentin Schulz --- Nothing new in v3, the driver has just been moved to the directory allwinner so updating the patch to reflect this change. Sorry for the delay, completely forgot it hadn't been merged/acked back then. v2: - removing (from v1) debug message when devm_ioremap_resource fails, - changing dev_info to dev_dbg when driver is successfully loaded, drivers/phy/allwinner/phy-sun4i-usb.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) -- 2.11.0 Tested-by: Mylène Josserand Acked-by: Maxime Ripard diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index bbf06cfe5898..3bea17b9405a 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -653,19 +653,25 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) data->id_det_gpio = devm_gpiod_get_optional(dev, "usb0_id_det", GPIOD_IN); - if (IS_ERR(data->id_det_gpio)) + if (IS_ERR(data->id_det_gpio)) { + dev_err(dev, "Couldn't request ID GPIO\n"); return PTR_ERR(data->id_det_gpio); + } data->vbus_det_gpio = devm_gpiod_get_optional(dev, "usb0_vbus_det", GPIOD_IN); - if (IS_ERR(data->vbus_det_gpio)) + if (IS_ERR(data->vbus_det_gpio)) { + dev_err(dev, "Couldn't request VBUS detect GPIO\n"); return PTR_ERR(data->vbus_det_gpio); + } if (of_find_property(np, "usb0_vbus_power-supply", NULL)) { data->vbus_power_supply = devm_power_supply_get_by_phandle(dev, "usb0_vbus_power-supply"); - if (IS_ERR(data->vbus_power_supply)) + if (IS_ERR(data->vbus_power_supply)) { + dev_err(dev, "Couldn't get the VBUS power supply\n"); return PTR_ERR(data->vbus_power_supply); + } if (!data->vbus_power_supply) return -EPROBE_DEFER; @@ -674,8 +680,10 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) data->dr_mode = of_usb_get_dr_mode_by_phy(np, 0); data->extcon = devm_extcon_dev_allocate(dev, sun4i_usb_phy0_cable); - if (IS_ERR(data->extcon)) + if (IS_ERR(data->extcon)) { + dev_err(dev, "Couldn't allocate our extcon device\n"); return PTR_ERR(data->extcon); + } ret = devm_extcon_dev_register(dev, data->extcon); if (ret) { @@ -690,8 +698,13 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) snprintf(name, sizeof(name), "usb%d_vbus", i); phy->vbus = devm_regulator_get_optional(dev, name); if (IS_ERR(phy->vbus)) { - if (PTR_ERR(phy->vbus) == -EPROBE_DEFER) + if (PTR_ERR(phy->vbus) == -EPROBE_DEFER) { + dev_err(dev, + "Couldn't get regulator %s... Deferring probe\n", + name); return -EPROBE_DEFER; + } + phy->vbus = NULL; } @@ -775,6 +788,8 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) return PTR_ERR(phy_provider); } + dev_dbg(dev, "successfully loaded\n"); + return 0; }