From patchwork Fri Jun 30 15:47:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 106722 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp2499516qge; Fri, 30 Jun 2017 08:48:54 -0700 (PDT) X-Received: by 10.99.147.19 with SMTP id b19mr21985011pge.154.1498837734687; Fri, 30 Jun 2017 08:48:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498837734; cv=none; d=google.com; s=arc-20160816; b=qY35ahLALHVPhyo1b1g9OQGcIbijfQ2tfAsI5yNd5nLvKXLu7MlEliWlgouv3nCh4X tItn4zArKydHf1/IKP3W9GvR0QDoh6G+hHe1IHVB+dSVTROxgVotZCJfADyGp+/PJ/Cs KFoDUjbhPwvxHG3HQIiv3COHkcx4c7vuqPb9Vll5nebQFqnWfoSpv32/GGpUY/19a9sJ /LqO3FFUbnB6Qlyy/0Q8jWEgJUA2oOWYPPNF5AHCz8K48wxIVvJY7cl3YEilpITa/HKX eYEuGhy5M/ZWUbH6QX3xgsNmesQvcCp1Yoswp/nwOQZ5pgmgDJum8CVkMym8HzAGiHKz tIbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=rjJFEsHed5wU9w53+34CN3mLiaLLblkUng1T6j3vDs0=; b=aThlJhyPN3WTK8j71JzmOku0I0WCbEh3iBcOOhZ6JuvJbf+eYC1iGnDLBMFBPiAf9H /e1rb1t+0W9FAZwLELFZH0gxQIbrHEjFRm2C7twlj4ReiZp2+8bEFQvGqKIFc0M2rTD7 mZn5VEaOsxynWrt6XroqEI33eTTxT6DYZqM+DxfdX0MXynkfE41a4HkQNQty7QeUCRJS cQSm7Z7/z+5eQ0xhbTEsU47eL9x1wQbV/sMkFe4jmAxo2Ks5AMISmGx43cmMaKd1zSg9 pIHabFDOKRWQSPWtwFjNuczwM4GPOGzQmz9lwRsEl3arv5ylI2fXAL2Yaiea4T3U0puj /g3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5si5876191pgk.27.2017.06.30.08.48.54; Fri, 30 Jun 2017 08:48:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdF3Psl (ORCPT + 25 others); Fri, 30 Jun 2017 11:48:41 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:60117 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdF3Psk (ORCPT ); Fri, 30 Jun 2017 11:48:40 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0LsMjU-1dtbrv11ey-011y2z; Fri, 30 Jun 2017 17:48:35 +0200 From: Arnd Bergmann To: Andrew Morton , "Luis R. Rodriguez" Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] kmod: add dependencies for test module Date: Fri, 30 Jun 2017 17:47:44 +0200 Message-Id: <20170630154834.3689272-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:OT3L9mupzcwqWzs/XGUPlugnKW2R3HG0mJbcugkKPYG8p/79Ugj mCcQFsl/HfG2TNwfQ+P10nrIPLUTqbSmH36Bsk6ugfFsFjIzbq5UbZal4fzifgPFEDZKv6/ UFiGP83a5VTaEYeOlOYYfT5HjJbmuyLDnQ1m9eaf5Fz31/AtwvA1yIeWGgBM3ePdzeFoGIV cxk2Cyl4BAov07ZLiHMag== X-UI-Out-Filterresults: notjunk:1; V01:K0:xfFOcZSvkCs=:DdnVJct0YGxe2uyygK1DoZ t1j0e1gLPRe+hpDaaJICMhfUmgbGmv6uNSom21P1gAvrRxTIJ0NuoXjfL1ClSlUUwG45hEpif /SLAjYwjqcgzjMeANUh60t9ByUBhYQ4EkDP1aXmyVUr3LBx9OzdyaXoyzo0WJI/NoCxEefWTp ViDIJzGAAUlRviHbmp0DRU1EL9iuprNv/6YjyR9qvRemWeG2T0K/NVfLemIuwLAdSZoGFy9nV R6+nItJwb5bCTO+SFf1TUBncm9OvbDo+B9T05CVb8cr7g1qJWXkpXy3GRm8jtTAOuw1aOLG98 jGXbXx1xSsWpT1b6z0/fAo/GgjmR9eN6dO+EF0o1eQt0w09Cs6m9qaPbf3rWZd9VwH8xtZ2cw WUsjLp2slGSaoIIGwYYn0Nnbh/r0CDySMZGZC3Rw9MbQrLf2PKBOahkMRp6Chw92Cim/OUZTJ s17UIwocl3zKcvdLYKkHBkU4hch94BxZKgcKkF7G2248kqAz8JeyZnhWIM+3mDZIO9rpLmKXq aup0Utc/mNLC1vtb0sq7YhOrTWKlcYVcxXmGlUiEVFS7O/diqEUwugFjfjFguRKtwpv0z/v3J Q638y5r0gNGxSA+Ji7EyqKxgtlTV13h6GM00zlqd+qUo3SsPXWPM+Y7yG3fSf2UugelNcSU+k pfn6majm3XhDnx1ohU22GwF8Cqdu+5H0OfOReAoHhZykzHZAFyeBW9skseooCxnzC3iw= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When we try to 'select' drivers whose dependencies are not met, we get a kconfig warning and undefined behavior as further 'select' statements in those drivers can not be honored: warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET) warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF)) ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined! ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined! ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined! To work around that, this adds the dependencies required by the 'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing that we can always enable those, and fixing the 'randconfig' issues. Unfortunately, there is another problem that I have not found a good solution for: If any of the three drivers are built-in rather than loadable modules, then the module load test will later fail at runtime. Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader") Signed-off-by: Arnd Bergmann --- lib/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 Acked-by: Luis R. Rodriguez diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 411cddd713c0..0f7ba738ef7a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1883,6 +1883,8 @@ config TEST_KMOD tristate "kmod stress tester" default n depends on m + depends on BLOCK && (64BIT || LBDAF) # for XFS, BTRFS + depends on NETDEVICES && NET_CORE && INET # for TUN select TEST_LKM select XFS_FS select TUN