From patchwork Thu Jun 22 17:13:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 106231 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp233614qgd; Thu, 22 Jun 2017 10:18:04 -0700 (PDT) X-Received: by 10.98.200.214 with SMTP id i83mr3707769pfk.144.1498151884469; Thu, 22 Jun 2017 10:18:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498151884; cv=none; d=google.com; s=arc-20160816; b=jEGm2w3iSMmkco8IbydAunI8Ulhe9p314fwB8cCtKAX5u1eYbxdcA5r2RpKn7BmRCq NDQ76/BtJKMb5MCHvR+7en1qzwPH3RP9HmX6FiutXuK7Lu1tpIFEQPrMH/s1mTIeQBxb JG9Zp2yXo7bGJWcE3EE9fqvsdmsTaHBpcCdmfXwmXe3jlGrQH0PCEUGQ2PIZrMDOggs9 edLtA/I0jGUFRKfEiRdgLBU1vCJT3wveufw+z8cxh8PbMJOTTw/UXuIWGcCO0O9q/2Gw Dl00CoxqaRLk6IFw4EkXtB5t2GlephPxeo/guKQ5yNbBhZMPaum93+0ypERVp+rTMwSH ArPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=mPgebXo3tUwXrrNvS7DgVzS7u4fsVq/wNdZAkwRSiNk=; b=X6KwlzwGJs67/g1KScrnR2BlDkY4MECSAkWYs6xeJgSR12xM73jlPeXsAavWWXPXF7 t7Y1+EfRZO05zJ0JSBW4Fe5tvQlftGjaeErUej8qWzHdgtQVWzpsGvkZMH0nnXvgJxgm wGOgnnElDIZxB1JkmHw4Zkio8m1H5ARP+lguUUGr+bMbiTnUilWUo0AufWEmm6tRnV0R VC4T0Rnnp4sHYXezC6sesdYK1FYe/Dda69HdIjW/OiC32EdyE0yJgKwbqlJjKxf5EgMS BJ98oRmtC9sNRVH+x4bzB5Jc7yF/N0ukwP8s0CNyy/0pPi/aK/UgCfYPGpbuJRf+zDnL t8jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si1518487pfi.173.2017.06.22.10.18.04; Thu, 22 Jun 2017 10:18:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753839AbdFVRRw (ORCPT + 25 others); Thu, 22 Jun 2017 13:17:52 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:51271 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbdFVROm (ORCPT ); Thu, 22 Jun 2017 13:14:42 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0MLRLO-1dNXRt21je-000gRt; Thu, 22 Jun 2017 19:14:07 +0200 From: Arnd Bergmann To: Andrew Morton Cc: kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Andrey Ryabinin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arend van Spriel , Arnd Bergmann , Masahiro Yamada , Michal Marek , Kees Cook , Ingo Molnar , "David S . Miller" , linux-kbuild@vger.kernel.org, Samuel Thibault , Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH v3 06/11] r820t: mark register functions as noinline_if_stackbloat Date: Thu, 22 Jun 2017 19:13:50 +0200 Message-Id: <20170622171355.267192-7-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170622171355.267192-1-arnd@arndb.de> References: <20170622171355.267192-1-arnd@arndb.de> X-Provags-ID: V03:K0:qv1cqBjhaf9wHHUE0q/VNqx8wJHVhVYY5AHiOhYuaEwxv22RIeP RITIVEuJt7pm6aUmL//LtkBEdJ6fOOKoIf+X/8uAtrSYiGv3+ykoLuP9YmkAbvmqBNZ90uS dFSdWuvkH5JAlOTy48y+FiW7t/h1CqDienD0jyy8TgdlkBEhAcgKGC4n14S60ah5EPRJANv sEcLv6q3NcICZtQgtOL2Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:/F4OELOyJVQ=:Z1PByIg/P+PqYNKOvPEDfw nveR0iLzLMHVGqSeKjx3+DneX7gDTRRVI+FEz9FMOCL2RPK9OeMOCtzHJQegAbF2tpfaqMbLe jn5cW9EDR0G7W3IGDmGbv9tRsmiGBEOkBkppk1BmXe73uO3DuF6toFezk8LTKSwl7nzf/fK2F wTDiiuID3aTjSW0ZmJxz/HeXe0/YvRWjocjb0dsNkSXUOmKVZn7NkEU2fLu70BvfLZnUJ6TgU NeOnMizN95d6ysg0c3KpCe4s9qVrw4SwJ8lbGtf24nyh8YfOQvaxXWKS2n6bs5bUW2QZtaHaO NPi9A+2wP33Ops2s4QUj0Hr0ZqpvCmcvn8Tpoe02WvBvjN+502A8HpUHnHxErfWp5mpa26f/7 +n2hK3xOz70hdNdxrBiSm6dtlgM7gXSPCaF1NdoRtamX0gxmELWy/pAhcxS+Y4Y9J7Zku51Un 0BzfifAFs3qhqgqlMu/k1qNatH9qY4ETIWg5S1FAvNhjTWOG11VSgWh2H9WGbw458VPFwjwdp bhwJt4Ap2qkPtXdDCZWcZ3SqNnxROaREmhAio1BRz252BpHJoGKywQzGnabt0naUdQXGrjBNq uS7gN90hX+jj6G1z25J0MgJ2cUIS8MCvUfQ7/OKQomc9KNJGF7U4HINukHPBrDTinn/i4a5iU qihb9zQ01ihoIj4ZBVZfZv/dAszs9pM4/jOFP1aLhSD55yYC3tK9ZVeU888TgUuD6NrU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With KASAN, we get an overly long stack frame due to inlining the register access function: drivers/media/tuners/r820t.c: In function 'generic_set_freq.isra.7': drivers/media/tuners/r820t.c:1334:1: error: the frame size of 2880 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] An earlier patch I tried used an open-coded r820t_write_reg() implementation that may have been more efficent, while this version simply adds the annotation, which has a lower risk for regressions. Signed-off-by: Arnd Bergmann --- drivers/media/tuners/r820t.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index ba80376a3b86..a26d0eb64555 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c @@ -396,7 +396,7 @@ static int r820t_write(struct r820t_priv *priv, u8 reg, const u8 *val, return 0; } -static int r820t_write_reg(struct r820t_priv *priv, u8 reg, u8 val) +static noinline_if_stackbloat int r820t_write_reg(struct r820t_priv *priv, u8 reg, u8 val) { return r820t_write(priv, reg, &val, 1); } @@ -411,7 +411,7 @@ static int r820t_read_cache_reg(struct r820t_priv *priv, int reg) return -EINVAL; } -static int r820t_write_reg_mask(struct r820t_priv *priv, u8 reg, u8 val, +static noinline_if_stackbloat int r820t_write_reg_mask(struct r820t_priv *priv, u8 reg, u8 val, u8 bit_mask) { int rc = r820t_read_cache_reg(priv, reg);