From patchwork Wed Jun 21 22:06:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 106136 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp2154965qgd; Wed, 21 Jun 2017 15:08:20 -0700 (PDT) X-Received: by 10.84.160.235 with SMTP id v40mr8801441plg.91.1498082899938; Wed, 21 Jun 2017 15:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498082899; cv=none; d=google.com; s=arc-20160816; b=dJKzcTzvdP8eZudLMkmFG8vtqGOAikS3UkzDbDbR+bCbyIDkf0NN4sMYRGy4pQ0Tp7 5FjTOPhsAKXlw8gqE/K5CTPcQUUx87ruPOIX5nWu7LjPSmR/X1V5Jeo86WigyJ4hNKeo 03NAKBxI7iymFIsBn33uhX5eadhjAzNTeZRYxTitBxCezBvIS28eggPjswTEFNAh8Xsh zvtp0r+CDQjaJzJq7Cy7Q7wDEzpCxKHsGqp1R4sNU6STDW4rjVt9ccZ9h+ce26psI8jB hLbTxG3D5AoqXQNiX2mPYACAGXVmhKymPzaUbzbYaf6XDRDTInQpEg6xpRyZRK/Ejmql av0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=fVLju9IcmqaVPAzqay6SQkcp0NHX8nCGG3XwbJHjMdU=; b=cdh2OYQIcwWUVCWjVw1vtO4wSSoiPXZQN2Kd/mW1Vjy2I87qd2B1Tt3kz1nrq+xitY Ak2PvZfrjtTXI/CMUncHgN8pdsGYLPWyyPf19CHfT25LrH8cMdnqY8p8DWpE7vo3SQaZ r2reOp4LlCkp2rBjGsVoLnGfSwpYKfARr5SHtEJINMJEetX3j4JutpV++eWtMiQD/O6x 60DxbPl8mo22YkqLS7+eJEy0jmUQ7RMni3ufDI8qIeVAvs8JL++0/qigvU3UaKkFeTiI HSwiNtLtWqnRfiGIZDp4zp1KZuNZinBMW39bNgxcgwUEyMLZVFOZORMxJxocjX+2cHy5 yWIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si15572511plm.352.2017.06.21.15.08.19; Wed, 21 Jun 2017 15:08:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbdFUWHw (ORCPT + 25 others); Wed, 21 Jun 2017 18:07:52 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:57834 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbdFUWHu (ORCPT ); Wed, 21 Jun 2017 18:07:50 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0LZl8O-1e4Vzj0IUW-00lU3x; Thu, 22 Jun 2017 00:06:59 +0200 From: Arnd Bergmann To: Florian Fainelli Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Kishon Vijay Abraham I , Andrew Lunn , netdev@vger.kernel.org, "David S . Miller" , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [RFC 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Date: Thu, 22 Jun 2017 00:06:07 +0200 Message-Id: <20170621220626.46691-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170621220626.46691-1-arnd@arndb.de> References: <20170621220626.46691-1-arnd@arndb.de> X-Provags-ID: V03:K0:sGozzXOWYl2thooS4xjQoRQW9gcQB+E+H0Uyjyz6+QmN7ZG/oj4 UnQCHJaVK2n5SXwQp7bw0FU79lsSWubi4zmXENPieGfa8RiFO7x94WN8+jvML9IxYL7FK84 Tragki22rHmjyAKRn253jGJkiX3euXEtx86ZVuL4s+tt2FiaZZLVwoej1YyPRM+Ru3vgAYz yecYfSooZlK3Q1rucnSOw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ss5uy2t86cc=:r7vHrVdhps4UB/OqoNOFMQ R96Z66Og2EdFy1P3yxd9Vb4GJVDJrLdRwk0lNo9Y5pdRihe3rcV5Ezp3LEmBaoSrGHk/5/GKI IuB/qDglGFgEqZHMwCPkf7V+HKVOB7zhiUgHqZNmCVY7Ak0YEPbM+5GIlk0NlmAtOGsg92ICV eUURquqJwdTcyueSE1d6js3+Lxof4osJS42L3RTDIhNhAh3S5CK3qMxmLYHbVkGHRroLg75Zo GMcMd4OmiacknMOzK1LdRufy7di6MMm95dW76D7tZ2tXu1oEFLgtLGjJI4NyJgR+kwvvzIUP3 lH+d7/Nwed6XS6OQXddlAaHK0Qcc7Dhh9tdzplYPZx7LFSknQYF8v+iq1AvMjPzrZFxnS2mAn pm7nDJjnsfeOmWftRFjK0fRgw7PRPo0f1fhnlJjpfnC8w5lCoX4LTryyQNAt4ObcH+v+oaiSH DLCZ6rLz8g+21FvBIMlXcp9HDPBsEBDE8jkd0IwYChozWrOTfuTea0pyAsOJSSF2NGAXm21JY jR/osdllS0DQJlrNYTmNKmASOJQo3i7xEJuWfHW/dmT5YER6ra3xM7hGcTvWZuhJ8irwsRtiD HDkPEHNJRY7B25n+31gdQJEygfU16p3ToE0QilwtY52Fm3q2wW+8HrZ57DVN1ZP44oKwcLrLa ZcIjgCZV8B8ZsbiVFx+H4effzdATKJzbPYTRMvFIn29taKXxtfkzsz1ADwWbG2LZkslc= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver attempts to 'select MDIO_DEVICE', but the code is actually a loadable module when PHYLIB=m: drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write': phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit': phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init': phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register' phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister' Using 'depends on MDIO_BUS' instead will avoid the link error. Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") Signed-off-by: Arnd Bergmann --- drivers/phy/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Reviewed-by: Florian Fainelli diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index 37371b89b14f..64fc59c3ae6d 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig @@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3 tristate "Broadcom Northstar USB 3.0 PHY Driver" depends on ARCH_BCM_IPROC || COMPILE_TEST depends on HAS_IOMEM && OF + depends on MDIO_BUS select GENERIC_PHY - select MDIO_DEVICE help Enable this to support Broadcom USB 3.0 PHY connected to the USB controller on Northstar family.