From patchwork Tue Jun 20 20:40:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 106023 Delivered-To: patch@linaro.org Received: by 10.182.29.35 with SMTP id g3csp1505630obh; Tue, 20 Jun 2017 13:41:23 -0700 (PDT) X-Received: by 10.99.36.129 with SMTP id k123mr33352548pgk.230.1497991283129; Tue, 20 Jun 2017 13:41:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497991283; cv=none; d=google.com; s=arc-20160816; b=CxorBkJLXJyThas0pxoNWLAeFZDGG5/hqBiU+AcFj+WJOK8JqlqdbzsQJKz79+LSgu rdwhVW/zCUZQXZtJptPyY1NCzPTGOW5qg/n/Rq3JGNyhkBKo8X2aICEHw3Z0esVAO0Nz f2nKzY4K9vbl4Zv70mnzNF2GEwNkHo3tizxdAfGkomaLcP18gl4igcZmWkJHZjxhoXBG HMJNxqUvKPfAYZ/FTu2XBua50n6h6VJWzyo+Q7DkUbTvQeC+4KCdLBq3rmJfkklw93SB nfqFfkB8llAx9sNTKmTC5fUcRVKbF50ESHiW8qo/ciOHzgb9uS3UBZ/eb5N8aIwRVOY3 /0Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=B7cBSM4x1I2tH3CaUSB9tCyi4b9HAlhK58KiEcysr2I=; b=mLfLlUj3yh59K7igFS4RLENBmRotYYnFqrqj/Ml7WToCvAWsROkjvfFUer+IZoHPLc YLVPKQ/0vIeVAaffS5BdBPF7Jtnffjy5U2wvAUpILvUzv4RZr8DKH/l42LCaZ7ETe92X SKxc+MVh9bxGn65EGzfJrBWi39JjCNCG2JvFoTol2vc17bKKmMibrxtc9Gm+qHuRHq8+ TLwtq7uRwxtWqD+yyNUaOQEHp8ZRLsL0+bytdeJsUTiq9L6lKZndgM8le79iUsQurdIB +bUe6uxGeJfaABtTKUwQWd8d0ZtoFGRHPMCo91VXwjvn06Qd7/U5HmOu7AwiEVmX6ICV XEQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v19si11668527pgc.246.2017.06.20.13.41.22; Tue, 20 Jun 2017 13:41:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752443AbdFTUlV (ORCPT + 25 others); Tue, 20 Jun 2017 16:41:21 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:53019 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdFTUlT (ORCPT ); Tue, 20 Jun 2017 16:41:19 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0LpRtB-1e1j350mSD-00fEqE; Tue, 20 Jun 2017 22:41:02 +0200 From: Arnd Bergmann To: Andrew Lunn , Florian Fainelli Cc: Arnd Bergmann , "David S. Miller" , Timur Tabi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: phy: smsc: fix buffer overflow in memcpy Date: Tue, 20 Jun 2017 22:40:46 +0200 Message-Id: <20170620204059.790066-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:oiaDB0rb2JP4oP4HvA1tIjMda/+8fTvmTmaLZUH6hNT+xkKsfxe ZOXC8td/f8ukl14MwLSAR/Pzx+M0MeyxtKEoERRZCtHaHn9014vbzXDsFquxhmF+bQP9KTU +KFmHXUwh0xCOLd7jDHqQ+THPBja5seeZW0FdZxyBaJFMM5rw7WHrBK5mjN2TpATMeFmFgf 7jZncWrvVRZEigYSqmYDg== X-UI-Out-Filterresults: notjunk:1; V01:K0:8b3iqOflEjo=:In4vejaCFQiP6kvnZsqeTJ VvPnoE8l+IXyjtx9X4nYdNTgxhH5s/9bOQQysAO8rt/JuruqfW4XPdaGKnBlru2N1K7NqYaC6 1ahE9LEOc8jJKyZywfUt4PXFBmaxDNnPZVTob5me2iw0YKGDN1SyBQsQ7lYn1fsjFVtYqmc/W PvOgBH9G+RkEho74ckLY1hIXANCXXSc+ySOQDDmeFMow8AIBLXlqfR7CfPPTOs9L9gAEe6SJu 4hBXdBSG/9QFR+WtLT8ySeVcJReJ3karRJd3YlcMQs0g0yZ3zmRixpQM1A7fwVJ3piX3OY0aK bR5nFn5dYHmDK3pmd6OIGcISxPm4aKqqhBrrC6Nk0zW/BvWwNOFntkiG3zDa0Et9/bV0sOr3H T/0JM7LtbsCfhgDza9odZRRFcxNdTslENNmuTj/5eaG/RDs1w6lMF3yqfSSBoZPl9m6GMn/Ij EaZjC98usclYGyugzQ7Eb8mPc1EwgBPbYT5GS5IzXbpdZyOOQpc52+6lhlBMGHsNr50Jb+VNR A9PSD29Mp3yG4F7CpTM605MpEN4JxRI1ssJON6ahB56W/1Nuy43hnjZu0ZadWaliXl/e2RUiB xR1RxDFx9xB2LNgrmwfDeCJS5KLAosAeI4TCqy0orxz7zlPKuCiCkEC2t8ZEzJahYunGifHKY RBSm4/tr8vyEbE4G06iQveaRZy0S/OK7prhuJEBYnO2zvKAibjT6cXgkRKje4/BqTZVQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The memcpy annotation triggers for a fixed-length buffer copy: In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, from /git/arm-soc/include/linux/spinlock.h:87, from /git/arm-soc/include/linux/seqlock.h:35, from /git/arm-soc/include/linux/time.h:5, from /git/arm-soc/include/linux/stat.h:21, from /git/arm-soc/include/linux/module.h:10, from /git/arm-soc/drivers/net/phy/smsc.c:20: In function 'memcpy', inlined from 'smsc_get_strings' at /git/arm-soc/drivers/net/phy/smsc.c:166:3: /git/arm-soc/include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter Using strncpy instead of memcpy should do the right thing here. Fixes: 030a89028db0 ("net: phy: smsc: Implement PHY statistics") Signed-off-by: Arnd Bergmann --- drivers/net/phy/smsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 1b8204be064c..2306bfae057f 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -163,7 +163,7 @@ static void smsc_get_strings(struct phy_device *phydev, u8 *data) int i; for (i = 0; i < ARRAY_SIZE(smsc_hw_stats); i++) { - memcpy(data + i * ETH_GSTRING_LEN, + strncpy(data + i * ETH_GSTRING_LEN, smsc_hw_stats[i].string, ETH_GSTRING_LEN); } }