From patchwork Thu Jun 15 14:13:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liviu Dudau X-Patchwork-Id: 105653 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp824450qgd; Thu, 15 Jun 2017 07:14:01 -0700 (PDT) X-Received: by 10.98.144.132 with SMTP id q4mr5369745pfk.8.1497536041198; Thu, 15 Jun 2017 07:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497536041; cv=none; d=google.com; s=arc-20160816; b=pN90/jyI/Grgt7aiu0OWZtuaxya2gHySULj6b0GOZ2VXKymyt2vEMel+Ei9F7dmiTM /wC7mmEW1mbn8Or+Yu/ipPSnRA4dBVCgPBeDhfGFVBHzBO7vmzWdfZe2TKB8TgceCyw1 4dSrHtywK4a8Us4pe4wAXVV9H5GOCFg7E9YpI6s6L5TPk0oHmtFSfqmLxbobpp7+pWOe N60MY0HIKvonSwbmpby4k+k+Ang+mC8Twg2++W07FQSfUd/vxytDWPukg0oqYzElZf1/ adK8RWyDkIV0MREvI1/GNuP490IC1LX27dDpuX7XLQUBhVNcIDT0a8UEHV+k5h0zwLh9 UwcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=i4l42I5D16gLyEKcEjRmrV1pO1Sk3nrRoAY3pGX2IpE=; b=YOEdQiurI3eOVqxKihlXRaoGXu4ZDS72mhvOBnZWKMTMbhGepKl8KjQBR7sAyH3CrA msbe5Z4U0TBFPH1Wx0edopxwFf46fR+R4P9qxSzgbCDzRmU+yiOz2BuA9lvSeyfaLEHh 2eorXmQLvxAJiTBREO4TBr8JmAZnJeTTeEXMzTg4IuM4ARaDmfLe7GAqc/ZxFdLQD5Xh /Q8L1/EdkVu+oYEKRExzazrKbUD1mhQFx4SnkHsari+X7DIbuShO1CKzbkNDlp7EhVU5 rIEprOtAQsUtDDpxUnGJpFPdnwGgyBKz5ndVC9Mof9GAWUlycezzt8WmgLqzVdt8GKCj IHLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b13si179363pgr.453.2017.06.15.07.14.00; Thu, 15 Jun 2017 07:14:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbdFOONx (ORCPT + 25 others); Thu, 15 Jun 2017 10:13:53 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:59227 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751829AbdFOONw (ORCPT ); Thu, 15 Jun 2017 10:13:52 -0400 Received: from e110455-lin.cambridge.arm.com (e110455-lin.cambridge.arm.com [10.2.131.9]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id v5FEDkQg020958; Thu, 15 Jun 2017 15:13:46 +0100 From: Liviu Dudau To: Rob Clark Cc: David Airlie , LAM , DRI devel , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Liviu Dudau Subject: [PATCH] drm/msm/hdmi: Use bitwise operators when building register values Date: Thu, 15 Jun 2017 15:13:46 +0100 Message-Id: <20170615141346.12859-1-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.13.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit c0c0d9eeeb8d ("drm/msm: hdmi audio support") uses logical OR operators to build up a value to be written in the REG_HDMI_AUDIO_INFO0 and REG_HDMI_AUDIO_INFO1 registers when it should have used bitwise operators. Signed-off-by: Liviu Dudau Fixes: c0c0d9eeeb8d ("drm/msm: hdmi audio support") --- drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.13.1 diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c index 8177e8511afd..9c34b91ae329 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c @@ -175,10 +175,10 @@ int msm_hdmi_audio_update(struct hdmi *hdmi) /* configure infoframe: */ hdmi_audio_infoframe_pack(info, buf, sizeof(buf)); hdmi_write(hdmi, REG_HDMI_AUDIO_INFO0, - (buf[3] << 0) || (buf[4] << 8) || - (buf[5] << 16) || (buf[6] << 24)); + (buf[3] << 0) | (buf[4] << 8) | + (buf[5] << 16) | (buf[6] << 24)); hdmi_write(hdmi, REG_HDMI_AUDIO_INFO1, - (buf[7] << 0) || (buf[8] << 8)); + (buf[7] << 0) | (buf[8] << 8)); hdmi_write(hdmi, REG_HDMI_GC, 0);