From patchwork Wed Jun 14 21:15:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 105584 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp488787qgd; Wed, 14 Jun 2017 14:17:47 -0700 (PDT) X-Received: by 10.98.1.72 with SMTP id 69mr1838675pfb.124.1497475066948; Wed, 14 Jun 2017 14:17:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497475066; cv=none; d=google.com; s=arc-20160816; b=yt2cruH9SDfapglhI0gzASIw0/EY4EBeJoD6wbq/nvjSDdJ0mCzdW/uvRmjIREoKm/ ZEWeOhOQEFgowZirJ9C0uRnIRjcRf2mPZoJG05AGFHMQckacBIKKpHBIUavnJx9J6YgL gz1tgxY2mSpLUWKVgzVFs1+J28b1Ornao3FeRApbxNGy2mt0FUiNPBum/xHw9KompAUW lpAMLsinvQ6uxNeWnEVoVAjDMtRDBREag4fVnzVJudMZQcbkR9YiW30+1ui6XLw7nJ7a tR6PoOQ1DFu+1sjZKohBxbjwkAdEXe3+0pxuzscJz7sAJX23H8QygVmt/U0UbEi0wpYC p0Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Ixq9y875j8DWpWRu8nu4Dz5m50rdZiBUaxR2D5X06ng=; b=T21IW5tMAFQadGtAGMVPXefcIgqiSvPLAxvFcr9tvzUFxUEeyyI9Y64ZsR4tBpx5g5 EZFV0X3PVtCzxfyvqcXhhLpZxPfahk7lzPhDprSE3/PNjhwvqyG5bXzUE6vulGWzXMW2 TwiWeK8r/thQwkbfpsh7Z75mwb0oHq1x28Y6VV9MpxJtIS40b24ff5jrjEp9VTnBWepR DurrfjZvejb+Aijk35uMX8ldxObIaYlJvQpG7qsI2H5tC27q0CA5gBTV9S060pxKBIPj 6OZ2Nlo35/KkY2LgvDhhY1Lgi6Y85d8gQpKJpy2IFJ4t04QtBXJhxs0lm10OBRc/A4+7 hvnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si6829plb.534.2017.06.14.14.17.46; Wed, 14 Jun 2017 14:17:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbdFNVR3 (ORCPT + 25 others); Wed, 14 Jun 2017 17:17:29 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50386 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbdFNVR1 (ORCPT ); Wed, 14 Jun 2017 17:17:27 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MBevm-1dVezy3EfO-00AVa6; Wed, 14 Jun 2017 23:17:16 +0200 From: Arnd Bergmann To: Andrew Morton Cc: kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Andrey Ryabinin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arend van Spriel , Arnd Bergmann Subject: [PATCH v2 01/11] compiler: introduce noinline_if_stackbloat annotation Date: Wed, 14 Jun 2017 23:15:36 +0200 Message-Id: <20170614211556.2062728-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170614211556.2062728-1-arnd@arndb.de> References: <20170614211556.2062728-1-arnd@arndb.de> X-Provags-ID: V03:K0:+tGQB6NdWJwGazOfEPEbnzEBysfXUiv3tsiUtkOrgh4wYL0j6tz VXfj77Q+NIQsx5lKmOFRxkg55grWJwVcOSgghlH5yZDoK8alDvHBCEeIha7iQxsMcOKYQHy Hff7KX73co/5PvwQ3TNr+l/jcQ9eAvR3MsmqAP0CmZLxkVd+MpR7istWgxluhpQcbbO36s9 8u0yjMZkCXBWVKELY3w1A== X-UI-Out-Filterresults: notjunk:1; V01:K0:pV5ohuZLQ88=:wHsGVCorTo1zc/648OWXVC 2nUvrt9H8kVN9UX2JvaICE2mu6zg8l6GGyDRfGUtLWrRrGnvFO1yJQmsTXI3YZFLxMsEwnm8I /JEIl5Yc31TeKqxYRldoc1jbyUd/eWqctWfpukiUVProrghpb0FzHcPd7fdo2+uAfUH6+xoBr 2ijKJ+OLSmhjGEQBHnWlwsnPRaL4HWVzJVfHi7QyGdtu1NPIQy2jgkda6KPtnxPzJxmYFxGFf DJBYZvIV3PDf69hHyZqT4n0PZTmudx9eJkzUQZYTmASUclkoHlPRUZg59+78MrDXOl/24/34J hD29fHGSyJPQ7NrTWDFqizN2kftHYMdWFBej3SedUeBQZp5E34d+Fr0TFllEUvt+hwSod8dXI ToIDdoY3/YtuzrBerXFaCPIihnKb0VMKmZ2CGPyfCBaWqEmtnGLToSem3KTOWli55FKpXIFLK kFKnQ01Jjks7CWKlh798M0UuePe87hsIG+Bf3K2ZCAGwUvMQjnPVezaDgg91Y8y07Cx44hB+s zN+YrCrPtw+I+XIQD6/yNygFA0h3QOI1d/MVjhpRiaojlhlufYLZn7IpxFMZMcx4VtK9ORDVg pASEcokPnzwTJPh7bqywQWDqPKhjhUMZrAZJgpwLLGA0fBYvv4n794gMFN8PTDkyN5Uxhb8K2 H+O6TrfvMv8B0KWIub0Cn7m8iWvgqYWUsa5XYIFMQzTF8A9AqPOEbe80eh7ISvvavSMk= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_KASAN is set, we can run into some code that uses incredible amounts of kernel stack: drivers/staging/dgnc/dgnc_neo.c:1056:1: error: the frame size of 11112 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/media/i2c/cx25840/cx25840-core.c:4960:1: error: the frame size of 94000 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/media/dvb-frontends/stv090x.c:3430:1: error: the frame size of 5312 bytes is larger than 3072 bytes [-Werror=frame-larger-than=] This happens when a sanitizer uses stack memory each time an inline function gets called. This introduces a new annotation for those functions to make them either 'inline' or 'noinline' depending on the CONFIG_KASAN symbol. Signed-off-by: Arnd Bergmann --- include/linux/compiler.h | 11 +++++++++++ 1 file changed, 11 insertions(+) -- 2.9.0 diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 219f82f3ec1a..a402c43c07d2 100644 --- a/include/linux/compiler.h +++ b/include/linux/compiler.h @@ -412,6 +412,17 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s */ #define noinline_for_stack noinline +/* + * CONFIG_KASAN can lead to extreme stack usage with certain patterns when + * one function gets inlined many times and each instance requires a stack + * ckeck. + */ +#ifdef CONFIG_KASAN +#define noinline_if_stackbloat noinline __maybe_unused +#else +#define noinline_if_stackbloat inline +#endif + #ifndef __always_inline #define __always_inline inline #endif