From patchwork Tue Jun 6 15:16:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liviu Dudau X-Patchwork-Id: 103166 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp1475107qgd; Tue, 6 Jun 2017 08:16:19 -0700 (PDT) X-Received: by 10.84.142.133 with SMTP id 5mr21870657plx.21.1496762179439; Tue, 06 Jun 2017 08:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496762179; cv=none; d=google.com; s=arc-20160816; b=HM+6T+zNR7sXgrDZmOkFWWegzcHZKLTDkiq+m2i/ttQrnQNZRLxadk86mO6UBalSNK D73ht+DkARJkcWhhBp+VTS1bB4H6tEgcJ2FeFSBooqrNw1hHmsT/Rxs6wWNuADEOn6cr LB/W/0C7FERjVBcNJm4U5s9xef17Fj1KH9vcmXkqvarS5AyYv1F44q5wlsHgNS9LM+i6 LMSkXnyleC9vtfJ2cF+lgkIPgRI1OxtPMPTAV9nRubSDdWIkx+dPMz06MnAG1LRXrN4w 81eU/t2N+6n/eEbby3zGqEjWnFaiKhrypWIB9McDFJ6dwqs8a79egLADOaT4ndj+LfHy fU6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=q7i3T57owXt0NqaEsvjyejSfTy1Gyg0WxBn7zhlrJOM=; b=reH0PJKVw8etHwu31vbpvQrY4yx/Mw/b64Xy4OhfWaxb1HZikPAm9W+nXjwmsaBX09 c02aRPegyWvUyzBPijZGIazUdEHKdsYsP/KJgTA/D9BLJ8rAzGazua2W9W1X6kJIe4/4 +oc0Nt4mTnvmbNkQOxjgXGtsd3V7s50GA/LQ1ErMgOovrdDrqeDu4fa3vLRzhXyOxH/H FuWHOw9YhJoHMxQus/QjM5Wr3nwoAbMnQbsC7l1iBXz07NmUs0Dh6YOJf7Ya8rqt7Qb+ vKlMNidTn5oR8JfvTcYqXIYoTGVuy+qM0EuVHwiGzoUIOy8/3Nq4yFF8LmNE7MDWsZRD AmUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d71si33908099pgc.68.2017.06.06.08.16.19; Tue, 06 Jun 2017 08:16:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751505AbdFFPQK (ORCPT + 25 others); Tue, 6 Jun 2017 11:16:10 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:57284 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751388AbdFFPQJ (ORCPT ); Tue, 6 Jun 2017 11:16:09 -0400 Received: from e110455-lin.cambridge.arm.com (e110455-lin.cambridge.arm.com [10.2.131.9]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id v56FG55K018920; Tue, 6 Jun 2017 16:16:05 +0100 From: Liviu Dudau To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Brian Starkey Subject: [PATCH] drm/arm: hdlcd: Set the CRTC's port before binding the encoder. Date: Tue, 6 Jun 2017 16:16:05 +0100 Message-Id: <20170606151605.31804-1-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.13.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The component-based encoder(s) used by HDLCD expect the CRTC port to be set before binding in order to find the right endpoint. Without this patch, the TDA19988 encoder driver prints a warning "Falling back to first CRTC". Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.13.0 diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 345c8357b273..d3da87fbd85a 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -297,6 +297,9 @@ static int hdlcd_drm_bind(struct device *dev) if (ret) goto err_free; + /* Set the CRTC's port so that the encoder component can find it */ + hdlcd->crtc.port = of_graph_get_port_by_id(dev->of_node, 0); + ret = component_bind_all(dev, drm); if (ret) { DRM_ERROR("Failed to bind all components\n"); @@ -340,11 +343,14 @@ static int hdlcd_drm_bind(struct device *dev) } err_fbdev: drm_kms_helper_poll_fini(drm); + drm_vblank_cleanup(drm); err_vblank: pm_runtime_disable(drm->dev); err_pm_active: component_unbind_all(dev, drm); err_unload: + of_node_put(hdlcd->crtc.port); + hdlcd->crtc.port = NULL; drm_irq_uninstall(drm); of_reserved_mem_device_release(drm->dev); err_free: @@ -367,6 +373,9 @@ static void hdlcd_drm_unbind(struct device *dev) } drm_kms_helper_poll_fini(drm); component_unbind_all(dev, drm); + of_node_put(hdlcd->crtc.port); + hdlcd->crtc.port = NULL; + drm_vblank_cleanup(drm); pm_runtime_get_sync(drm->dev); drm_irq_uninstall(drm); pm_runtime_put_sync(drm->dev);