From patchwork Tue Jun 6 08:51:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guodong Xu X-Patchwork-Id: 103131 Delivered-To: patch@linaro.org Received: by 10.182.29.35 with SMTP id g3csp1163237obh; Tue, 6 Jun 2017 01:53:20 -0700 (PDT) X-Received: by 10.84.230.134 with SMTP id e6mr19682178plk.256.1496739200501; Tue, 06 Jun 2017 01:53:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496739200; cv=none; d=google.com; s=arc-20160816; b=xKSn/X3lZKdqF5Ngsut/V8yXWvCK37o1iaRwslzPcYUN98R48mijEtBbx46jSwdP3r MPTWZBC0rfuY9YnUlFwm9b88iS+/38MD7D2Q/LGwqPVjITvOq8VYwS9EODbIkJ2jN4dB Bu888yCciX8Fpc3iVz2OiQ8Y0cp8V/IuUMg/v68IXDvdkMOt1KOXXJctnxFukYppUM7V mGYwJE/d5ajFfN7S67jgs4ZAlPuj/rXkS9P5iG8UiBi6JRNFC9T6j/rd5U4DeWPY+VHX UCsF+75e/h20HUXpVdSqr4TbCEWXgqFRSVZwRhHpJsqjcwX47tHDemLG5g2Dr9nJsdN6 JzHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=JRxRbQ1LhMdZczoXwsLnSYgzsvO6fg7RGsIeXp5Waao=; b=qQKcr0mXmndlknwW0UnMzgtUOxjm+Ydrq1pJV6RqlTzPN9cjqdBq1GWMdDMWUmxyN0 hIwaIbvCi7SqQEUFVx2uGq6gw3pmLvvANe4Q8eN8RK5xE2SmVcmZ4zEiJ/D6zOdTPFHs wvQ7LsmTEy3xKU/iCPGMmNR2m0KLE6NyIlthfyWgtmfUDQb2DZglT/jcjFJmZCZ0Zp6X ernh0dhGI+B/TSwQaBjI/2UYfoy1I0EhJO0Cef/67JBWDG+MYcOG4Zzo8kfAClpBweud IeycVx8sq6Vcs0UGyALWxioW+k6GOj5f+OOezGHmZBmOXxHYLzEy5Av8UJxK9mLUiE3k W99A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si8727143plk.92.2017.06.06.01.53.20; Tue, 06 Jun 2017 01:53:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbdFFIw5 (ORCPT + 25 others); Tue, 6 Jun 2017 04:52:57 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:33519 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbdFFIwz (ORCPT ); Tue, 6 Jun 2017 04:52:55 -0400 Received: by mail-pg0-f43.google.com with SMTP id f185so32371403pgc.0 for ; Tue, 06 Jun 2017 01:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JRxRbQ1LhMdZczoXwsLnSYgzsvO6fg7RGsIeXp5Waao=; b=gHNsUaqURL6TNVzHAhX62om9C8FUAeU13F0uHQQLGXvZzMK/xOWvWvIuy/Pd5wLjR2 qQ7ZVaP9Xe+VeIQPpnQZM3OEIWUQmCYC8DUcX9r8l5c2L2TysAyUVxGboi+/YCEfp1U7 4cOkN+2m5alblBlGNXAeBPJrKd9GBT1Vz+Cco= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JRxRbQ1LhMdZczoXwsLnSYgzsvO6fg7RGsIeXp5Waao=; b=t1GA2LrpXaArbcb7wewLFSFHLcEkqZcT2SlzK1WzIsi72E7mXKGygC1A2+xIx+UWSr eGjxyL/fmUuQ0K5zZVDrLGm2UAcDkeBH4sUUvMBAmWk3sOK/penOs2R0HI34w4A5IQW+ +O/UDtlZq9YQtNKvt53qKVVemos3Ykw0U4Uq3dtPaafzj3R92qBYYS+eu9wsYl5l3Hx7 yQ9KJeRqCYbasVswhQJxpJSpoRkClQg8tELImvWJLXEqlMwy9DOkl5ss8Z5poNyu7Oi6 6hpmjuBHnx+J6tlw+SzSz1z/IEsLQ2ofGxXwio3FUX9qwCh7gx0+P/OMt42mOdAXKvgR /eiw== X-Gm-Message-State: AODbwcAvXtKUTu+aSG4yMWhXbyhhAbQuLZWShSoqffLLv5HMfSJdiA1O E3Bk1uNfyQSMNKKw X-Received: by 10.98.69.68 with SMTP id s65mr24819250pfa.178.1496739169289; Tue, 06 Jun 2017 01:52:49 -0700 (PDT) Received: from docularxu-ThinkPad-T440p.219.146.1.66 ([45.56.159.173]) by smtp.gmail.com with ESMTPSA id b14sm49851988pga.12.2017.06.06.01.52.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Jun 2017 01:52:48 -0700 (PDT) From: Guodong Xu To: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, xuwei5@hisilicon.com, catalin.marinas@arm.com, will.deacon@arm.com, lgirdwood@gmail.com, broonie@kernel.org, khilman@baylibre.com, arnd@arndb.de, gregory.clement@free-electrons.com, horms+renesas@verge.net.au, olof@lixom.net, thomas.petazzoni@free-electrons.com, yamada.masahiro@socionext.com, riku.voipio@linaro.org, treding@nvidia.com, krzk@kernel.org, eric@anholt.net, damm+renesas@opensource.se, ard.biesheuvel@linaro.org, linus.walleij@linaro.org, geert+renesas@glider.be Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hw.wangxiaoyin@hisilicon.com, Guodong Xu Subject: [PATCH v4 4/8] mfd: hi6421-pmic: add support for HiSilicon Hi6421v530 Date: Tue, 6 Jun 2017 16:51:39 +0800 Message-Id: <20170606085143.13154-5-guodong.xu@linaro.org> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170606085143.13154-1-guodong.xu@linaro.org> References: <20170606085143.13154-1-guodong.xu@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for HiSilicon Hi6421v530 PMIC. Hi6421v530 communicates with main SoC via memory-mapped I/O. Hi6421v530 and Hi6421 are PMIC chips from the same vendor, HiSilicon, but at different revisions. They share the same memory-mapped I/O design. They differ in integrated devices, such as regulator details, LDO voltage points. Signed-off-by: Wang Xiaoyin Signed-off-by: Guodong Xu --- drivers/mfd/hi6421-pmic-core.c | 68 ++++++++++++++++++++++++++++++----------- include/linux/mfd/hi6421-pmic.h | 5 +++ 2 files changed, 55 insertions(+), 18 deletions(-) -- 2.10.2 diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c index b1139d4..4568a43 100644 --- a/drivers/mfd/hi6421-pmic-core.c +++ b/drivers/mfd/hi6421-pmic-core.c @@ -1,9 +1,9 @@ /* - * Device driver for Hi6421 IC + * Device driver for Hi6421 PMIC * * Copyright (c) <2011-2014> HiSilicon Technologies Co., Ltd. * http://www.hisilicon.com - * Copyright (c) <2013-2014> Linaro Ltd. + * Copyright (c) <2013-2017> Linaro Ltd. * http://www.linaro.org * * Author: Guodong Xu @@ -16,16 +16,20 @@ #include #include #include +#include #include -#include +#include #include #include -#include static const struct mfd_cell hi6421_devs[] = { { .name = "hi6421-regulator", }, }; +static const struct mfd_cell hi6421v530_devs[] = { + { .name = "hi6421v530-regulator", }, +}; + static const struct regmap_config hi6421_regmap_config = { .reg_bits = 32, .reg_stride = 4, @@ -33,12 +37,31 @@ static const struct regmap_config hi6421_regmap_config = { .max_register = HI6421_REG_TO_BUS_ADDR(HI6421_REG_MAX), }; +static const struct of_device_id of_hi6421_pmic_match[] = { + { + .compatible = "hisilicon,hi6421-pmic", + .data = (void *)HI6421 + }, + { + .compatible = "hisilicon,hi6421v530-pmic", + .data = (void *)HI6421_V530 + }, + { }, +}; +MODULE_DEVICE_TABLE(of, of_hi6421_pmic_match); + static int hi6421_pmic_probe(struct platform_device *pdev) { struct hi6421_pmic *pmic; struct resource *res; + const struct of_device_id *id; + const struct mfd_cell *subdevs; void __iomem *base; - int ret; + int n_subdevs, ret; + + id = of_match_device(of_hi6421_pmic_match, &pdev->dev); + if (!id) + return -EINVAL; pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL); if (!pmic) @@ -57,18 +80,33 @@ static int hi6421_pmic_probe(struct platform_device *pdev) return PTR_ERR(pmic->regmap); } - /* set over-current protection debounce 8ms */ - regmap_update_bits(pmic->regmap, HI6421_OCP_DEB_CTRL_REG, + platform_set_drvdata(pdev, pmic); + + switch ((unsigned long)id->data) { + case HI6421: + /* set over-current protection debounce 8ms */ + regmap_update_bits(pmic->regmap, HI6421_OCP_DEB_CTRL_REG, (HI6421_OCP_DEB_SEL_MASK | HI6421_OCP_EN_DEBOUNCE_MASK | HI6421_OCP_AUTO_STOP_MASK), (HI6421_OCP_DEB_SEL_8MS | HI6421_OCP_EN_DEBOUNCE_ENABLE)); - platform_set_drvdata(pdev, pmic); + subdevs = hi6421_devs; + n_subdevs = ARRAY_SIZE(hi6421_devs); + break; + case HI6421_V530: + subdevs = hi6421v530_devs; + n_subdevs = ARRAY_SIZE(hi6421v530_devs); + break; + default: + dev_err(&pdev->dev, "Unknown device type %ld\n", + (unsigned long)id->data); + return -EINVAL; + } - ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs, - ARRAY_SIZE(hi6421_devs), NULL, 0, NULL); + ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, + subdevs, n_subdevs, NULL, 0, NULL); if (ret) { dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret); return ret; @@ -77,16 +115,10 @@ static int hi6421_pmic_probe(struct platform_device *pdev) return 0; } -static const struct of_device_id of_hi6421_pmic_match_tbl[] = { - { .compatible = "hisilicon,hi6421-pmic", }, - { }, -}; -MODULE_DEVICE_TABLE(of, of_hi6421_pmic_match_tbl); - static struct platform_driver hi6421_pmic_driver = { .driver = { - .name = "hi6421_pmic", - .of_match_table = of_hi6421_pmic_match_tbl, + .name = "hi6421_pmic", + .of_match_table = of_hi6421_pmic_match, }, .probe = hi6421_pmic_probe, }; diff --git a/include/linux/mfd/hi6421-pmic.h b/include/linux/mfd/hi6421-pmic.h index 587273e..2457438 100644 --- a/include/linux/mfd/hi6421-pmic.h +++ b/include/linux/mfd/hi6421-pmic.h @@ -38,4 +38,9 @@ struct hi6421_pmic { struct regmap *regmap; }; +enum hi6421_type { + HI6421 = 1, + HI6421_V530 = 2, +}; + #endif /* __HI6421_PMIC_H */