From patchwork Tue May 30 09:28:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 100701 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp124615qge; Tue, 30 May 2017 02:29:26 -0700 (PDT) X-Received: by 10.99.185.91 with SMTP id v27mr24530382pgo.184.1496136566529; Tue, 30 May 2017 02:29:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496136566; cv=none; d=google.com; s=arc-20160816; b=RhvzNW/MWWkcywqMEb+IihrFaVYaP2bf6XvjGKEYoIOu9m/djXb2wZ0CLTg5jXa8JS +8QMlxw2CLal8hMcA5HjbaX6pxjTSqz0NgOJAbXgCTe6OgosPs8ZmFTZVqBkMhMMiFBZ sMOUhYA3uVaazhI2Y+2XrFDlx5SwwJoh4LGWV8EvfIEFUh5yIk0MCVmhAMNvT9MzG1m8 keEp0VXZohsVj0c+qLIh221Jfx5xfl4xe/NyJq7dZXKytxTzGbrV4im2dx6CqLkOnVP+ QVC1w5f9MDBI3pezKdPmf/WQgAeg35hPDFt9rsIndfmc4kIkijyNImq/XggTIAGweiPA TaAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=LvXB3mMnEK8eSyMUtK7swjJjyeX5YwvD0LlNMxCwHf0=; b=a+S73Y87CzHoplJ5kI+1MAS8Ef4syWT7haKG8VsZFV/DJ9/l1GAI5LaxQHEmPeXjfM XtG+9sGzJJDCKJHpn/sunsxYAgyL0+UHc2tG8SXVWAVxQaRgQXeIfvPEFNP5itT8Wi2y 4o67kEWPg81gbrh/HXzkKj+I2AyCxNwLLcyb76+Zxx5b+aWt3LXgWQfpRthyQQ909iqu +v0ZBSje8h3lLy5W2PNOkTz15p3jlaknoqtts76IY7gnvOYQeNfLgBM4bxRt5I7+Gd8G FOQWyeBscGNS2Q5aOhUs3KSSZgdtaDCh/0OvGg41sTEgsxiguPQOvlS7AOsKBdqm85tW S9Dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o15si12924768pgn.314.2017.05.30.02.29.26; Tue, 30 May 2017 02:29:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751718AbdE3J3U (ORCPT + 25 others); Tue, 30 May 2017 05:29:20 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:60637 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbdE3J3Q (ORCPT ); Tue, 30 May 2017 05:29:16 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MdTLH-1dXZgV3fFL-00IV9c; Tue, 30 May 2017 11:29:01 +0200 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: Yuvaraj Kumar C D , Girish K S , Vasanth Ananthan , Arnd Bergmann , Jaehoon Chung , Krzysztof Kozlowski , linux-kernel@vger.kernel.org Subject: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA Date: Tue, 30 May 2017 11:28:25 +0200 Message-Id: <20170530092858.1351047-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ygztqZiKzQTcehbp91nONlT1PnzAo/UYxz4n9ByD0LFQeIZyivT EcpP6iF2P9FAcI+gVPYjoitrhpbjw1Jeamwl/+DuZiNoycVOHpM9PYVrWrccVdJtEFarczr aaRhRZUZ3Z6B/D26P3pdhlS5PxIkWdPw0iAQbY98QeTH3gmJyahPdVraPMZn8pn9vR8Ydji 8j4dm7b1XUlHUnbbji4VA== X-UI-Out-Filterresults: notjunk:1; V01:K0:BGJCDMR15IA=:2etMf8qXHGUpqRIqkBKR9g t0/39st2aN6Vcr/d1mk1rpy1yV9vHt5SF2jaCvFRp+Nmjx8ZzJzwMNhhxHJjXlQHkMxAkhOnW WLEf62z/jfnpmL3AAblyrPud2n2h7Tn/kv1T2ceNpQqZ0m7ZG/joqZ8ob5U//B6aFMJt1Mkjw CN7mOAKDOuo/1g3Yyez96+jN4E79z9SoMC61VyYyWENIm/MKNjwX2ajDHfeN/Y+O425E2/Mib ZYFD3zi23JrqXm2EDedCzR6+Akm9owzGEdv1pwQXBZ1KaNzyAhRU0iwSfLOQza7lK1AyOKIpM R+bIvlrAFnMl+3/h+tGvvoGyZZvLMI+hdrEfYneqlKoqLwJMlg/C3zBDj/4R2Mv598EIZQ5tV uuiUNakIR5NpXtp/j3kqtO9IqKNaxdO5rOfJQZs1+BumHd3hbNaW6BJPNj2kpGbMrEmu37L4G 6PeUsDKvSE/mY79tRjzqltcAuyWpNF49iY4J3R3oRl5GqRVWt4dy6yNnaRB2mjeY5j7gb5bXp IdC2QRTEAm3wMc76MLZCtWQldAB1estHPRagYV99Pr3jPnXUPme7lidStA49sutnq4G4fFyIY XzktKGEzuUTAc6GV94VfRq3quEmO7KPdELT48HqjO1wb0QPuA15D1uLoQmg0jpWo96coiLRs5 kpaCF95laKIvtiroryg7dfmQQUl1xORdww5wU/RTSRxylGgCWWd9cTPE6HabFGhCepE0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Device drivers should not 'select' other subsystems, but rather use 'depends on', to avoid Kconfig dependency loops. This one even selects a particular I2C host driver for no reason, so we can remove the select of that particular driver, and turn the I2C 'select' into 'depends on'. Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver") Signed-off-by: Arnd Bergmann --- drivers/phy/samsung/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig index b7e0645a7bd9..76475b01780d 100644 --- a/drivers/phy/samsung/Kconfig +++ b/drivers/phy/samsung/Kconfig @@ -83,10 +83,9 @@ config PHY_EXYNOS5250_SATA tristate "Exynos5250 Sata SerDes/PHY driver" depends on SOC_EXYNOS5250 depends on HAS_IOMEM + depends on I2C depends on OF select GENERIC_PHY - select I2C - select I2C_S3C2410 select MFD_SYSCON help Enable this to support SATA SerDes/Phy found on Samsung's