From patchwork Wed May 17 20:26:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 100012 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp403137qge; Wed, 17 May 2017 13:27:28 -0700 (PDT) X-Received: by 10.99.94.66 with SMTP id s63mr648806pgb.34.1495052847910; Wed, 17 May 2017 13:27:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495052847; cv=none; d=google.com; s=arc-20160816; b=hu2lqa+x04kcGWlla01TdtjWpc/UDb4YJsPFi+gT6nLeKYyJq+vEVaabinP8PMc0WH Z79Hn3jgn6E3Ccm8qTlEC3oj+rlMIYNT+dBT464HeNrZNAgKOo336u+8fb3erJ1Rb8m6 mzO0A/EnTuan6wlhV/586sSU5nodnd+iLAnJNdEvhEOF51wGFna5kLzRy/faCotJtX3y TY/X33dDhRAzsGsHs//YbYo1VuGaYElSl7QDpQDU67zbqvwg0j2hLVHIy632ab7IkSuP yCbO75ZFTVXfJvtYj31lCwCHD+NFq0zt0SGxrKZPlWa/WFu3G+HlG79e/yVc5JTNkFIG WODg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:user-agent:content-transfer-encoding :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=ZXZ1oL9+5KGv/pw0/nzn8OGg1EKIE59ZrcVKphyydLE=; b=Ow7inVHzc8HH8QjBgIL/MR/eEzuCq7YJtQj1z5mHddCRm6pUBeFhYwQkd0sO+wppNY D75Tby4MRcutpmYHMTIddu3TNnPMi0KHk1GkrsyJNzMsQuxNrnuwyQbDZs1O8sZ5AX2h S77WPx2Sw2N5eitUGgzd3YUUc97QEd5kDXyXvIxehZqeSR6VmKm9v7iLEb9MTA+3XtCp sCi/4EaMYGgoM2pe03O3jDg4tToSYPyTxrdxYl7CtVd5AHEMpzFekDRwnUdfmsPVE7yK WHoeQ0nWgT3z6zuHbUP8V6iD8uDHlY1/q/YBkcEHneIoVqKbiNH3ALpFDm++oT1bUkBF LBJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@CAVIUMNETWORKS.onmicrosoft.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k196si3103352pga.50.2017.05.17.13.27.27; Wed, 17 May 2017 13:27:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@CAVIUMNETWORKS.onmicrosoft.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754548AbdEQU1J (ORCPT + 25 others); Wed, 17 May 2017 16:27:09 -0400 Received: from mail-sn1nam01on0084.outbound.protection.outlook.com ([104.47.32.84]:5906 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751395AbdEQU1F (ORCPT ); Wed, 17 May 2017 16:27:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZXZ1oL9+5KGv/pw0/nzn8OGg1EKIE59ZrcVKphyydLE=; b=jXAUHzLOg5YcA0uUd3UCf7DOrr4xGMvrfjGKXUNkOyIeCx46o968Xjn56/5ZHV5docbvHZyowfxA4zG8P74hZChgYmIeVtbNfJTpT1W2MKz2Vw4Ypz7vkBJfy3CeHqoCRgak/09sH0QkF/KJrrwcadc1lDiyVvuUr7QKWtSYLIU= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost (176.59.34.0) by BN3PR0701MB1267.namprd07.prod.outlook.com (10.160.118.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Wed, 17 May 2017 20:26:58 +0000 Date: Wed, 17 May 2017 23:26:49 +0300 From: Yury Norov To: Amir Goldstein , Miklos Szeredi Cc: ynorov@caviumnetworks.com, linux-kernel@vger.kernel.org Subject: Build warning 'uninitialized variable' in fs/overlayfs Message-ID: <20170517202649.szj7ygjfnsgdpzl3@yury-N73SV> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Originating-IP: [176.59.34.0] X-ClientProxiedBy: AM5PR0101CA0014.eurprd01.prod.exchangelabs.com (10.169.240.24) To BN3PR0701MB1267.namprd07.prod.outlook.com (10.160.118.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 96a37086-4973-4999-46e3-08d49d631180 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BN3PR0701MB1267; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 3:TU41wT8HUvjwl5HEiMlogibCw6IN5o2sdK3b53qXFUEDHuUykl9htxy8kRB/curhVDhTbhtrvgH29czwhd56PWVsDYhQRw7Bl3dUQKaghd4k6NP0VKhRLvZds9zEA+5cqiXzGOKoaCCUZ6OfdGoKWATw439TdGswhZlokzqXbpF5DtKI1o5np/WwAzRnWoEdU4k1uC92KNJu1tGkTzZZpWWk3WBevcvXy+qMcqgvn4Dqc9FyXq8rwc8QffoZKN7LDyObWrOlBKadB/NvGwktaiJGPYlvK7ziRUCh6ixO6E4m1kdEJHjrktU0Hasg4sdjLmjiTKqO+iXvOdtIIXqK9w==; 25:3AYbZzzOLXamNVZlrBu5vjcCkBbPrFYK/N6ilF91FFurtREXPlK1/QPokIi/WJhlOoxZ1ccs+2Yt9Nt12AJWD3gUHyEHw267PpDioBcLgPsOSyCGDL9vYgBfmjr8ZJlTLtwLb/rnr8NhTD9Z9xr5R8F1TFr4LGTfkZK2pSSbx9I8aZw4ILc2mqhmSwVAlrT5m6rfxNa2g0mv/n5MyEk+KkmznpxZmmWxjsPxLD0/vz/gpH+k/2ybWvNygn/3MYTcFK9wRmFChqEM9Dlc/fi8ji2LhwYslvdZRLN9qMT11KP5I8WodNEhihnXfwoulGNhsS79SHy11ZWdAt6Ve0zX8VCclW5VEnbb+78BJ0O4CGkRrG+pd+vOZ5mdVd3tS/R7Rp4M6GX5jtw/KWhQE8jQspf//1zHogUgwZnW+NNZMx2HktY/k80Z52XkMJ7cDVDDTs3k4caL6Tme+jkMin3bTVmwOlqHH2DoRQ9Zl2AbQ08= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 31:vNFOUcrExfN5Diu/3IRzmmjOKKZ+HDKCenvux0Za9wX6idLzZ36aSQznWs0ZVujGWbpt2X/nCKnFJQua5PaK54hycA0H/oDzyiuHBQoi87KS6YdoGUmN0bdXrFi9wANZr0y4aynyXI02cLN8xEOha76NRRUPb6INFeCx9IeF8tiss2RxyinISLK7k+XrhSe2tnTPdyiMylAzBzSvyb9FFRAPhbHjEmIu3RGR6gm8sSo=; 20:ZbdunOpVDw8z6GNzlsObM8qTUL0XjDymZmTN/lBb9McNEL5kHPg8xhV9NCSj3tjpoZEzneSUN3ak/5I5cvVimKT1NxLTM4Er36wkEtU0FIHn4ZggfGac8eIGB3f45q7EisNFLkhArLGQQo0k8AKqKxrjaTbiHAoHaCYml8Xj4lomRkVh2e3StfTkXoPX7h2OXtjLNF3B1mRMKTfjBIVdsMyvIoETfqeyGIYdE7a15p/Kre8yucghFC5FncdJ0OSM2O9Rt9W5TuRVluPBUvKZLC1Z5g0jZTGIirYrZow36ipz/h8SxgQDHUxt/g2Tnl1UD+86K4ylSqNOLdthN9benkdozNIUv90kgHQ5LP4mjEM0qFl27L6+WMUlw1fS467lC0cnE0kEm1dSFIhPX0uohXYhBhMsk3YMZMFsxD2N8Vb8pOUivOeWjkUmNqDQvkYyQTYn2oeH0mTl40Fr+kh92yKx0QHlFRRXV+fc5xpw70VOUmgrzO/u4n6aDWCT/B3+I8kxlJMs2k4EsiQtGgx1HIQQASzDD6qc08py4byWZMu55hWogA5VBp9JKIkfI51eOTcXmNu59J9ySPb1vazt6TqPvz1/weu47rSJXGbY3mE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148); SRVR:BN3PR0701MB1267; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1267; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 4:uTXfFYY0jyd1DXFXbz+3/d9rpryGeu3aXfjI2DN8kBi3SzZIFVbAq4s3qoJDnq/GQmfubWIh3S5f7LU3zjrnqbGku82A7mLqVRBpPlXjHgIqXpPk2qKDF9hpM0YuqVhGD0jGUQ2PXY7MkzKY5ymxZJDMhPPweqa3bqaTl3tQZAYYqe8Ui3WtWDnlJ69taeQy6WTOpOOLyzAULoWzs693qe78q6AbHnOuB7Qj7DuezT32VakuQ2IuzUB892K02nbZ5uYy93g2GcS64BXZI7x3tjNd3tEQnXQDw3ilWFHvAjIPXfDA2IWCOLKFC7OXGrM+j0VZ8vE2Xu5NnzvAxtLDd/W7XvDIWff0ge3OXdNICDIhbMXNOG8zn2rY8RD1FAsUBzoiJmN78/eAQhsUvlZNW6VNMkgYr74sIgR6SvSErfK6x9uuo6m06quJbvd8guNfB9BJDhunJfSN7X4FBmMYTsY+p/cUBDr0PWPbYWjVFrtIl+ldOc/s2eenda6kZ0MsTKsMnc8dfQiPY+iTUrLCfbUXj+sv4+eGhJVr3YEGNDI1usu+0fx/SP8zXJdrjRU4WL/1t3B7CB+HVsxIJYwVoypioRZrtKG10D9NBaKOgCQC37HuO+jqO7s9P729FTACzkY2nrlr6p09U4PCo01PfbGyd8QW+RZ9JjeI5N3Nkcr0s6GepSEXO6U9JX3fAjFBalE6/7fZfxPe6/heK6MBUJJL7qiVrMvGlAtsbXJKvP56Yo41iNLkBn3X/j434EmirsT1P4B5cXVVGOrrJB3ezA== X-Forefront-PRVS: 0310C78181 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(39400400002)(39850400002)(39450400003)(39410400002)(39840400002)(2906002)(81166006)(38730400002)(6496005)(50986999)(5660300001)(189998001)(47776003)(1076002)(42186005)(54356999)(8676002)(53936002)(6116002)(66066001)(3846002)(478600001)(33716001)(50466002)(9686003)(76506005)(72206003)(6666003)(4326008)(83506001)(42882006)(6486002)(25786009)(23676002)(2870700001)(7736002)(4001350100001)(33646002)(305945005)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1267; H:localhost; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBN3PR0701MB1267=3B23=3APO?= =?utf-8?q?NSZKjOB2fH3+1jscUR8wNRw0h2zbc6esFVO2+Q/IPxvi0lMllkb82WQq?= =?utf-8?q?bg78m5RKqgGIdDrPsZw//HyOPRzGnaNFuZpHwWi7fz2fxxA7l1rI+90o?= =?utf-8?q?79SfRqp9ZsXlIalJtQVKZH6E86dH0e88uvibFKnPUSel5zMa47GF8Etb?= =?utf-8?q?VEUiIV4yAkZR1vx2LYAKQKQHysSxlDSzCt8OI7NT8j6lIYOBIBefXhB5?= =?utf-8?q?XEMIKE+KAWLxMH387qD49TJdX3yLOHm/oXG8whT9otk5FiLgkKY62YoZ?= =?utf-8?q?fWKfXoIxdnBQj/OBCLC6QEn3zKBfTycNsv513JDvU5f803fxU4VCYzmK?= =?utf-8?q?5vw3mO6rl0CM5caj8aMLJ5YKiH1QCbFKVHacDi2/eDEoTTMdpiSKxTiS?= =?utf-8?q?V/cXosVgpWSHp+l1JwiJyMJpYpCuP9i2Ip5j8SHbPgXUxNhDFg7IjzY/?= =?utf-8?q?TamZe84cCAQZSpI4ijpO9g0qP2kkwkDxJ5YIjv00DhPT9t9WdeeNo3nS?= =?utf-8?q?1opi3o4Kqbbnlu6rxNDGxsxYeXEdn9CJ58M6RqRK99tAFOGcbXo7Iz9m?= =?utf-8?q?upbvEGKOmuHW+mo+qIfLx04xhM2/2UG0JRyLOtAG7rX6ghkii0ppVHxz?= =?utf-8?q?MnNuwRhfcFwtPvrhKd+uB2OaqgffmhcRsV+HkC2SNuLhbGhaX1RPPPxl?= =?utf-8?q?Xi9laJDDscCiZhU5JGzByjZt1jYXJqeZx0ZjYphpEJjfMFu6x3Io5bUT?= =?utf-8?q?TR8c+m50vCJRgCeOpjydLdE4Qlepo1i8iSMLXNzgHYjNAoXG4g9RHv21?= =?utf-8?q?h6W6sgjfqgdU7nASB8haPI83MDwVdk7V82FvbQJEi2RRREt+hcQaSYo/?= =?utf-8?q?QMLwly17TbS1Uw1REzc/YT6hkuis/v1P0W76FCpnRrQ6gfWQZ1W4MHA2?= =?utf-8?q?hxOrO+CXJqHazP8tiY8WDsfLLYb36KoG/CPk3FMB06ieiC1G0vSeNamg?= =?utf-8?q?jVx3XqWggMw2mvfQKbuVhr00+RAMmIp+Hg6lMPhTyKm21eFxkZiPnEsh?= =?utf-8?q?nnBxByiXyJBgx9dj8RLW+Jd70PfTx74GPLMuF2ZoC6iWFaeEFJqdLtol?= =?utf-8?q?BtqfRC2cSvjybypCe0Hhj4?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 6:MFfJwfrFD7A+SrWBlBiQVyyn3TdynAsYwrr2UhU1PrdWqfBXIpaYXLiTx45ny9ceodEC63QJDkAsLQc/qWe0BnxnrRqiQKX31RQQyRZQuFiOK5yvM7hqt87i8rKmACdejr29oY5rosXjGuFh0RvPS8TATil0H/2K9zM1FsIPutat9xmvob6nz30X4OmcLykwuCCvfpnijjuHcVmwVP+AGFNjf9LCruHda8UQfOQKXKVjgmZZCybYcNLftVoOHMK0PrbFqHaLGAEyy4HkgnYtLtwKnAJxl8UTjY5EKKhZp1zLQR4obpm1Dtc4l7Dd33ZobLlseOMi/fDv9BUiMv56e0IvCA3ovP8BBmwf/zm9l+7jT18aHcmNKATGAYXowCBo1kkDlKEVy4GLD1VjbtpOBzFKwXHdPJLXvUL42m9kkIPepY5nyO7S3JysWOavW/Ue623aflvEuw/vmJj0JJ+LVoRS6zJZVD0TcVaHaVuQ833zKmk+PgX7INmQkoxzaz3NzyVKXzIS/S0+R6WfbG+DZQ==; 5:nd0KR5Ou7bXMzsvOovr7dpkYfFBm6lI5MwWVto+zQurA10nphV4fdbw98SNwqF3Fg2XpQ3V7rPh4F7uYs1eT2YarN8Vvp/kZug7sSKX8vail7cz2TtOkqvbeYEyQtSfHLLakhXKum/idQHJhpbabjw==; 24:Dc80gBVde8Cw80AZdglpntJDqakCYzo0s1UXi0zTqBdfnMoUlIDTFtaqGpcRu4l3dguiLud4LGCpAfblQhxm4t0kirNGk4yQSDXaeL3f20Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1267; 7:RDh23ePQxzlley/tCe0IV2fjoX11kkwaxpUviS6tZlt0e2JCSxqHbAnTk1NSPpXMjYFjP8B0tYJV2wNj6ZF4D3vvcbZ3mtTbv99hy7wp2gFgGjxG5he95DHRY78wSD4hSnP56wTkBdIQp6Di8GptLfgYqHAA3kKlzsoxXaGxb9PWSQHn27NJO4RF9pQdBBBo7+d4j6+qA/ruslVWCof4Y2hC9wWXynSJDUgdluhc5Mj9hrTffWJav/jYrialsXBznYlCGN90fj6o2hFRPN9XFDSy4uFw7fZt0RhrhD41Y3Jb4wKJ50ac0zUymQUd5FVmryc4kARFAh+TS9/5y3kNNg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2017 20:26:58.3202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1267 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amir, (Sorry for new email, but I cannot find your patch in my mailbox, though found it in next-20170517) Your patch 02cac3227a282 (ovl: mark upper dir with type origin entries "impure") makes gcc warn on uninitialized variables in my arm64 build: fs/overlayfs/dir.c: In function ‘ovl_rename’: fs/overlayfs/dir.c:1060:2: warning: ‘newdentry’ may be used uninitialized in this function [-Wmaybe-uninitialized] dput(newdentry); ^~~~~~~~~~~~~~~ fs/overlayfs/dir.c:1062:2: warning: ‘olddentry’ may be used uninitialized in this function [-Wmaybe-uninitialized] dput(olddentry); ^~~~~~~~~~~~~~~ The patch below fixes warnings for me. But I'm not familiar to the subsystem and so not sure that the fix is correct. Yury diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index 5ad6ccf2159e..19ee4d294b5e 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -973,13 +973,13 @@ static int ovl_rename(struct inode *olddir, struct dentry *old, if (ovl_type_origin(old) && !ovl_type_merge(new->d_parent)) { err = ovl_set_impure(new->d_parent, new_upperdir); if (err) - goto out_dput; + goto out_unlock; } if (!overwrite && ovl_type_origin(new) && !ovl_type_merge(old->d_parent)) { err = ovl_set_impure(old->d_parent, old_upperdir); if (err) - goto out_dput; + goto out_unlock; } }