From patchwork Thu May 11 11:41:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 99615 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp685559qge; Thu, 11 May 2017 04:43:03 -0700 (PDT) X-Received: by 10.99.225.83 with SMTP id h19mr12378314pgk.38.1494502983153; Thu, 11 May 2017 04:43:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494502983; cv=none; d=google.com; s=arc-20160816; b=o3/24ydkBZUIQl143ea2IvESphI+V4JcT5lcokp2PS5Z1bllsoyqosU2Hrc6sPXOIQ myU06aj0OS6m/dtjr+qLoE3UB99NF/EZeBOfedUebq19rNzGFuxfxpy9cPBKaRBs84Da FiqdH04VLSyrn7c1lu04o2PcxCeh0GlPGBJzE5Tw8Qetpd2Yq5v+KewYV+5JFJPSo/zz VRNdksbUSaNroTK9Bw1mQ1BSQcpg1hZoUD4O5uEey0WJ6ygEx4ldIqyBOCbc2AsK/ZiM NucpmtbhP4g0MToDz1NvAPQkeSdPNgcRspfRBI1vHP2pL4i/vz9zcbx9PJAbw/eN6DSp AxTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=997rQXOzE/9Dt7GlLcmj6ahKYsuDEgdKtrwKNEaB6ls=; b=guXHGIpgM+DFlEfjyQTlhXrRVH98kQAWpgArx3rx1+GMOi4IZOBt1fTCTqGmb2NHa4 YngRs3iGMn60oMN9AsEioZiJbZFMEoxbGw/mjS1eqbGulB/q/25s4d5cXDNMyzKmusvV ZnG85eJVS0Xs7UjI6v1j6X5hyvDP/C+zXs3zxOoPQ6vV1K1cdbo7R18Nl3Y3D1Obz2wA g8W8xUhG+yjLfmip86p1qSnx4JL4HQnum2L+2jupS8KZW29RglaTt/jtf3qakNpCCMJC KZE0jdDszuAKs0hgBCWWbEPqNBW9XYvdjR/S3Z8p2QtcFm4Xr5WKQue49Lpr854Fp95e gPLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si1640545pln.92.2017.05.11.04.43.02; Thu, 11 May 2017 04:43:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932384AbdEKLmy (ORCPT + 25 others); Thu, 11 May 2017 07:42:54 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:59722 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbdEKLmx (ORCPT ); Thu, 11 May 2017 07:42:53 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0MW7C9-1dXEK61LoH-00XHka; Thu, 11 May 2017 13:42:31 +0200 From: Arnd Bergmann To: Marcel Holtmann , Gustavo Padovan , Johan Hedberg Cc: Arnd Bergmann , Rob Herring , Bjorn Andersson , "David S. Miller" , Andy Gross , Loic Poulain , Sebastian Reichel , Javier Martinez Canillas , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] bluetooth: hci_ll: add proper SERDEV dependency Date: Thu, 11 May 2017 13:41:54 +0200 Message-Id: <20170511114223.2744939-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:CRD0aAoHb62U494n385cx0EforKfzksvUAIxcgmuEeiS2pEiGIF BxDvyMOwAt1DE1JAHK2r1MozzG/F3qf6OCEK8AuOYUYPDEUk95TGeRZGr87AF0KbsGabH35 t9GbnTZ4IN6Z1FBQ/88DGyR1iSvcnw0pN5WBWiEzIpHqydzatZ3+c1X3kkamrqaOoKZgoit iBRiaAeqVgVRTlDR6FRTQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ga0sijfvcU0=:q8mm4QJM6e+vxCzyzahCXa OyyE7XdQu6Nw0ZMWO7iC8DG7FmVdb3zhHqAWBTZJ+Sgi3db18ZsR96pyGPHm3a77cbb4GhMiI gwaz3V4mM7o2ZP2o66aBwLEsVmdBX4fO0EcNSnPCVD5NbGitE3fo7xgYEBRROUp37uXH56PfY AkmoZ1tIj7oM2iWukRQ8BY+4I0+T73pmaJ3M45QOTuCK93KOCutQzyVXpI0wgfwSnmbmpEW3w kJvsRCwXhCdDL/4Qb03JLP9VTQOJFi1Dtr9X9m0UyL9tFBcxuBnzaorH9gjs2sp5ONrzZCi88 GhWAJHumxE1bl/j+0LbuwdIX6Vf7evB2EscsdXvDbolTljhW0wStNvOEekBD3WoKqBOycfOzH p9BFRYVhhyyDDbgk3j2n6yClH4Ca9OvnG/onmXGrJAD2mGRdFHRYVF21x51FsBWwoqDv2HbrM 3HEcc6aB9sU38EK6h0wltNQo++1J2s1VqrdQZ/sdgF8eFGu8dGSmk2nGaCdBairiVpjZPy67Q eqVjZFOz/8OrMu0FgwtlVIGzmlVQZ6KMZ/PGKIs2tQYaAdggSJKCZinHXgB+nk//A7gQ68KXi Z7DvSdm8ovg7DzfHzow66QBdlqVrm8rTum6f4j6LfE/6BCrY/0h6Q7Mq0T+6qgm5OaDkpexIf 7IL4XacJSfvmIlMHg47l9/V1s1yUbeZiyJ63AUaFplZad79Eq9jt8GJ7+62Z3BIiMDjs= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When SERDEV is a loadable module, and the HCI code is built-in, we get a link error: drivers/bluetooth/built-in.o: In function `ll_close': hci_ll.c:(.text+0x278d): undefined reference to `serdev_device_close' drivers/bluetooth/built-in.o: In function `hci_ti_probe': hci_ll.c:(.text+0x283c): undefined reference to `hci_uart_register_device' drivers/bluetooth/built-in.o: In function `ll_setup': hci_ll.c:(.text+0x289e): undefined reference to `serdev_device_set_flow_control' hci_ll.c:(.text+0x2b9c): undefined reference to `serdev_device_set_baudrate' drivers/bluetooth/built-in.o: In function `ll_open': hci_ll.c:(.text+0x2c77): undefined reference to `serdev_device_open' drivers/bluetooth/built-in.o: In function `ll_init': (.init.text+0x10d): undefined reference to `__serdev_device_driver_register' We already have CONFIG_BT_HCIUART_SERDEV as a Kconfig symbol that is set when the serdev code is reachable by a driver. Unlike the nokia driver, this one can also be built when serdev is completely disabled, so we add a dependency on serdev either being usable or disabled here. Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support") Cc: Rob Herring Signed-off-by: Arnd Bergmann --- drivers/bluetooth/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Reviewed-by: Sebastian Reichel diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index a63130ef2b98..b2cf0ae6b62d 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -133,6 +133,7 @@ config BT_HCIUART_ATH3K config BT_HCIUART_LL bool "HCILL protocol support" depends on BT_HCIUART + depends on BT_HCIUART_SERDEV || SERIAL_DEV_BUS=n help HCILL (HCI Low Level) is a serial protocol for communication between Bluetooth device and host. This protocol is required for