From patchwork Wed Apr 5 14:06:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sjoerd Simons X-Patchwork-Id: 96882 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp283078qgd; Wed, 5 Apr 2017 07:12:00 -0700 (PDT) X-Received: by 10.98.219.2 with SMTP id f2mr29906727pfg.23.1491401520173; Wed, 05 Apr 2017 07:12:00 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g24si20784394pfd.250.2017.04.05.07.11.59; Wed, 05 Apr 2017 07:12:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045AbdDEOGo (ORCPT + 13 others); Wed, 5 Apr 2017 10:06:44 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:52076 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbdDEOGV (ORCPT ); Wed, 5 Apr 2017 10:06:21 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sjoerd) with ESMTPSA id 25C632656B8 Received: by dawn.luon.net (Postfix, from userid 1000) id 3F6AF2E404E9; Wed, 5 Apr 2017 16:06:13 +0200 (CEST) From: Sjoerd Simons To: John Youn , Heiko Stuebner Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] usb: dwc2: Power off the phy on shutdown Date: Wed, 5 Apr 2017 16:06:12 +0200 Message-Id: <20170405140613.4444-4-sjoerd.simons@collabora.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170405140613.4444-1-sjoerd.simons@collabora.co.uk> References: <20170405140613.4444-1-sjoerd.simons@collabora.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On a board with a usb->sata bridge behind a usb hub, the bridge only appears on cold boot and becomes non-functional after a reboot. Testing thusfar shows that it gets confused during reboot if the usb hub is left on (Interestingly a similar setup without the usb hub in between doesn't have the issue). This can be avoided by turning off the phy (thus vbus) during shutdown, which turns off the usb hub. For devices where this isn't required, powering down the phy is harmless so we can do this unconditionally. Signed-off-by: Sjoerd Simons --- drivers/usb/dwc2/platform.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.11.0 diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 9564bc76c56f..b5bbc433c94d 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -348,6 +348,9 @@ static void dwc2_driver_shutdown(struct platform_device *dev) { struct dwc2_hsotg *hsotg = platform_get_drvdata(dev); + if (hsotg->phy) + phy_power_off(hsotg->phy); + disable_irq(hsotg->irq); }