From patchwork Tue Apr 4 16:10:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 96753 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp266636qgd; Tue, 4 Apr 2017 09:10:24 -0700 (PDT) X-Received: by 10.99.146.7 with SMTP id o7mr24584070pgd.6.1491322224500; Tue, 04 Apr 2017 09:10:24 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 125si2081070pfe.397.2017.04.04.09.10.24; Tue, 04 Apr 2017 09:10:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbdDDQKP (ORCPT + 25 others); Tue, 4 Apr 2017 12:10:15 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:32787 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932184AbdDDQKM (ORCPT ); Tue, 4 Apr 2017 12:10:12 -0400 Received: by mail-wm0-f41.google.com with SMTP id x89so769059wma.0 for ; Tue, 04 Apr 2017 09:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=V11tzwUZnyF23Frqr30bLLVSCATmNHyWC9g2Wi+dGPM=; b=QAMEifmru45YvoPDJiKKTKYJXcASsEYpmGVHKVFOCkKm+LFf+hX4GDoraY+AKU1plO O1bI4NjaXRLbnEPzM0KbpiF4rlmRoUhosuOKeqrHPBtzcuG/sKcc/2Th24z+Tdc0ZjO1 II5g2LAJorwD2BwAEO6+k2QL3vnOD2+UzMzYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=V11tzwUZnyF23Frqr30bLLVSCATmNHyWC9g2Wi+dGPM=; b=BkJIn+LpHIvuldgrPGjjkjDrQoHXx8MHS48hYPeGkxNtNsWnUD70LGYqFg2MbgIVmv fuQW4/i20oJG8HNlRc3kFENVg9zP/kZTIh9cFR777BUjbSn/tHyUr4OAh+gbAhz+vGKq 1aFyHnpEy7DzLkXh9zHBbi5QGJ2UVknDlomheEgtCwGXdZTWWp7jk+An91+cmW/+sA/6 /MGXIeIpzHJDXwWfsyvZkWbqsqcjwz9seE7i4bU3jszNUbtaOHrOxCT9gHX9vmadQORm jEAkMvvWYjS1jJQbLcpkjrxpP4MBdR/RqjfH3sYcTVz1K4NfCagQI98OqAV7qBTW9Gj7 FF7w== X-Gm-Message-State: AFeK/H0spAHtwWq2vJ2OxwFJ+s8JjTHHkI2z9GYTjW9pdYoU+4dP980C7hpmgCQyFrMzaO8m X-Received: by 10.28.91.82 with SMTP id p79mr15179568wmb.130.1491322210909; Tue, 04 Apr 2017 09:10:10 -0700 (PDT) Received: from localhost.localdomain ([2.31.167.174]) by smtp.gmail.com with ESMTPSA id j77sm18971292wmj.3.2017.04.04.09.10.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 09:10:10 -0700 (PDT) From: Lee Jones To: hans.verkuil@cisco.com, mchehab@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, patrice.chotard@st.com, linux-media@vger.kernel.org, benjamin.gaignard@st.com, Lee Jones Subject: [PATCH 1/2] [media] rc-core: Add inlined stubs for core rc_* functions Date: Tue, 4 Apr 2017 17:10:04 +0100 Message-Id: <20170404161005.20884-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently users have to use all sorts of ugly #ifery within their drivers in order to avoid linking issues at build time. This patch allows users to safely call these functions when !CONFIG_RC_CORE and make decisions based on the return value instead. This is a much more common and clean way of doing things within the Linux kernel. Signed-off-by: Lee Jones --- include/media/rc-core.h | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) -- 2.9.3 diff --git a/include/media/rc-core.h b/include/media/rc-core.h index 73ddd721..1f2043d 100644 --- a/include/media/rc-core.h +++ b/include/media/rc-core.h @@ -209,7 +209,14 @@ struct rc_dev { * @rc_driver_type: specifies the type of the RC output to be allocated * returns a pointer to struct rc_dev. */ +#ifdef CONFIG_RC_CORE struct rc_dev *rc_allocate_device(enum rc_driver_type); +#else +static inline struct rc_dev *rc_allocate_device(int unused) +{ + return ERR_PTR(-EOPNOTSUPP); +} +#endif /** * devm_rc_allocate_device - Managed RC device allocation @@ -218,21 +225,42 @@ struct rc_dev *rc_allocate_device(enum rc_driver_type); * @rc_driver_type: specifies the type of the RC output to be allocated * returns a pointer to struct rc_dev. */ +#ifdef CONFIG_RC_CORE struct rc_dev *devm_rc_allocate_device(struct device *dev, enum rc_driver_type); +#else +static inline struct rc_dev *devm_rc_allocate_device(struct device *dev, int unused) +{ + return ERR_PTR(-EOPNOTSUPP); +} +#endif /** * rc_free_device - Frees a RC device * * @dev: pointer to struct rc_dev. */ +#ifdef CONFIG_RC_CORE void rc_free_device(struct rc_dev *dev); +#else +static inline void rc_free_device(struct rc_dev *dev) +{ + return; +} +#endif /** * rc_register_device - Registers a RC device * * @dev: pointer to struct rc_dev. */ +#ifdef CONFIG_RC_CORE int rc_register_device(struct rc_dev *dev); +#else +static inline int rc_register_device(struct rc_dev *dev) +{ + return -EOPNOTSUPP; +} +#endif /** * devm_rc_register_device - Manageded registering of a RC device @@ -240,14 +268,28 @@ int rc_register_device(struct rc_dev *dev); * @parent: pointer to struct device. * @dev: pointer to struct rc_dev. */ +#ifdef CONFIG_RC_CORE int devm_rc_register_device(struct device *parent, struct rc_dev *dev); +#else +static inline int devm_rc_register_device(struct device *parent, struct rc_dev *dev) +{ + return -EOPNOTSUPP; +} +#endif /** * rc_unregister_device - Unregisters a RC device * * @dev: pointer to struct rc_dev. */ +#ifdef CONFIG_RC_CORE void rc_unregister_device(struct rc_dev *dev); +#else +static inline void rc_unregister_device(struct rc_dev *dev) +{ + return; +} +#endif /** * rc_open - Opens a RC device