From patchwork Wed Mar 22 15:00:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 95779 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp281292qgd; Wed, 22 Mar 2017 08:01:17 -0700 (PDT) X-Received: by 10.98.133.133 with SMTP id m5mr46518808pfk.146.1490194877132; Wed, 22 Mar 2017 08:01:17 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si2125357pli.56.2017.03.22.08.01.16; Wed, 22 Mar 2017 08:01:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760610AbdCVPBG (ORCPT + 10 others); Wed, 22 Mar 2017 11:01:06 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:54881 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934236AbdCVPAr (ORCPT ); Wed, 22 Mar 2017 11:00:47 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v2MF0jdm017903; Wed, 22 Mar 2017 10:00:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1490194845; bh=Hz+KCE3NQGupu7pLgfAWBkiljwG9Hbm+bVFWDNLdoYQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=mSX9BsRO5BTAHGr+gHqFCb8b2hfKMCb5kbe8wU1WTRJb0/eZvHZGhkLQP/TqmOLyk c5v+T+ESH12aIWcF7inNj3k3R+mq7wlpb4AWaTj2AE5GCjHHfWez4sJ+RBT6sTZQ1T 4c0bGIiGkIXYjcP4+/8ErUUFz7+HaMHQ4aefUuFM= Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v2MF0jHb031996; Wed, 22 Mar 2017 10:00:45 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.294.0; Wed, 22 Mar 2017 10:00:45 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v2MF0bLc000583; Wed, 22 Mar 2017 10:00:44 -0500 From: Kishon Vijay Abraham I To: CC: , Subject: [PATCH 4/4] phy: qcom-usb-hs: Add depends on EXTCON Date: Wed, 22 Mar 2017 20:30:36 +0530 Message-ID: <20170322150036.12629-5-kishon@ti.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170322150036.12629-1-kishon@ti.com> References: <20170322150036.12629-1-kishon@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Boyd We get the following compile errors if EXTCON is enabled as a module but this driver is builtin: drivers/built-in.o: In function `qcom_usb_hs_phy_power_off': phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to `extcon_unregister_notifier' drivers/built-in.o: In function `qcom_usb_hs_phy_probe': phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to `extcon_get_edev_by_phandle' drivers/built-in.o: In function `qcom_usb_hs_phy_power_on': phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to `extcon_get_state' phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to `extcon_register_notifier' so let's mark this as needing to follow the modular status of the extcon framework. Fixes: 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") Signed-off-by: Stephen Boyd Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.11.0 diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index c11044439fd4..005cadb7a3f8 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -449,6 +449,7 @@ config PHY_QCOM_UFS config PHY_QCOM_USB_HS tristate "Qualcomm USB HS PHY module" depends on USB_ULPI_BUS + depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in select GENERIC_PHY help Support for the USB high-speed ULPI compliant phy on Qualcomm