From patchwork Mon Mar 20 22:31:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 95591 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp1162711qgd; Mon, 20 Mar 2017 15:31:36 -0700 (PDT) X-Received: by 10.99.152.9 with SMTP id q9mr5208010pgd.225.1490049096885; Mon, 20 Mar 2017 15:31:36 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si3989649plb.265.2017.03.20.15.31.36; Mon, 20 Mar 2017 15:31:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755175AbdCTWbf (ORCPT + 18 others); Mon, 20 Mar 2017 18:31:35 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:34408 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbdCTWbd (ORCPT ); Mon, 20 Mar 2017 18:31:33 -0400 Received: by mail-pg0-f48.google.com with SMTP id 21so50814603pgg.1 for ; Mon, 20 Mar 2017 15:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=kobODTfwHhtYnLkUVHVhFCOAy50bEmDy9Ekq6epHXrM=; b=GjEEkoDwiMOpknNt+BasjUSlRvBhTMdnX1nE1FbyD2V4WTcgOS58TuNhNe59USJ4hl AkB3cocKFrphifvCfPQbODPbpxTmfMsNTMy7CoOVu2YR/gDY2F+qKaICQwigAfU6avl2 d41Zkisvt75BdbOJnAoYJZSsT6cz8qfeEd8oM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kobODTfwHhtYnLkUVHVhFCOAy50bEmDy9Ekq6epHXrM=; b=rXYqAWhCfTyiSGsGOu8rrIdNB+QnnBdvMlq5PGrHeYU4+Dp9ikTtt43fJ9y/DqLIE7 dGr4FI7t8fsxir0LJaFdR/If6fzngWPOT/uM5SOQ8pxpi/DdxwcDtCmiXjMbJIOmVtYY 3yRZbqve3WKukK9m+4R10NvwpI9XmAvt+Y2tM6Rm29OmzjyOWk5J4lsx5PEEgAFqypKH TLj26STO6kZc4Dopkte+F8qA+2i8kIVqLNH2YqdsYUNLjuwDf3U7ie1gkSQy+3DMFpXP wOtolPSca0iVfiJKBiRFlisyGyoYV1uSaogjBZ9wbwKvFxmE5JxT4gsJLljtmjFKyCxa uTvg== X-Gm-Message-State: AFeK/H3nilRZU+1zC5QMMx6F7+y+DndzVFrK8hVwxz/Dy/J31FMYot+fnMburkku//v3KuNV X-Received: by 10.84.169.227 with SMTP id h90mr42637025plb.155.1490049074177; Mon, 20 Mar 2017 15:31:14 -0700 (PDT) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id e67sm6864832pfa.87.2017.03.20.15.31.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 15:31:13 -0700 (PDT) From: Bjorn Andersson To: Marcel Holtmann , Gustavo Padovan , Johan Hedberg Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] Bluetooth: btqcomsmd: fix compile-test dependency Date: Mon, 20 Mar 2017 15:31:10 -0700 Message-Id: <20170320223110.30431-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann compile-testing fails when QCOM_SMD is a loadable module: drivers/bluetooth/built-in.o: In function `btqcomsmd_send': btqca.c:(.text+0xa8): undefined reference to `qcom_smd_send' drivers/bluetooth/built-in.o: In function `btqcomsmd_probe': btqca.c:(.text+0x3ec): undefined reference to `qcom_wcnss_open_channel' btqca.c:(.text+0x46c): undefined reference to `qcom_smd_set_drvdata' This clarifies the dependency to allow compile-testing only when SMD is completely disabled, otherwise the dependency on QCOM_SMD will make sure we can link against it. Fixes: e27ee2b16bad ("Bluetooth: btqcomsmd: Allow driver to build if COMPILE_TEST is enabled") Signed-off-by: Arnd Bergmann [bjorn: Restructure and clarify dependency to QCOM_WCNSS_CTRL] Signed-off-by: Bjorn Andersson --- drivers/bluetooth/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.12.0 Acked-by: Marcel Holtmann diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index c2c14a12713b..08e054507d0b 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -344,7 +344,8 @@ config BT_WILINK config BT_QCOMSMD tristate "Qualcomm SMD based HCI support" - depends on (QCOM_SMD && QCOM_WCNSS_CTRL) || COMPILE_TEST + depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD=n) + depends on QCOM_WCNSS_CTRL || (COMPILE_TEST && QCOM_WCNSS_CTRL=n) select BT_QCA help Qualcomm SMD based HCI driver.