From patchwork Wed Dec 28 22:56:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 89209 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp5738976qgi; Wed, 28 Dec 2016 14:57:56 -0800 (PST) X-Received: by 10.84.210.167 with SMTP id a36mr83233104pli.125.1482965876066; Wed, 28 Dec 2016 14:57:56 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 68si51337689pga.8.2016.12.28.14.57.55; Wed, 28 Dec 2016 14:57:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752357AbcL1W5l (ORCPT + 25 others); Wed, 28 Dec 2016 17:57:41 -0500 Received: from mail-pg0-f50.google.com ([74.125.83.50]:34388 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbcL1W5d (ORCPT ); Wed, 28 Dec 2016 17:57:33 -0500 Received: by mail-pg0-f50.google.com with SMTP id y62so107848305pgy.1 for ; Wed, 28 Dec 2016 14:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vUj5l5p8TH4hBlSsewEa3N/TCFaiOrmX9AUM13NDuRA=; b=gLMo55WhnCh6X/hls60IPFY2TdUw1bkabbzIbKNKZe+LndB9W8prBXfabtUq9mYRh5 IsthAeHOdkPrX8ANv8RSckNWyg5ne913Yh0EghW6EpJuacHjcN5QjQaaOfqmDVX1k/QG D+Uhds7QY+R6rZFCh325K9AC8D/R3dMZbSG78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vUj5l5p8TH4hBlSsewEa3N/TCFaiOrmX9AUM13NDuRA=; b=Fm7DDf9wEmDh1PPwIEAlFKyTtz1bCpL5hmkzGnPbyPMr+D+1GS88sC50wZItuZdWtX 0RRRHnqJ4CKv3A9VkSq+eUkwCAtIWvygq7a0HlY6KoAv0PFpI14ejXUgRufeu/z9RiqM DNDrkQKHI5OyH7z0t2f3bl/KdXMEo57ryYQ12xSJBOeJkp/jkmc4gqBD01hOp8s9o3LD EYe8txo3pHuwt/q7RHJqr+fOIhiAtkgK4KHlfLbYPDIedcDmVk1HktMEOBYvGtMApE2n DBdZyYCjUzKhHRyv+vyWug0lS69bKW6p0awT+3UeCthvLLJdbFFw5L1jlsPjtma58RRz NzQw== X-Gm-Message-State: AIkVDXKhfQnNt4LaRQW7MD8hCzejPTPWdPGM8f5vz/AAc46NxZM63r3iPnft8OIam8m2ujCD X-Received: by 10.84.216.17 with SMTP id m17mr81253735pli.82.1482965847738; Wed, 28 Dec 2016 14:57:27 -0800 (PST) Received: from localhost.localdomain (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id x4sm100355741pgc.14.2016.12.28.14.57.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Dec 2016 14:57:27 -0800 (PST) From: Stephen Boyd To: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman Subject: [PATCH v6 12/25] usb: chipidea: msm: Mark device as runtime pm active Date: Wed, 28 Dec 2016 14:56:58 -0800 Message-Id: <20161228225711.698-13-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.10.0.297.gf6727b0 In-Reply-To: <20161228225711.698-1-stephen.boyd@linaro.org> References: <20161228225711.698-1-stephen.boyd@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We're not properly marking the glue layer/wrapper device as runtime active, so runtime PM believes that the hardware state is inactive when we call pm_runtime_enable() in this driver. This causes a problem when the glue layer has a power domain associated with it, because runtime PM will go and disable the power domain to match the 'inactive' state of the device. Let's mark the device as active so that runtime PM doesn't improperly power down this device when it's actually active. Acked-by: Peter Chen Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) -- 2.10.0.297.gf6727b0 diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 3889809fd0c4..89c1a02d69b5 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -80,6 +80,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, plat_ci); + pm_runtime_set_active(&pdev->dev); pm_runtime_no_callbacks(&pdev->dev); pm_runtime_enable(&pdev->dev);