From patchwork Thu Nov 24 16:28:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101458 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp172338qgi; Thu, 24 Nov 2016 08:29:11 -0800 (PST) X-Received: by 10.99.174.75 with SMTP id e11mr5632044pgp.89.1480004951124; Thu, 24 Nov 2016 08:29:11 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12si11533877pla.142.2016.11.24.08.29.10; Thu, 24 Nov 2016 08:29:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757336AbcKXQ3C (ORCPT + 25 others); Thu, 24 Nov 2016 11:29:02 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:65142 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757159AbcKXQ27 (ORCPT ); Thu, 24 Nov 2016 11:28:59 -0500 Received: from wuerfel.lan ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0M16WO-1d3A2R3FJA-00tDoB; Thu, 24 Nov 2016 17:28:47 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Jisheng Zhang , Marcin Wojtas , Philippe Reynes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] mvpp2: use correct size for memset Date: Thu, 24 Nov 2016 17:28:12 +0100 Message-Id: <20161124162843.3849988-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:GxARpguAiyUBnjnxfZ763/2htBqT9qnpDB73nkjmjZrx8FQZ1ua HK2pECit/HLFQ7f5UuJSBeobv5opXW4G5/mjwRZjOEYaOo8Ahh1SNhCoz5Pe4qbQGVJ+mj9 eElfF0q+ZsvawcWVPXsUG5CTIsFcxEirZ6CnnxC4Csjn0a7L1JxIV3cDw9EIlW9WTlF6iXZ 8OfFoU/2nfbBH4/sVuKtw== X-UI-Out-Filterresults: notjunk:1; V01:K0:JN8pc9nQ9Hs=:5ZDJA6fJ3bXbbLSyPs9BO4 NwRFqKFxvUpHiiZlGGW4pBexFrCcpZai7oIlwts9oNxh8jjYgpfUqF0h0eUKuC+BJbz1X7Cgg cwNVRWJJCxs7N4wgt2Df9UygZwE1S54tGWTEwgHR34v/9k+7xhKkenfU4v/aG0/YsHIcvgn88 jeyG66DAa150YgH4CYXesvId1oN/O5Pqodx0cHfLERtXbGZUFTJw1HOdW//jOoQ56l2FpUuF1 6Ve1ZFUMeQbZBDrvj7cQyJTbSSc1URD4TjwwLjHA0nE3uOfuWOIv/FADd4K0kqcaZfpCkKRyv DeDci52W6KmdSK3mMHTRt3BpARCqE6J9FBrxF0Nxo0MEINBzLddNpZXkDNYkTypCGh2qxq7oP 5zMr9chZPAKGGn5Bpe/TC0LmRAXlgxzz6rejnN9VicWePxf2Em59JhLr3N+tHnrHrT0EjB5O8 hF3+Q1uuHfpIG4/UKLRS34YsjVykkeGzRvhTL///LpilpzDj2NPCNE8PCG9BR2E1IzRyP/QbW 25ktyrRL9NneG3seNelsD6VPIv4wuMRS4zIze0qKYwgxxcfJQvlhJutv6A70FEpRipkrFc8Y1 lcaucf2R6ytI4+D38jTZYpsuStqbfh5eCUrYuwuCmV/jtaw3TMU1Myaw2RmP8jBUoA6yNpq16 R8++3v74Z7Ryaj5LdrO+T8huFSjt5jNMGkQZPlNxZeAZTMSvDiVY6x5jbvhpsqWGAzmU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-7 detects a short memset in mvpp2, introduced in the original merge of the driver: drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_cls_init': drivers/net/ethernet/marvell/mvpp2.c:3296:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] The result seems to be that we write uninitialized data into the flow table registers, although we did not get any warning about that uninitialized data usage. Using sizeof() lets us initialize then entire array instead. Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/marvell/mvpp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index ee857868bea5..dabc5418efcc 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -3293,7 +3293,7 @@ static void mvpp2_cls_init(struct mvpp2 *priv) mvpp2_write(priv, MVPP2_CLS_MODE_REG, MVPP2_CLS_MODE_ACTIVE_MASK); /* Clear classifier flow table */ - memset(&fe.data, 0, MVPP2_CLS_FLOWS_TBL_DATA_WORDS); + memset(&fe.data, 0, sizeof(fe.data)); for (index = 0; index < MVPP2_CLS_FLOWS_TBL_SIZE; index++) { fe.index = index; mvpp2_cls_flow_write(priv, &fe);