From patchwork Tue Oct 11 18:41:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 77521 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp153127qge; Tue, 11 Oct 2016 12:41:15 -0700 (PDT) X-Received: by 10.99.143.20 with SMTP id n20mr3516491pgd.70.1476214875435; Tue, 11 Oct 2016 12:41:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m185si1960882pga.275.2016.10.11.12.41.15; Tue, 11 Oct 2016 12:41:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbcJKTlM (ORCPT + 27 others); Tue, 11 Oct 2016 15:41:12 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:36138 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcJKTlK (ORCPT ); Tue, 11 Oct 2016 15:41:10 -0400 Received: by mail-oi0-f66.google.com with SMTP id e12so2091260oib.3 for ; Tue, 11 Oct 2016 12:41:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5M8LxzlbYWDjQ8LulNBhX9spO8T5JpIhf7mdcVgkTYE=; b=N2TNN6vZs5KdXRd+cHTX+RB8YPv3esvNzVJI8eF28UqiI7ChF/FXmnqlUf59OLIBnp sCNuRJo97HD9S910TQiBA7x3auDlt9dZdCvvJvPBXWk3VwSoxHFZhtSWnVcZjBpMnd0M b+cUZaLvtzXyX0zOvT6R6xrfNOAwrKnATest4VSCk+V2e9nlvwx8cQmL0owfP6DNPcBi ccWmIi2BHhcbH0Er8hvJM8PcrTAXHhoeLNeHD3omjOkCsUTUMG8OQMNPXhoKTOD8hQj7 E8bPUMaOH7uVKWKn8ZUK3EQtg+DRiijGhk/37piIawugpz5MZ8PDlCF2q7gCzqL5SdRr eMBw== X-Gm-Message-State: AA6/9RlFNt+1dNPiS5QQm612IgmqoK5CmozIpAhzRi6FvE8IOQqJ/AA3tVf3jlKwjzvQww== X-Received: by 10.202.50.69 with SMTP id y66mr3803516oiy.164.1476211264686; Tue, 11 Oct 2016 11:41:04 -0700 (PDT) Received: from rob-hp-laptop.herring.priv (72-48-98-129.dyn.grandenetworks.net. [72.48.98.129]) by smtp.googlemail.com with ESMTPSA id s130sm1543049oif.3.2016.10.11.11.41.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Oct 2016 11:41:04 -0700 (PDT) From: Rob Herring To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Laszlo Ersek Subject: [PATCH 1/2] driver core: skip removal test for non-removable drivers Date: Tue, 11 Oct 2016 13:41:02 -0500 Message-Id: <20161011184103.17744-1-robh@kernel.org> X-Mailer: git-send-email 2.10.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some drivers do not support removal/unbinding. These drivers should have drv->suppress_bind_attrs set to true, so use that to skip the removal test. This doesn't fix anything reported so far, but should prevent some other cases. Some drivers will need fixes to set suppress_bind_attrs to avoid this test. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177021 Fixes: bea5b158ff0d ("driver core: add test of driver remove calls during probe") Reported-by: Laszlo Ersek Signed-off-by: Rob Herring --- drivers/base/dd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.10.0 diff --git a/drivers/base/dd.c b/drivers/base/dd.c index d22a7260f42b..8937a7ad7165 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -324,7 +324,8 @@ static int really_probe(struct device *dev, struct device_driver *drv) { int ret = -EPROBE_DEFER; int local_trigger_count = atomic_read(&deferred_trigger_count); - bool test_remove = IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE); + bool test_remove = IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE) && + !drv->suppress_bind_attrs; if (defer_all_probes) { /*