From patchwork Wed Sep 21 10:05:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 76679 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1960258qgf; Wed, 21 Sep 2016 03:06:44 -0700 (PDT) X-Received: by 10.66.254.102 with SMTP id ah6mr62718725pad.59.1474452403941; Wed, 21 Sep 2016 03:06:43 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si75228562pfk.264.2016.09.21.03.06.43; Wed, 21 Sep 2016 03:06:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755057AbcIUKGl (ORCPT + 27 others); Wed, 21 Sep 2016 06:06:41 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34582 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbcIUKGk (ORCPT ); Wed, 21 Sep 2016 06:06:40 -0400 Received: by mail-pf0-f193.google.com with SMTP id 21so2206975pfy.1 for ; Wed, 21 Sep 2016 03:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=94bvqlC7g0hh91lg3vWLvMcZ9X68AL6W8Me16oqb594=; b=Q6TztZ/6qu3er9+YH6cR9KnJeERi7f5QfKCFiUXTCnJ9BFJa3iUwo2MZCfowC4dXXR D7GTXFnZ0eLe6ieUwZy/QNmG+ma+Tl8Kmt7k3Y1RPXn5dmhILB6xOgYO5ITvSCh2BnVg YTGlTdx4SuIww2Jfd4pfkjz06BgisVnMdM+DgJ8Buvub1zLBowbltcRMy9blr4qc1+wB VZG+f6C3Nr9zkRInft+tFqM8FCt2J2ix83cuyV6/V+SKKiRtfo0DG2zEbdhWCSFskg43 iQ8b4Sb1Y7vnkiLSrOHP6M8VRzRnnxlfaOTPzn6IxYIfwLMTChfD0AWSXVi2tgNf1PxL ZDMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=94bvqlC7g0hh91lg3vWLvMcZ9X68AL6W8Me16oqb594=; b=VDxeAf+Kk1TWVJIvjeyTM5fpl8kxtiezTzz+5sJe09rtWbclevwHVs7GHTi+NRG5Uz qxNeLGR+qCwThmhDsg0pqVR8VpZKaJcgauF5pm5KSKYnBy06cvfhAd7KHIfQFBSnOqjV 2uEMMMB+ETcILgZTKFcgM1g+I364ewJoabCciLYscVUUF1uQEwaDzDZJgD58eJxPnf5b 10Waxkh0KUmGJyns3yb7ZJBsVN6QMxb3PeW7pFHRQK4DWDSgDs7wGaoNEGtzGqsLl9pK omqQhG7yV9QuviEbUDXncV/OFOeqbbjxJmBHe3wIzbyMY4pYk7Zz5c2t99dYIrp2iH3h AVnQ== X-Gm-Message-State: AE9vXwOdNMYPsr/0RoAkcxrYJxnmeQ0npHgkeExiH5+uHIFDEeSD23j4gwwJ0d7pLEYVhA== X-Received: by 10.98.49.198 with SMTP id x189mr64041992pfx.135.1474452399541; Wed, 21 Sep 2016 03:06:39 -0700 (PDT) Received: from aurora.jms.id.au ([2403:480:11:8000:5c8c:f8cc:16c2:c6db]) by smtp.gmail.com with ESMTPSA id mz4sm45344918pab.21.2016.09.21.03.06.35 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Sep 2016 03:06:38 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Wed, 21 Sep 2016 19:36:30 +0930 From: Joel Stanley To: minyard@acm.org Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, clg@kaod.org Subject: [PATCH] ipmi: Fix ioremap error handling in bt-bmc Date: Wed, 21 Sep 2016 19:35:53 +0930 Message-Id: <20160921100553.16314-1-joel@jms.id.au> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap_resource returns ERR_PTR so we can't check for NULL. Signed-off-by: Joel Stanley --- drivers/char/ipmi/bt-bmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.3 diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c index 2e880bf0be26..de64bf1f2f4d 100644 --- a/drivers/char/ipmi/bt-bmc.c +++ b/drivers/char/ipmi/bt-bmc.c @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev) } bt_bmc->base = devm_ioremap_resource(&pdev->dev, res); - if (!bt_bmc->base) - return -ENOMEM; + if (IS_ERR(bt_bmc->base)) + return PTR_ERR(bt_bmc->base); mutex_init(&bt_bmc->mutex); init_waitqueue_head(&bt_bmc->queue);